From: Liam Girdwood <lrg@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "Peter.Hsiang@maxim-ic.com" <Peter.Hsiang@maxim-ic.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Jin Park <jinyoungp@nvidia.com>,
"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 0/1] Submitting MAX98088 codec patch
Date: Thu, 9 Jun 2011 14:51:52 +0100 [thread overview]
Message-ID: <4DF0CFF8.1040106@ti.com> (raw)
In-Reply-To: <20110609104758.GC12865@opensource.wolfsonmicro.com>
On 09/06/11 11:47, Mark Brown wrote:
> On Thu, Jun 09, 2011 at 05:50:16PM +0900, Jin Park wrote:
>
>> The max98088 codec driver had unnecessary duplicated codes on DAI operations.
>> For example, max98088_dai1_hw_params and max98088_dai2_hw_params,
>> they are almost same, except only register offsets.
>> So I have combined DAI operations for DAI1 and DAI2.
>> Please review my patch.
>
> Note that there's no need to have a cover letter for a single patch -
> any useful information should be in the patch itself.
> _______________________________________________
>
Acked-by: Liam Girdwood <lrg@ti.com>
prev parent reply other threads:[~2011-06-09 13:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BANLkTikLubBnrPp0BTMcNEFp2sfAyZnE4A@mail.gmail.com>
2011-06-09 10:47 ` [PATCH 0/1] Submitting MAX98088 codec patch Mark Brown
2011-06-09 13:51 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF0CFF8.1040106@ti.com \
--to=lrg@ti.com \
--cc=Peter.Hsiang@maxim-ic.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jassisinghbrar@gmail.com \
--cc=jinyoungp@nvidia.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.