Re: [PATCH] ARM: S5PC110: enable PWM timers for GONI board

[Kukjin Kim <kgene.kim@samsung.com>]

On 06/06/11 23:45, Marek Szyprowski wrote:
> s5p_timer requires PWM device to be compiled in. Add aproperiate Kconfig
> select directive for GONI machine, so compilation won't fail if GONI is
> the only machine compiled into the kernel.
>
> Signed-off-by: Marek Szyprowski<m.szyprowski@samsung.com>
> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
>
> ---
>   arch/arm/mach-s5pv210/Kconfig |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
> index 37b5a97..aceafb4 100644
> --- a/arch/arm/mach-s5pv210/Kconfig
> +++ b/arch/arm/mach-s5pv210/Kconfig
> @@ -92,6 +92,7 @@ config MACH_GONI
>   	select S3C_DEV_I2C2
>   	select S3C_DEV_USB_HSOTG
>   	select S5P_DEV_ONENAND
> +	select SAMSUNG_DEV_PWM
>   	select SAMSUNG_DEV_KEYPAD
>   	select S5PV210_SETUP_FB_24BPP
>   	select S5PV210_SETUP_I2C1

Yeah, SAMSUNG_DEV_PWM is required to use s5p-time.c for HRT.
So I think following is better.

Marek, if you don't mind, I'd like to apply below...

diff --git a/arch/arm/plat-s5p/Kconfig b/arch/arm/plat-s5p/Kconfig
index e98f5c5..7f9ff2a 100644
--- a/arch/arm/plat-s5p/Kconfig
+++ b/arch/arm/plat-s5p/Kconfig
@@ -39,6 +39,7 @@ config S5P_GPIO_INT

  config S5P_HRT
         bool
+       select SAMSUNG_DEV_PWM
         help
           Use the High Resolution timer support

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.