* [PATCH] ARM: S5PC110: enable PWM timers for GONI board
@ 2011-06-07 6:45 Marek Szyprowski
2011-06-09 22:12 ` Kukjin Kim
0 siblings, 1 reply; 3+ messages in thread
From: Marek Szyprowski @ 2011-06-07 6:45 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: Marek Szyprowski, Kyungmin Park, Kukjin Kim
s5p_timer requires PWM device to be compiled in. Add aproperiate Kconfig
select directive for GONI machine, so compilation won't fail if GONI is
the only machine compiled into the kernel.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
arch/arm/mach-s5pv210/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
index 37b5a97..aceafb4 100644
--- a/arch/arm/mach-s5pv210/Kconfig
+++ b/arch/arm/mach-s5pv210/Kconfig
@@ -92,6 +92,7 @@ config MACH_GONI
select S3C_DEV_I2C2
select S3C_DEV_USB_HSOTG
select S5P_DEV_ONENAND
+ select SAMSUNG_DEV_PWM
select SAMSUNG_DEV_KEYPAD
select S5PV210_SETUP_FB_24BPP
select S5PV210_SETUP_I2C1
--
1.7.1.569.g6f426
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: S5PC110: enable PWM timers for GONI board
2011-06-07 6:45 [PATCH] ARM: S5PC110: enable PWM timers for GONI board Marek Szyprowski
@ 2011-06-09 22:12 ` Kukjin Kim
2011-06-10 5:42 ` Marek Szyprowski
0 siblings, 1 reply; 3+ messages in thread
From: Kukjin Kim @ 2011-06-09 22:12 UTC (permalink / raw)
To: Marek Szyprowski; +Cc: linux-samsung-soc, Kyungmin Park
On 06/06/11 23:45, Marek Szyprowski wrote:
> s5p_timer requires PWM device to be compiled in. Add aproperiate Kconfig
> select directive for GONI machine, so compilation won't fail if GONI is
> the only machine compiled into the kernel.
>
> Signed-off-by: Marek Szyprowski<m.szyprowski@samsung.com>
> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
>
> ---
> arch/arm/mach-s5pv210/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
> index 37b5a97..aceafb4 100644
> --- a/arch/arm/mach-s5pv210/Kconfig
> +++ b/arch/arm/mach-s5pv210/Kconfig
> @@ -92,6 +92,7 @@ config MACH_GONI
> select S3C_DEV_I2C2
> select S3C_DEV_USB_HSOTG
> select S5P_DEV_ONENAND
> + select SAMSUNG_DEV_PWM
> select SAMSUNG_DEV_KEYPAD
> select S5PV210_SETUP_FB_24BPP
> select S5PV210_SETUP_I2C1
Yeah, SAMSUNG_DEV_PWM is required to use s5p-time.c for HRT.
So I think following is better.
Marek, if you don't mind, I'd like to apply below...
diff --git a/arch/arm/plat-s5p/Kconfig b/arch/arm/plat-s5p/Kconfig
index e98f5c5..7f9ff2a 100644
--- a/arch/arm/plat-s5p/Kconfig
+++ b/arch/arm/plat-s5p/Kconfig
@@ -39,6 +39,7 @@ config S5P_GPIO_INT
config S5P_HRT
bool
+ select SAMSUNG_DEV_PWM
help
Use the High Resolution timer support
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] ARM: S5PC110: enable PWM timers for GONI board
2011-06-09 22:12 ` Kukjin Kim
@ 2011-06-10 5:42 ` Marek Szyprowski
0 siblings, 0 replies; 3+ messages in thread
From: Marek Szyprowski @ 2011-06-10 5:42 UTC (permalink / raw)
To: 'Kukjin Kim'; +Cc: linux-samsung-soc, 'Kyungmin Park'
Hello,
On Friday, June 10, 2011 12:12 AM Kukjin Kim wrote:
> On 06/06/11 23:45, Marek Szyprowski wrote:
> > s5p_timer requires PWM device to be compiled in. Add aproperiate Kconfig
> > select directive for GONI machine, so compilation won't fail if GONI is
> > the only machine compiled into the kernel.
> >
> > Signed-off-by: Marek Szyprowski<m.szyprowski@samsung.com>
> > Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
> >
> > ---
> > arch/arm/mach-s5pv210/Kconfig | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-
> s5pv210/Kconfig
> > index 37b5a97..aceafb4 100644
> > --- a/arch/arm/mach-s5pv210/Kconfig
> > +++ b/arch/arm/mach-s5pv210/Kconfig
> > @@ -92,6 +92,7 @@ config MACH_GONI
> > select S3C_DEV_I2C2
> > select S3C_DEV_USB_HSOTG
> > select S5P_DEV_ONENAND
> > + select SAMSUNG_DEV_PWM
> > select SAMSUNG_DEV_KEYPAD
> > select S5PV210_SETUP_FB_24BPP
> > select S5PV210_SETUP_I2C1
>
> Yeah, SAMSUNG_DEV_PWM is required to use s5p-time.c for HRT.
> So I think following is better.
>
> Marek, if you don't mind, I'd like to apply below...
>
> diff --git a/arch/arm/plat-s5p/Kconfig b/arch/arm/plat-s5p/Kconfig
> index e98f5c5..7f9ff2a 100644
> --- a/arch/arm/plat-s5p/Kconfig
> +++ b/arch/arm/plat-s5p/Kconfig
> @@ -39,6 +39,7 @@ config S5P_GPIO_INT
>
> config S5P_HRT
> bool
> + select SAMSUNG_DEV_PWM
> help
> Use the High Resolution timer support
>
> Thanks.
Yes, this one looks better.
Best regards
--
Marek Szyprowski
Samsung Poland R&D Center
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-10 5:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-07 6:45 [PATCH] ARM: S5PC110: enable PWM timers for GONI board Marek Szyprowski
2011-06-09 22:12 ` Kukjin Kim
2011-06-10 5:42 ` Marek Szyprowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.