All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rajendra Nayak <rnayak@ti.com>
To: Todd Poynor <toddpoynor@google.com>
Cc: linux-omap@vger.kernel.org, paul@pwsan.com, khilman@ti.com,
	b-cousson@ti.com, santosh.shilimkar@ti.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/8] OMAP2+: clockdomain: Add an api to read idle mode
Date: Fri, 10 Jun 2011 16:38:47 +0530	[thread overview]
Message-ID: <4DF1FB3F.1040906@ti.com> (raw)
In-Reply-To: <20110610000715.GA9059@google.com>

On 6/10/2011 5:37 AM, Todd Poynor wrote:
> On Thu, Jun 09, 2011 at 04:24:06PM +0530, Rajendra Nayak wrote:
>> Add a clockdomain api to check if hardware supervised
>> idle transitions are enabled on a clockdomain.
>>
> ...
>> + * clkdm_is_idle - Check if the clkdm hwsup/autoidle is enabled
>
> A minor suggestion on naming: "clkdm_allows_idle" seems more accurate
> and a natural complement to the existing clkdm_allow_idle().

Yeah, I agree. I'll change it in my next spin.

Thanks,
Rajendra
>
>
> Todd


WARNING: multiple messages have this Message-ID (diff)
From: rnayak@ti.com (Rajendra Nayak)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/8] OMAP2+: clockdomain: Add an api to read idle mode
Date: Fri, 10 Jun 2011 16:38:47 +0530	[thread overview]
Message-ID: <4DF1FB3F.1040906@ti.com> (raw)
In-Reply-To: <20110610000715.GA9059@google.com>

On 6/10/2011 5:37 AM, Todd Poynor wrote:
> On Thu, Jun 09, 2011 at 04:24:06PM +0530, Rajendra Nayak wrote:
>> Add a clockdomain api to check if hardware supervised
>> idle transitions are enabled on a clockdomain.
>>
> ...
>> + * clkdm_is_idle - Check if the clkdm hwsup/autoidle is enabled
>
> A minor suggestion on naming: "clkdm_allows_idle" seems more accurate
> and a natural complement to the existing clkdm_allow_idle().

Yeah, I agree. I'll change it in my next spin.

Thanks,
Rajendra
>
>
> Todd

  reply	other threads:[~2011-06-10 11:08 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-09 10:54 [PATCH 0/8] Fix module-mode enable sequence on OMAP4 Rajendra Nayak
2011-06-09 10:54 ` Rajendra Nayak
2011-06-09 10:54 ` [PATCH 1/8] OMAP2+: clockdomain: Add an api to read idle mode Rajendra Nayak
2011-06-09 10:54   ` Rajendra Nayak
2011-06-09 10:54   ` [PATCH 2/8] OMAP2+: clockdomain: Add SoC support for clkdm_is_idle Rajendra Nayak
2011-06-09 10:54     ` Rajendra Nayak
2011-06-09 10:54     ` [PATCH 3/8] OMAP2+: PM: Initialise sleep_switch to a non-valid value Rajendra Nayak
2011-06-09 10:54       ` Rajendra Nayak
2011-06-09 10:54       ` [PATCH 4/8] OMAP2+: PM: idle clkdms only if already in idle Rajendra Nayak
2011-06-09 10:54         ` Rajendra Nayak
2011-06-09 10:54         ` [PATCH 5/8] OMAP4: PM: TEMP: Prevent l3init from idling/force sleep Rajendra Nayak
2011-06-09 10:54           ` Rajendra Nayak
2011-06-09 10:54           ` [PATCH 6/8] OMAP2+: hwmod: Follow the recomended PRCM clock enable sequence Rajendra Nayak
2011-06-09 10:54             ` Rajendra Nayak
2011-06-09 10:54             ` [PATCH 7/8] OMAP: clock: Add flags to identify optional clock nodes Rajendra Nayak
2011-06-09 10:54               ` Rajendra Nayak
2011-06-09 10:54               ` [PATCH 8/8] OMAP: clock: Enable clockdomain only for optional clocks Rajendra Nayak
2011-06-09 10:54                 ` Rajendra Nayak
2011-06-23 15:04           ` [PATCH 5/8] OMAP4: PM: TEMP: Prevent l3init from idling/force sleep Paul Walmsley
2011-06-23 15:04             ` Paul Walmsley
2011-06-23 15:22             ` Russell King - ARM Linux
2011-06-23 15:22               ` Russell King - ARM Linux
2011-07-06  5:30               ` Paul Walmsley
2011-07-06  5:30                 ` Paul Walmsley
2011-06-10  0:15         ` [PATCH 4/8] OMAP2+: PM: idle clkdms only if already in idle Todd Poynor
2011-06-10  0:15           ` Todd Poynor
2011-06-10 11:22           ` Rajendra Nayak
2011-06-10 11:22             ` Rajendra Nayak
2011-06-27  6:34             ` Paul Walmsley
2011-06-27  6:34               ` Paul Walmsley
2011-06-27 23:36               ` Rajendra Nayak
2011-06-27 23:36                 ` Rajendra Nayak
2011-06-10  0:07   ` [PATCH 1/8] OMAP2+: clockdomain: Add an api to read idle mode Todd Poynor
2011-06-10  0:07     ` Todd Poynor
2011-06-10 11:08     ` Rajendra Nayak [this message]
2011-06-10 11:08       ` Rajendra Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DF1FB3F.1040906@ti.com \
    --to=rnayak@ti.com \
    --cc=b-cousson@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=toddpoynor@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.