All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] emulator: fix request tests
  2011-06-16 13:27 [PATCH] emulator: fix request tests =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
@ 2011-06-15 14:21 ` Denis Kenzior
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2011-06-15 14:21 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

Hi Frédéric,

On 06/16/2011 08:27 AM, Frédéric Danis wrote:
> ---
>  src/emulator.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 

Patch has been applied with a minor style amendment.

Regards,
-Denis

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] emulator: fix request tests
@ 2011-06-16 13:27 =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
  2011-06-15 14:21 ` Denis Kenzior
  0 siblings, 1 reply; 2+ messages in thread
From: =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis @ 2011-06-16 13:27 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 769 bytes --]

---
 src/emulator.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/emulator.c b/src/emulator.c
index c120ad3..8821afd 100644
--- a/src/emulator.c
+++ b/src/emulator.c
@@ -433,7 +433,7 @@ static void brsf_cb(GAtServer *server, GAtServerRequestType type,
 		if (g_at_result_iter_next_number(&iter, &val) == FALSE)
 			goto fail;
 
-		if ((val < 0) && (val > 127))
+		if ((val < 0) || (val > 127))
 			goto fail;
 
 		em->r_features = val;
@@ -715,7 +715,7 @@ static void cmee_cb(GAtServer *server, GAtServerRequestType type,
 		if (g_at_result_iter_next_number(&iter, &val) == FALSE)
 			goto fail;
 
-		if (val < 0 && val > 1)
+		if (val != 0 && val != 1)
 			goto fail;
 
 		em->cmee_mode = val;
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-06-16 13:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-16 13:27 [PATCH] emulator: fix request tests =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
2011-06-15 14:21 ` Denis Kenzior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.