From: Arun Sharma <asharma@fb.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
David Miller <davem@davemloft.net>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH 1/3] atomic: use <linux/atomic.h>
Date: Wed, 15 Jun 2011 17:57:07 -0700 [thread overview]
Message-ID: <4DF954E3.6040701@fb.com> (raw)
In-Reply-To: <20110615163115.773d072e.akpm@linux-foundation.org>
On 6/15/11 4:31 PM, Andrew Morton wrote:
>
> I didn't merge patch #3. With patches 1& 2 applied, i386 allnoconfig:
>
Dropping patch#3 is fine, since Eric removed the primitive. For this
problem, I'm testing a patch along the lines of:
--- a/arch/x86/include/asm/atomic.h
+++ b/arch/x86/include/asm/atomic.h
@@ -318,5 +318,4 @@ static inline void atomic_or_long(unsigned long *v1,
unsigned long v2)
# include "atomic64_64.h"
#endif
-#include <asm-generic/atomic-long.h>
#endif /* _ASM_X86_ATOMIC_H */
--- a/include/linux/atomic.h
+++ b/include/linux/atomic.h
@@ -85,4 +85,8 @@ static inline void atomic_or(int i, atomic_t *v)
}
#endif /* #ifndef CONFIG_ARCH_HAS_ATOMIC_OR */
+#include <asm-generic/atomic-long.h>
+#ifdef CONFIG_GENERIC_ATOMIC64
+#include <asm-generic/atomic64.h>
+#endif
#endif /* _LINUX_ATOMIC_H */
.. repeated for all other archs.
-Arun
next prev parent reply other threads:[~2011-06-16 0:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 17:27 [PATCH 1/3] atomic: use <linux/atomic.h> Arun Sharma
2011-06-06 17:27 ` [PATCH 2/3] atomic: move atomic_add_unless to generic code Arun Sharma
2011-06-06 20:56 ` Eric Dumazet
2011-06-06 17:27 ` [PATCH 3/3] atomic: generalize atomic_add_unless_return Arun Sharma
2011-06-06 20:58 ` Eric Dumazet
2011-06-09 18:01 ` Eric Dumazet
2011-06-06 20:55 ` [PATCH 1/3] atomic: use <linux/atomic.h> Eric Dumazet
2011-06-06 21:06 ` Arun Sharma
2011-06-15 23:31 ` Andrew Morton
2011-06-16 0:57 ` Arun Sharma [this message]
2011-06-16 1:29 ` [PATCH] atomic: cleanup asm-generic atomic*.h inclusion Arun Sharma
2011-06-17 6:36 ` Mike Frysinger
2011-06-17 17:11 ` Arun Sharma
2011-06-17 17:28 ` Mike Frysinger
2011-06-17 17:49 ` Arun Sharma
2011-06-17 18:06 ` Mike Frysinger
2011-06-17 18:42 ` Arun Sharma
2011-06-17 19:07 ` Mike Frysinger
2011-06-17 20:05 ` Arun Sharma
-- strict thread matches above, loose matches on Subject: below --
2011-06-08 0:07 [PATCH 1/3] atomic: use <linux/atomic.h> Arun Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF954E3.6040701@fb.com \
--to=asharma@fb.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.