From: Arun Sharma <asharma@fb.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Ingo Molnar <mingo@elte.hu>, David Miller <davem@davemloft.net>
Subject: Re: [PATCH] atomic: cleanup asm-generic atomic*.h inclusion
Date: Fri, 17 Jun 2011 13:05:16 -0700 [thread overview]
Message-ID: <4DFBB37C.2060004@fb.com> (raw)
In-Reply-To: <BANLkTinQhBfAJd5-ZaPXbiV778c9fvXeWg@mail.gmail.com>
On 6/17/11 12:07 PM, Mike Frysinger wrote:
>> <linux/atomic.h> a header file that's usable in machine independent kernel
>> code.
>
> if that's the direction we want to take things, then this needs to be
> documented at the top of both files. i also see quite a lot of
> primitives in asm-generic/atomic.h that would be better placed using
> your definitions in linux/atomic.h.
>
I incorporated your feedback in the patch set I just sent out. Thanks
for the review. Please let me know if the new patch set works better for
you.
-Arun
prev parent reply other threads:[~2011-06-17 20:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 17:27 [PATCH 1/3] atomic: use <linux/atomic.h> Arun Sharma
2011-06-06 17:27 ` [PATCH 2/3] atomic: move atomic_add_unless to generic code Arun Sharma
2011-06-06 20:56 ` Eric Dumazet
2011-06-06 17:27 ` [PATCH 3/3] atomic: generalize atomic_add_unless_return Arun Sharma
2011-06-06 20:58 ` Eric Dumazet
2011-06-09 18:01 ` Eric Dumazet
2011-06-06 20:55 ` [PATCH 1/3] atomic: use <linux/atomic.h> Eric Dumazet
2011-06-06 21:06 ` Arun Sharma
2011-06-15 23:31 ` Andrew Morton
2011-06-16 0:57 ` Arun Sharma
2011-06-16 1:29 ` [PATCH] atomic: cleanup asm-generic atomic*.h inclusion Arun Sharma
2011-06-17 6:36 ` Mike Frysinger
2011-06-17 17:11 ` Arun Sharma
2011-06-17 17:28 ` Mike Frysinger
2011-06-17 17:49 ` Arun Sharma
2011-06-17 18:06 ` Mike Frysinger
2011-06-17 18:42 ` Arun Sharma
2011-06-17 19:07 ` Mike Frysinger
2011-06-17 20:05 ` Arun Sharma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFBB37C.2060004@fb.com \
--to=asharma@fb.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.