From: Vincent Hanquez <vincent.hanquez@eu.citrix.com>
To: "Ren, Yongjie" <yongjie.ren@intel.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: make tools ERROR in latest xen-unstable.hg
Date: Fri, 17 Jun 2011 08:01:46 +0100 [thread overview]
Message-ID: <4DFAFBDA.8070001@eu.citrix.com> (raw)
In-Reply-To: <CE59C043D0EC3349B2BF41C0EC72229B12D187CB5E@shsmsx501.ccr.corp.intel.com>
On 06/17/2011 07:29 AM, Ren, Yongjie wrote:
> Hi all,
> In our test, xen-unstable build fails. When running 'make tools', I got the following error. Do you have the same issue ?
> xl_cmdimpl.c: In function 'acquire_lock':
> xl_cmdimpl.c:202: error: 'O_CLOEXEC' undeclared (first use in this function)
> xl_cmdimpl.c:202: error: (Each undeclared identifier is reported only once
> xl_cmdimpl.c:202: error: for each function it appears in.)
I've just got bitten by that in another repository [1]
looks like you use an old distribution (flags that appears in the kernel
in 2.6.23).
The solution is simple since there's no need for the atomicity: it
consists in removing O_CLOEXEC and switching to fcntl(fd, F_SETFD,
FD_CLOEXEC)
[1]
https://github.com/xen-org/xen-api-libs/commit/523e1c5364e11e0d5bbd5308988c263392df0559
--
Vincent
next prev parent reply other threads:[~2011-06-17 7:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-17 6:29 make tools ERROR in latest xen-unstable.hg Ren, Yongjie
2011-06-17 7:01 ` Vincent Hanquez [this message]
2011-06-17 7:58 ` Zhang, Yang Z
2011-06-17 8:12 ` Vincent Hanquez
2011-06-20 14:29 ` make tools ERROR in latest xen-unstable.hg [and 1 more messages] Ian Jackson
2011-06-21 7:28 ` [PATCH] tools/libxl: remove O_CLOEXEC in xl_cmdimpl.c Ren, Yongjie
2011-06-21 14:31 ` Ian Jackson
2011-06-21 15:14 ` Christoph Egger
2011-06-21 15:20 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFAFBDA.8070001@eu.citrix.com \
--to=vincent.hanquez@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
--cc=yongjie.ren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.