From: Shan Wei <shanwei@cn.fujitsu.com>
To: linux-sctp@vger.kernel.org
Subject: Re: [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem
Date: Mon, 20 Jun 2011 09:41:07 +0000 [thread overview]
Message-ID: <4DFF15B3.4050900@cn.fujitsu.com> (raw)
In-Reply-To: <19967.385.752160.374716@regina.usersys.redhat.com>
Hi
Some comments inline.
And Cc David Miller who maybe will accepte your patch.
Max Matveev wrote, at 06/20/2011 04:36 PM:
> On Mon, 20 Jun 2011 16:29:25 +0800, Shan Wei wrote:
>
> shanwei> I can't open the attachment.
> shanwei> Please include your patch contents in the mail.
> shanwei> So that be convenient to review.
>
> commit 7bc21f45041b9e2619e59c9c1f8a2368f0bb0aa1
> Author: Max Matveev <makc@redhat.com>
> Date: Mon Jun 20 18:08:10 2011 +1000
>
> Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem tunables
>
> sctp does not use second and third ("default" and "max") values
> of sctp_(r|w)mem tunables. The format is the same and tcp_(r|w)mem
> but the meaning is different so make the documentation explicit to
> avoid confusion.
>
> Signed-off-by: Max Matveev <makc@redhat.com>
>
> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
> index d3d653a..81734c0 100644
> --- a/Documentation/networking/ip-sysctl.txt
> +++ b/Documentation/networking/ip-sysctl.txt
> @@ -1465,10 +1465,23 @@ sctp_mem - vector of 3 INTEGERs: min, pressure, max
> Default is calculated at boot time from amount of available memory.
>
> sctp_rmem - vector of 3 INTEGERs: min, default, max
> - See tcp_rmem for a description.
> + Only the first value ("min") is used, "default" and "max" are
> + ignored and may be removed in the future versions.
> +
> + min: Minimal size of receive buffer used by SCTP socket.
> + It is guaranteed to each STCP socket (but not association) even
> + under moderate memory pressure.
> +
> + Default: 1 page
how about 4K?
>
> sctp_wmem - vector of 3 INTEGERs: min, default, max
> - See tcp_wmem for a description.
> + Only the first value ("min") is used, "default" and "max" are
> + ignored and may be removed in the future versions.
sctp_wmem parameter include all three fields never be used by sctp protocol.
The min value is not used.
> +
> + min: Amount of memory reserved for send buffers for SCTP sockets.
> + Each SCTP socket has rights to use it due to fact of its birth.
> +
> + Default: 1 page
>
> addr_scope_policy - INTEGER
> Control IPv4 address scoping - draft-stewart-tsvwg-sctp-ipv4-00
>
>
>
--
Best Regards
-----
Shan Wei
next prev parent reply other threads:[~2011-06-20 9:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 8:14 [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem tunables Max Matveev
2011-06-20 8:29 ` [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem Shan Wei
2011-06-20 8:36 ` Max Matveev
2011-06-20 9:41 ` Shan Wei [this message]
2011-06-20 18:49 ` [PATCH] Update description of net.sctp.sctp_rmem and David Miller
2011-06-21 1:29 ` [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem Max Matveev
2011-06-21 2:16 ` Shan Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFF15B3.4050900@cn.fujitsu.com \
--to=shanwei@cn.fujitsu.com \
--cc=linux-sctp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.