From: Shan Wei <shanwei@cn.fujitsu.com>
To: linux-sctp@vger.kernel.org
Subject: Re: [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem
Date: Tue, 21 Jun 2011 02:16:52 +0000 [thread overview]
Message-ID: <4DFFFF14.5060800@cn.fujitsu.com> (raw)
In-Reply-To: <19967.385.752160.374716@regina.usersys.redhat.com>
Max Matveev wrote, at 06/21/2011 09:29 AM:
> On Mon, 20 Jun 2011 17:41:07 +0800, Shan Wei wrote:
>
> shanwei> Max Matveev wrote, at 06/20/2011 04:36 PM:
> >> On Mon, 20 Jun 2011 16:29:25 +0800, Shan Wei wrote:
> >>
> >> + Default: 1 page
>
> shanwei> how about 4K?
>
> Not everybody uses 4K pages. I can change it to 4K but it will be
> (technically) incorrect.
Use "1 Page" is more exact.
Other parameters(tcp_rmem, tcp_rmem, udp_rmem_min) directly
use magic number(4K or 4096).
So also need same change.
>
> >>
> >> sctp_wmem - vector of 3 INTEGERs: min, default, max
> >> - See tcp_wmem for a description.
> >> + Only the first value ("min") is used, "default" and "max" are
> >> + ignored and may be removed in the future versions.
>
> shanwei> sctp_wmem parameter include all three fields never be used
> shanwei> by sctp protocol. The min value is not used.
>
> I was trying to avoid the embarrassment of admitting that there is a
> tunable which does nothing. Should I add another patch to remove
> the tunable?
No.
Currently, sctp protocol does't implement tunable memory management.
Just provide an interface to user, but no function.
What we need is to implement it, not remove the interface simply.
>
> max
>
--
Best Regards
-----
Shan Wei
prev parent reply other threads:[~2011-06-21 2:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 8:14 [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem tunables Max Matveev
2011-06-20 8:29 ` [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem Shan Wei
2011-06-20 8:36 ` Max Matveev
2011-06-20 9:41 ` Shan Wei
2011-06-20 18:49 ` [PATCH] Update description of net.sctp.sctp_rmem and David Miller
2011-06-21 1:29 ` [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem Max Matveev
2011-06-21 2:16 ` Shan Wei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFFFF14.5060800@cn.fujitsu.com \
--to=shanwei@cn.fujitsu.com \
--cc=linux-sctp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.