From: Sergei Shtylyov <sshtylyov@mvista.com>
To: p.paneri@samsung.com
Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
balbi@ti.com, tmarri@apm.com, naushad@samsung.com,
thomas.ab@samsung.com, a.kesavan@samsung.com
Subject: Re: [RFC][PATCH 2/5] ARM: SAMSUNG: Changing the build condition of OTG platform device for samsung.
Date: Tue, 21 Jun 2011 15:47:04 +0400 [thread overview]
Message-ID: <4E0084B8.1040201@ru.mvista.com> (raw)
In-Reply-To: <1308639827-2121-3-git-send-email-p.paneri@samsung.com>
Hello.
On 21-06-2011 11:03, p.paneri@samsung.com wrote:
> From: Praveen Paneri<p.paneri@samsung.com>
> Adding dwc driver name in existing platform device
> to probe DWC OTG driver.
> Introduced otg_set_platdata function to pass platform data
> Added selectable config option to add DWC OTG driver for different
> machines.
> Signed-off-by: Praveen Paneri<p.paneri@samsung.com>
[...]
> diff --git a/arch/arm/plat-samsung/dev-usb-hsotg.c b/arch/arm/plat-samsung/dev-usb-hsotg.c
> index 33a844a..7e6228b 100644
> --- a/arch/arm/plat-samsung/dev-usb-hsotg.c
> +++ b/arch/arm/plat-samsung/dev-usb-hsotg.c
[...]
> @@ -37,7 +39,12 @@ static struct resource s3c_usb_hsotg_resources[] = {
> static u64 s3c_hsotg_dmamask = DMA_BIT_MASK(32);
>
> struct platform_device s3c_device_usb_hsotg = {
> +#ifdef CONFIG_S3C_DEV_USB_HSOTG
> .name = "s3c-hsotg",
> +#endif
> +#ifdef CONFIG_S3C_DEV_DWC_OTG
> + .name = "dwc_otg",
> +#endif
I'd done it as:
+#if defined(CONFIG_S3C_DEV_USB_HSOTG)
.name = "s3c-hsotg",
+#elif defined(CONFIG_S3C_DEV_DWC_OTG)
+ .name = "dwc_otg",
+#endif
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC][PATCH 2/5] ARM: SAMSUNG: Changing the build condition of OTG platform device for samsung.
Date: Tue, 21 Jun 2011 15:47:04 +0400 [thread overview]
Message-ID: <4E0084B8.1040201@ru.mvista.com> (raw)
In-Reply-To: <1308639827-2121-3-git-send-email-p.paneri@samsung.com>
Hello.
On 21-06-2011 11:03, p.paneri at samsung.com wrote:
> From: Praveen Paneri<p.paneri@samsung.com>
> Adding dwc driver name in existing platform device
> to probe DWC OTG driver.
> Introduced otg_set_platdata function to pass platform data
> Added selectable config option to add DWC OTG driver for different
> machines.
> Signed-off-by: Praveen Paneri<p.paneri@samsung.com>
[...]
> diff --git a/arch/arm/plat-samsung/dev-usb-hsotg.c b/arch/arm/plat-samsung/dev-usb-hsotg.c
> index 33a844a..7e6228b 100644
> --- a/arch/arm/plat-samsung/dev-usb-hsotg.c
> +++ b/arch/arm/plat-samsung/dev-usb-hsotg.c
[...]
> @@ -37,7 +39,12 @@ static struct resource s3c_usb_hsotg_resources[] = {
> static u64 s3c_hsotg_dmamask = DMA_BIT_MASK(32);
>
> struct platform_device s3c_device_usb_hsotg = {
> +#ifdef CONFIG_S3C_DEV_USB_HSOTG
> .name = "s3c-hsotg",
> +#endif
> +#ifdef CONFIG_S3C_DEV_DWC_OTG
> + .name = "dwc_otg",
> +#endif
I'd done it as:
+#if defined(CONFIG_S3C_DEV_USB_HSOTG)
.name = "s3c-hsotg",
+#elif defined(CONFIG_S3C_DEV_DWC_OTG)
+ .name = "dwc_otg",
+#endif
WBR, Sergei
next prev parent reply other threads:[~2011-06-21 11:48 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 7:03 [RFC][PATCH 0/5] USB: DWC OTG: Add dwc_otg driver for S5P6440 samsung SoC p.paneri
2011-06-21 7:03 ` p.paneri at samsung.com
2011-06-21 7:03 ` [RFC][PATCH 1/5] USB: DWC OTG: Modification in DWC OTG driver for ARM based SoCs p.paneri
2011-06-21 7:03 ` p.paneri at samsung.com
2011-06-21 9:25 ` Felipe Balbi
2011-06-21 9:25 ` Felipe Balbi
[not found] ` <1308639827-2121-1-git-send-email-p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2011-06-21 7:03 ` [RFC][PATCH 2/5] ARM: SAMSUNG: Changing the build condition of OTG platform device for samsung p.paneri-Sze3O3UU22JBDgjK7y7TUQ
2011-06-21 7:03 ` p.paneri at samsung.com
[not found] ` <1308639827-2121-3-git-send-email-p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2011-06-21 9:16 ` Felipe Balbi
2011-06-21 9:16 ` Felipe Balbi
2011-06-21 11:47 ` Sergei Shtylyov [this message]
2011-06-21 11:47 ` Sergei Shtylyov
2011-06-21 11:49 ` Felipe Balbi
2011-06-21 11:49 ` Felipe Balbi
[not found] ` <20110621114940.GB2531-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-06-21 12:00 ` Sergei Shtylyov
2011-06-21 12:00 ` Sergei Shtylyov
2011-06-21 7:03 ` [RFC][PATCH 3/5] ARM: SAMSUNG: Adding IO mapping for OTG PHY p.paneri
2011-06-21 7:03 ` p.paneri at samsung.com
[not found] ` <1308639827-2121-4-git-send-email-p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2011-06-21 11:18 ` Banajit Goswami
2011-06-21 11:18 ` Banajit Goswami
2011-06-21 12:15 ` Praveen Paneri
2011-06-21 12:15 ` Praveen Paneri
2011-06-21 7:03 ` [RFC][PATCH 4/5] ARM: S5P64x0: Adding OTG PHY control code p.paneri
2011-06-21 7:03 ` p.paneri at samsung.com
[not found] ` <1308639827-2121-5-git-send-email-p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2011-06-21 9:31 ` Felipe Balbi
2011-06-21 9:31 ` Felipe Balbi
2011-06-21 9:36 ` Russell King - ARM Linux
2011-06-21 9:36 ` Russell King - ARM Linux
2011-06-22 4:18 ` Kyungmin Park
2011-06-22 4:18 ` Kyungmin Park
2011-06-21 7:03 ` [RFC][PATCH 5/5] ARM: S5P64x0: Adding OTG device for smdk6440 p.paneri
2011-06-21 7:03 ` p.paneri at samsung.com
2011-06-21 9:45 ` [RFC][PATCH 0/5] USB: DWC OTG: Add dwc_otg driver for S5P6440 samsung SoC Marek Szyprowski
2011-06-21 9:45 ` Marek Szyprowski
[not found] <0LN4003LQZBUSGU0@mailout4.samsung.com>
2011-06-21 11:50 ` [RFC][PATCH 2/5] ARM: SAMSUNG: Changing the build condition of OTG platform device for samsung Praveen Paneri
2011-06-21 11:50 ` Praveen Paneri
2011-06-21 11:51 ` Felipe Balbi
2011-06-21 11:51 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0084B8.1040201@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=a.kesavan@samsung.com \
--cc=balbi@ti.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=naushad@samsung.com \
--cc=p.paneri@samsung.com \
--cc=thomas.ab@samsung.com \
--cc=tmarri@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.