Re: [PATCH 1/1] routerstationpro: IPC config

[Bruce Ashfield <bruce.ashfield@windriver.com>]

On 06/24/11 03:02, Jingdong Lu wrote:
> From: Jingdong Lu<jingdong.lu@windriver.com>
>
> Add IPC config for routestationpro
>
> Signed-off-by: Jingdong Lu<jingdong.lu@windriver.com>
> ---
>   .../bsp/routerstationpro/routerstationpro.cfg      |   10 +++++++---
>   1 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg b/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
> index f58dfe8..88222ca 100644
> --- a/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
> +++ b/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
> @@ -209,14 +209,18 @@ CONFIG_CONSTRUCTORS=y
>   #
>   # General setup
>   #
> -# CONFIG_EXPERIMENTAL is not set
> +CONFIG_EXPERIMENTAL=y

We typically do not want to enable this. What options is
this triggering that are essential to the IPC config ?

>   CONFIG_BROKEN_ON_SMP=y
>   CONFIG_INIT_ENV_ARG_LIMIT=32
>   CONFIG_LOCALVERSION=""
>   CONFIG_LOCALVERSION_AUTO=y
>   CONFIG_SWAP=y
> -# CONFIG_SYSVIPC is not set
> -# CONFIG_BSD_PROCESS_ACCT is not set
> +CONFIG_SYSVIPC=y
> +CONFIG_SYSVIPC_SYSCTL=y
> +CONFIG_POSIX_MQUEUE=y

These options are already provided by the base configuration
and are supposed to be baseline options for any BSP. Can
you elaborate on why you needed these here ?

Bruce

> +CONFIG_POSIX_MQUEUE_SYSCTL=y
> +CONFIG_BSD_PROCESS_ACCT=y
> +CONFIG_BSD_PROCESS_ACCT_V3=y
>   # CONFIG_TASKSTATS is not set
>   # CONFIG_AUDIT is not set
>