Re: [PATCH 1/1] routerstationpro: IPC config

[Lu Jingdong <jingdong.lu@windriver.com>]

On 06/24/2011 09:55 PM, Bruce Ashfield wrote:
> On 06/24/11 03:02, Jingdong Lu wrote:
>> From: Jingdong Lu<jingdong.lu@windriver.com>
>>
>> Add IPC config for routestationpro
>>
>> Signed-off-by: Jingdong Lu<jingdong.lu@windriver.com>
>> ---
>>   .../bsp/routerstationpro/routerstationpro.cfg      |   10 +++++++---
>>   1 files changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git 
>> a/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg 
>> b/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
>> index f58dfe8..88222ca 100644
>> --- a/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
>> +++ b/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
>> @@ -209,14 +209,18 @@ CONFIG_CONSTRUCTORS=y
>>   #
>>   # General setup
>>   #
>> -# CONFIG_EXPERIMENTAL is not set
>> +CONFIG_EXPERIMENTAL=y
>
> We typically do not want to enable this. What options is
> this triggering that are essential to the IPC config ?
Configuration "POSIX_MQUEUE" depends on  "CONFIG_EXPERIMENTAL=y", so it 
should be enabled.
This configuration has been enabled in 
meta/cfg/kernel-cache/ktypes/base/base.cfg
#
# Code maturity level options
#
CONFIG_EXPERIMENTAL=y

But it was redefined in 
meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
#
# General setup
#
# CONFIG_EXPERIMENTAL is not set

So CONFIG_EXPERIMENTAL is not set in the final kernel config.

I also can find the redefinition in 
.../meta/cfg/yocto/standard/routerstationpro/redefinition.txt

Value of CONFIG_EXPERIMENTAL is redefined by fragment 
/home/eric/poky/poky/build-routerstation/tmp/work/routerstationpro-poky-linux/linux-yocto-2.6.37+git1+06d3793d459048ee1b4db7170f24670c479e8b29_1+d6aadb767fdcbb9886c430e90b92f49cd3a9ddcc-r18/linux/meta/cfg//kernel-cache/bsp/routerstationpro/routerstationpro.cfg:
Old value: CONFIG_EXPERIMENTAL=y
New value: # CONFIG_EXPERIMENTAL is not set
>
>>   CONFIG_BROKEN_ON_SMP=y
>>   CONFIG_INIT_ENV_ARG_LIMIT=32
>>   CONFIG_LOCALVERSION=""
>>   CONFIG_LOCALVERSION_AUTO=y
>>   CONFIG_SWAP=y
>> -# CONFIG_SYSVIPC is not set
>> -# CONFIG_BSD_PROCESS_ACCT is not set
>> +CONFIG_SYSVIPC=y
>> +CONFIG_SYSVIPC_SYSCTL=y
>> +CONFIG_POSIX_MQUEUE=y
>
> These options are already provided by the base configuration
> and are supposed to be baseline options for any BSP. Can
> you elaborate on why you needed these here ?
>
These options also were redefined in 
meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
# CONFIG_SYSVIPC is not set
# CONFIG_BSD_PROCESS_ACCT is not set

So these options were disabled in kernel configure file. But they are 
needed by LTP test.

I took a look at the routerstationpro.cfg and found that it is a 
complete configure file. It is different
from other BSPs. So I think we should modify routerstationpro.cfg and 
only leave some special platform,
hardware configure options in it. Or at least we should omit the above 
options which conflict with
the base configurations.
> Bruce
>
>> +CONFIG_POSIX_MQUEUE_SYSCTL=y
>> +CONFIG_BSD_PROCESS_ACCT=y
>> +CONFIG_BSD_PROCESS_ACCT_V3=y
>>   # CONFIG_TASKSTATS is not set
>>   # CONFIG_AUDIT is not set
>>
>
>

-- 
Lu Jingdong
jingdong.lu@windriver.com
China, Wind River