* [PATCH 1/1] routerstationpro: IPC config
2011-06-24 6:34 [PATCH 0/1] routerstationpro: Enable " Jingdong Lu
@ 2011-06-24 6:34 ` Jingdong Lu
2011-06-24 13:57 ` Bruce Ashfield
0 siblings, 1 reply; 8+ messages in thread
From: Jingdong Lu @ 2011-06-24 6:34 UTC (permalink / raw)
To: yocto
From: Jingdong Lu <jingdong.lu@windriver.com>
Add IPC config for routestationpro
Signed-off-by: Jingdong Lu <jingdong.lu@windriver.com>
---
.../bsp/routerstationpro/routerstationpro.cfg | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg b/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
index f58dfe8..d0f8f58 100644
--- a/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
+++ b/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
@@ -215,8 +215,12 @@ CONFIG_INIT_ENV_ARG_LIMIT=32
CONFIG_LOCALVERSION=""
CONFIG_LOCALVERSION_AUTO=y
CONFIG_SWAP=y
-# CONFIG_SYSVIPC is not set
-# CONFIG_BSD_PROCESS_ACCT is not set
+CONFIG_SYSVIPC=y
+CONFIG_SYSVIPC_SYSCTL=y
+CONFIG_POSIX_MQUEUE=y
+CONFIG_POSIX_MQUEUE_SYSCTL=y
+CONFIG_BSD_PROCESS_ACCT=y
+CONFIG_BSD_PROCESS_ACCT_V3=y
# CONFIG_TASKSTATS is not set
# CONFIG_AUDIT is not set
--
1.7.0.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 0/1] routerstationpro: Enable IPC config
@ 2011-06-24 7:02 Jingdong Lu
2011-06-24 7:02 ` [PATCH 1/1] routerstationpro: " Jingdong Lu
0 siblings, 1 reply; 8+ messages in thread
From: Jingdong Lu @ 2011-06-24 7:02 UTC (permalink / raw)
To: yocto
From: Jingdong Lu <jingdong.lu@windriver.com>
Enable IPC and related configurations for routerstation.
Fixes bug [YOCTO #1161]
Jingdong Lu (1):
routerstationpro: IPC config
.../bsp/routerstationpro/routerstationpro.cfg | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/1] routerstationpro: IPC config
2011-06-24 7:02 [PATCH 0/1] routerstationpro: Enable IPC config Jingdong Lu
@ 2011-06-24 7:02 ` Jingdong Lu
2011-06-24 13:55 ` Bruce Ashfield
0 siblings, 1 reply; 8+ messages in thread
From: Jingdong Lu @ 2011-06-24 7:02 UTC (permalink / raw)
To: yocto
From: Jingdong Lu <jingdong.lu@windriver.com>
Add IPC config for routestationpro
Signed-off-by: Jingdong Lu <jingdong.lu@windriver.com>
---
.../bsp/routerstationpro/routerstationpro.cfg | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg b/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
index f58dfe8..88222ca 100644
--- a/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
+++ b/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
@@ -209,14 +209,18 @@ CONFIG_CONSTRUCTORS=y
#
# General setup
#
-# CONFIG_EXPERIMENTAL is not set
+CONFIG_EXPERIMENTAL=y
CONFIG_BROKEN_ON_SMP=y
CONFIG_INIT_ENV_ARG_LIMIT=32
CONFIG_LOCALVERSION=""
CONFIG_LOCALVERSION_AUTO=y
CONFIG_SWAP=y
-# CONFIG_SYSVIPC is not set
-# CONFIG_BSD_PROCESS_ACCT is not set
+CONFIG_SYSVIPC=y
+CONFIG_SYSVIPC_SYSCTL=y
+CONFIG_POSIX_MQUEUE=y
+CONFIG_POSIX_MQUEUE_SYSCTL=y
+CONFIG_BSD_PROCESS_ACCT=y
+CONFIG_BSD_PROCESS_ACCT_V3=y
# CONFIG_TASKSTATS is not set
# CONFIG_AUDIT is not set
--
1.7.0.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] routerstationpro: IPC config
2011-06-24 7:02 ` [PATCH 1/1] routerstationpro: " Jingdong Lu
@ 2011-06-24 13:55 ` Bruce Ashfield
2011-06-28 9:44 ` Lu Jingdong
0 siblings, 1 reply; 8+ messages in thread
From: Bruce Ashfield @ 2011-06-24 13:55 UTC (permalink / raw)
To: Jingdong Lu; +Cc: yocto
On 06/24/11 03:02, Jingdong Lu wrote:
> From: Jingdong Lu<jingdong.lu@windriver.com>
>
> Add IPC config for routestationpro
>
> Signed-off-by: Jingdong Lu<jingdong.lu@windriver.com>
> ---
> .../bsp/routerstationpro/routerstationpro.cfg | 10 +++++++---
> 1 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg b/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
> index f58dfe8..88222ca 100644
> --- a/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
> +++ b/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
> @@ -209,14 +209,18 @@ CONFIG_CONSTRUCTORS=y
> #
> # General setup
> #
> -# CONFIG_EXPERIMENTAL is not set
> +CONFIG_EXPERIMENTAL=y
We typically do not want to enable this. What options is
this triggering that are essential to the IPC config ?
> CONFIG_BROKEN_ON_SMP=y
> CONFIG_INIT_ENV_ARG_LIMIT=32
> CONFIG_LOCALVERSION=""
> CONFIG_LOCALVERSION_AUTO=y
> CONFIG_SWAP=y
> -# CONFIG_SYSVIPC is not set
> -# CONFIG_BSD_PROCESS_ACCT is not set
> +CONFIG_SYSVIPC=y
> +CONFIG_SYSVIPC_SYSCTL=y
> +CONFIG_POSIX_MQUEUE=y
These options are already provided by the base configuration
and are supposed to be baseline options for any BSP. Can
you elaborate on why you needed these here ?
Bruce
> +CONFIG_POSIX_MQUEUE_SYSCTL=y
> +CONFIG_BSD_PROCESS_ACCT=y
> +CONFIG_BSD_PROCESS_ACCT_V3=y
> # CONFIG_TASKSTATS is not set
> # CONFIG_AUDIT is not set
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] routerstationpro: IPC config
2011-06-24 6:34 ` [PATCH 1/1] routerstationpro: " Jingdong Lu
@ 2011-06-24 13:57 ` Bruce Ashfield
2011-06-27 21:48 ` Darren Hart
0 siblings, 1 reply; 8+ messages in thread
From: Bruce Ashfield @ 2011-06-24 13:57 UTC (permalink / raw)
To: Jingdong Lu; +Cc: yocto
On 06/24/11 02:34, Jingdong Lu wrote:
> From: Jingdong Lu<jingdong.lu@windriver.com>
>
> Add IPC config for routestationpro
I replied to what looked to be v2 of this change,
so am dropping this patch. If they were indeed
different, you'll need to point me at what I missed.
Also: I got direct email for all these, and a copy
separate to the list. If you are having trouble
with git send-email, feel free to send your workflow
and we can likely help!
Cheers,
Bruce
>
> Signed-off-by: Jingdong Lu<jingdong.lu@windriver.com>
> ---
> .../bsp/routerstationpro/routerstationpro.cfg | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg b/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
> index f58dfe8..d0f8f58 100644
> --- a/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
> +++ b/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
> @@ -215,8 +215,12 @@ CONFIG_INIT_ENV_ARG_LIMIT=32
> CONFIG_LOCALVERSION=""
> CONFIG_LOCALVERSION_AUTO=y
> CONFIG_SWAP=y
> -# CONFIG_SYSVIPC is not set
> -# CONFIG_BSD_PROCESS_ACCT is not set
> +CONFIG_SYSVIPC=y
> +CONFIG_SYSVIPC_SYSCTL=y
> +CONFIG_POSIX_MQUEUE=y
> +CONFIG_POSIX_MQUEUE_SYSCTL=y
> +CONFIG_BSD_PROCESS_ACCT=y
> +CONFIG_BSD_PROCESS_ACCT_V3=y
> # CONFIG_TASKSTATS is not set
> # CONFIG_AUDIT is not set
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] routerstationpro: IPC config
2011-06-24 13:57 ` Bruce Ashfield
@ 2011-06-27 21:48 ` Darren Hart
0 siblings, 0 replies; 8+ messages in thread
From: Darren Hart @ 2011-06-27 21:48 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: yocto
On 06/24/2011 06:57 AM, Bruce Ashfield wrote:
> On 06/24/11 02:34, Jingdong Lu wrote:
>> From: Jingdong Lu<jingdong.lu@windriver.com>
>>
>> Add IPC config for routestationpro
>
> I replied to what looked to be v2 of this change,
> so am dropping this patch. If they were indeed
> different, you'll need to point me at what I missed.
>
> Also: I got direct email for all these, and a copy
> separate to the list. If you are having trouble
> with git send-email, feel free to send your workflow
> and we can likely help!
scripts/send-pull-request will also work with the linux-yocto git
repository. Same workflow that way.
>
> Cheers,
>
> Bruce
>
>>
>> Signed-off-by: Jingdong Lu<jingdong.lu@windriver.com>
>> ---
>> .../bsp/routerstationpro/routerstationpro.cfg | 8 ++++++--
>> 1 files changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg b/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
>> index f58dfe8..d0f8f58 100644
>> --- a/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
>> +++ b/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
>> @@ -215,8 +215,12 @@ CONFIG_INIT_ENV_ARG_LIMIT=32
>> CONFIG_LOCALVERSION=""
>> CONFIG_LOCALVERSION_AUTO=y
>> CONFIG_SWAP=y
>> -# CONFIG_SYSVIPC is not set
>> -# CONFIG_BSD_PROCESS_ACCT is not set
>> +CONFIG_SYSVIPC=y
>> +CONFIG_SYSVIPC_SYSCTL=y
>> +CONFIG_POSIX_MQUEUE=y
>> +CONFIG_POSIX_MQUEUE_SYSCTL=y
>> +CONFIG_BSD_PROCESS_ACCT=y
>> +CONFIG_BSD_PROCESS_ACCT_V3=y
>> # CONFIG_TASKSTATS is not set
>> # CONFIG_AUDIT is not set
>>
>
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] routerstationpro: IPC config
2011-06-24 13:55 ` Bruce Ashfield
@ 2011-06-28 9:44 ` Lu Jingdong
2011-06-28 13:07 ` Bruce Ashfield
0 siblings, 1 reply; 8+ messages in thread
From: Lu Jingdong @ 2011-06-28 9:44 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: yocto
On 06/24/2011 09:55 PM, Bruce Ashfield wrote:
> On 06/24/11 03:02, Jingdong Lu wrote:
>> From: Jingdong Lu<jingdong.lu@windriver.com>
>>
>> Add IPC config for routestationpro
>>
>> Signed-off-by: Jingdong Lu<jingdong.lu@windriver.com>
>> ---
>> .../bsp/routerstationpro/routerstationpro.cfg | 10 +++++++---
>> 1 files changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git
>> a/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
>> b/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
>> index f58dfe8..88222ca 100644
>> --- a/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
>> +++ b/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
>> @@ -209,14 +209,18 @@ CONFIG_CONSTRUCTORS=y
>> #
>> # General setup
>> #
>> -# CONFIG_EXPERIMENTAL is not set
>> +CONFIG_EXPERIMENTAL=y
>
> We typically do not want to enable this. What options is
> this triggering that are essential to the IPC config ?
Configuration "POSIX_MQUEUE" depends on "CONFIG_EXPERIMENTAL=y", so it
should be enabled.
This configuration has been enabled in
meta/cfg/kernel-cache/ktypes/base/base.cfg
#
# Code maturity level options
#
CONFIG_EXPERIMENTAL=y
But it was redefined in
meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
#
# General setup
#
# CONFIG_EXPERIMENTAL is not set
So CONFIG_EXPERIMENTAL is not set in the final kernel config.
I also can find the redefinition in
.../meta/cfg/yocto/standard/routerstationpro/redefinition.txt
Value of CONFIG_EXPERIMENTAL is redefined by fragment
/home/eric/poky/poky/build-routerstation/tmp/work/routerstationpro-poky-linux/linux-yocto-2.6.37+git1+06d3793d459048ee1b4db7170f24670c479e8b29_1+d6aadb767fdcbb9886c430e90b92f49cd3a9ddcc-r18/linux/meta/cfg//kernel-cache/bsp/routerstationpro/routerstationpro.cfg:
Old value: CONFIG_EXPERIMENTAL=y
New value: # CONFIG_EXPERIMENTAL is not set
>
>> CONFIG_BROKEN_ON_SMP=y
>> CONFIG_INIT_ENV_ARG_LIMIT=32
>> CONFIG_LOCALVERSION=""
>> CONFIG_LOCALVERSION_AUTO=y
>> CONFIG_SWAP=y
>> -# CONFIG_SYSVIPC is not set
>> -# CONFIG_BSD_PROCESS_ACCT is not set
>> +CONFIG_SYSVIPC=y
>> +CONFIG_SYSVIPC_SYSCTL=y
>> +CONFIG_POSIX_MQUEUE=y
>
> These options are already provided by the base configuration
> and are supposed to be baseline options for any BSP. Can
> you elaborate on why you needed these here ?
>
These options also were redefined in
meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
# CONFIG_SYSVIPC is not set
# CONFIG_BSD_PROCESS_ACCT is not set
So these options were disabled in kernel configure file. But they are
needed by LTP test.
I took a look at the routerstationpro.cfg and found that it is a
complete configure file. It is different
from other BSPs. So I think we should modify routerstationpro.cfg and
only leave some special platform,
hardware configure options in it. Or at least we should omit the above
options which conflict with
the base configurations.
> Bruce
>
>> +CONFIG_POSIX_MQUEUE_SYSCTL=y
>> +CONFIG_BSD_PROCESS_ACCT=y
>> +CONFIG_BSD_PROCESS_ACCT_V3=y
>> # CONFIG_TASKSTATS is not set
>> # CONFIG_AUDIT is not set
>>
>
>
--
Lu Jingdong
jingdong.lu@windriver.com
China, Wind River
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] routerstationpro: IPC config
2011-06-28 9:44 ` Lu Jingdong
@ 2011-06-28 13:07 ` Bruce Ashfield
0 siblings, 0 replies; 8+ messages in thread
From: Bruce Ashfield @ 2011-06-28 13:07 UTC (permalink / raw)
To: Lu Jingdong; +Cc: yocto
On 06/28/11 05:44, Lu Jingdong wrote:
>
>
> On 06/24/2011 09:55 PM, Bruce Ashfield wrote:
>> On 06/24/11 03:02, Jingdong Lu wrote:
>>> From: Jingdong Lu<jingdong.lu@windriver.com>
>>>
>>> Add IPC config for routestationpro
>>>
>>> Signed-off-by: Jingdong Lu<jingdong.lu@windriver.com>
>>> ---
>>> .../bsp/routerstationpro/routerstationpro.cfg | 10 +++++++---
>>> 1 files changed, 7 insertions(+), 3 deletions(-)
>>>
>>> diff --git
>>> a/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
>>> b/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
>>> index f58dfe8..88222ca 100644
>>> --- a/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
>>> +++ b/meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
>>> @@ -209,14 +209,18 @@ CONFIG_CONSTRUCTORS=y
>>> #
>>> # General setup
>>> #
>>> -# CONFIG_EXPERIMENTAL is not set
>>> +CONFIG_EXPERIMENTAL=y
>>
>> We typically do not want to enable this. What options is
>> this triggering that are essential to the IPC config ?
> Configuration "POSIX_MQUEUE" depends on "CONFIG_EXPERIMENTAL=y", so it
> should be enabled.
> This configuration has been enabled in
> meta/cfg/kernel-cache/ktypes/base/base.cfg
> #
> # Code maturity level options
> #
> CONFIG_EXPERIMENTAL=y
>
> But it was redefined in
> meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
> #
> # General setup
> #
> # CONFIG_EXPERIMENTAL is not set
>
> So CONFIG_EXPERIMENTAL is not set in the final kernel config.
>
> I also can find the redefinition in
> .../meta/cfg/yocto/standard/routerstationpro/redefinition.txt
>
> Value of CONFIG_EXPERIMENTAL is redefined by fragment
> /home/eric/poky/poky/build-routerstation/tmp/work/routerstationpro-poky-linux/linux-yocto-2.6.37+git1+06d3793d459048ee1b4db7170f24670c479e8b29_1+d6aadb767fdcbb9886c430e90b92f49cd3a9ddcc-r18/linux/meta/cfg//kernel-cache/bsp/routerstationpro/routerstationpro.cfg:
>
> Old value: CONFIG_EXPERIMENTAL=y
> New value: # CONFIG_EXPERIMENTAL is not set
Indeed. So in this case, we should just be dropping the
# CONFIG_EXPERIMENTAL is not set from this fragment.
>>
>>> CONFIG_BROKEN_ON_SMP=y
>>> CONFIG_INIT_ENV_ARG_LIMIT=32
>>> CONFIG_LOCALVERSION=""
>>> CONFIG_LOCALVERSION_AUTO=y
>>> CONFIG_SWAP=y
>>> -# CONFIG_SYSVIPC is not set
>>> -# CONFIG_BSD_PROCESS_ACCT is not set
>>> +CONFIG_SYSVIPC=y
>>> +CONFIG_SYSVIPC_SYSCTL=y
>>> +CONFIG_POSIX_MQUEUE=y
>>
>> These options are already provided by the base configuration
>> and are supposed to be baseline options for any BSP. Can
>> you elaborate on why you needed these here ?
>>
> These options also were redefined in
> meta/cfg/kernel-cache/bsp/routerstationpro/routerstationpro.cfg
> # CONFIG_SYSVIPC is not set
> # CONFIG_BSD_PROCESS_ACCT is not set
>
> So these options were disabled in kernel configure file. But they are
> needed by LTP test.
>
> I took a look at the routerstationpro.cfg and found that it is a
> complete configure file. It is different
> from other BSPs. So I think we should modify routerstationpro.cfg and
> only leave some special platform,
This definitely needs to be done, it was on our list to revisit, so
perhaps this is a good time.
> hardware configure options in it. Or at least we should omit the above
> options which conflict with
> the base configurations.
At the minimum we should do this, BSPs should not be overriding
base settings without good reasons .. and we definitely do not
have good reasons here!
Bruce
>> Bruce
>>
>>> +CONFIG_POSIX_MQUEUE_SYSCTL=y
>>> +CONFIG_BSD_PROCESS_ACCT=y
>>> +CONFIG_BSD_PROCESS_ACCT_V3=y
>>> # CONFIG_TASKSTATS is not set
>>> # CONFIG_AUDIT is not set
>>>
>>
>>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-06-28 13:07 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-24 7:02 [PATCH 0/1] routerstationpro: Enable IPC config Jingdong Lu
2011-06-24 7:02 ` [PATCH 1/1] routerstationpro: " Jingdong Lu
2011-06-24 13:55 ` Bruce Ashfield
2011-06-28 9:44 ` Lu Jingdong
2011-06-28 13:07 ` Bruce Ashfield
-- strict thread matches above, loose matches on Subject: below --
2011-06-24 6:34 [PATCH 0/1] routerstationpro: Enable " Jingdong Lu
2011-06-24 6:34 ` [PATCH 1/1] routerstationpro: " Jingdong Lu
2011-06-24 13:57 ` Bruce Ashfield
2011-06-27 21:48 ` Darren Hart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.