All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: Mel Gorman <mgorman@suse.de>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	"Pádraig Brady" <P@draigBrady.com>,
	"James Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Colin King" <colin.king@canonical.com>,
	"Minchan Kim" <minchan.kim@gmail.com>,
	"Andrew Lutomirski" <luto@mit.edu>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	linux-mm <linux-mm@kvack.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] mm: vmscan: Evaluate the watermarks against the correct classzone
Date: Sat, 25 Jun 2011 17:42:08 -0400	[thread overview]
Message-ID: <4E065630.2070407@redhat.com> (raw)
In-Reply-To: <1308926697-22475-4-git-send-email-mgorman@suse.de>

On 06/24/2011 10:44 AM, Mel Gorman wrote:
> When deciding if kswapd is sleeping prematurely, the classzone is
> taken into account but this is different to what balance_pgdat() and
> the allocator are doing. Specifically, the DMA zone will be checked
> based on the classzone used when waking kswapd which could be for a
> GFP_KERNEL or GFP_HIGHMEM request. The lowmem reserve limit kicks in,
> the watermark is not met and kswapd thinks its sleeping prematurely
> keeping kswapd awake in error.
>
> Reported-and-tested-by: Pádraig Brady<P@draigBrady.com>
> Signed-off-by: Mel Gorman<mgorman@suse.de>

Acked-by: Rik van Riel <riel@redhat.com>

-- 
All rights reversed

WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Mel Gorman <mgorman@suse.de>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	"Pádraig Brady" <P@draigBrady.com>,
	"James Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Colin King" <colin.king@canonical.com>,
	"Minchan Kim" <minchan.kim@gmail.com>,
	"Andrew Lutomirski" <luto@mit.edu>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	linux-mm <linux-mm@kvack.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] mm: vmscan: Evaluate the watermarks against the correct classzone
Date: Sat, 25 Jun 2011 17:42:08 -0400	[thread overview]
Message-ID: <4E065630.2070407@redhat.com> (raw)
In-Reply-To: <1308926697-22475-4-git-send-email-mgorman@suse.de>

On 06/24/2011 10:44 AM, Mel Gorman wrote:
> When deciding if kswapd is sleeping prematurely, the classzone is
> taken into account but this is different to what balance_pgdat() and
> the allocator are doing. Specifically, the DMA zone will be checked
> based on the classzone used when waking kswapd which could be for a
> GFP_KERNEL or GFP_HIGHMEM request. The lowmem reserve limit kicks in,
> the watermark is not met and kswapd thinks its sleeping prematurely
> keeping kswapd awake in error.
>
> Reported-and-tested-by: PA!draig Brady<P@draigBrady.com>
> Signed-off-by: Mel Gorman<mgorman@suse.de>

Acked-by: Rik van Riel <riel@redhat.com>

-- 
All rights reversed

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-06-25 21:42 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-24 14:44 [PATCH 0/4] Stop kswapd consuming 100% CPU when highest zone is small Mel Gorman
2011-06-24 14:44 ` Mel Gorman
2011-06-24 14:44 ` [PATCH 1/4] mm: vmscan: Correct check for kswapd sleeping in sleeping_prematurely Mel Gorman
2011-06-24 14:44   ` Mel Gorman
2011-06-25 21:33   ` Rik van Riel
2011-06-25 21:33     ` Rik van Riel
2011-06-27  6:10   ` Minchan Kim
2011-06-27  6:10     ` Minchan Kim
2011-06-28 21:49   ` Andrew Morton
2011-06-28 21:49     ` Andrew Morton
2011-06-29 10:57     ` Pádraig Brady
2011-06-29 10:57       ` Pádraig Brady
2011-06-30  9:39     ` Mel Gorman
2011-06-30  9:39       ` Mel Gorman
2011-06-30  2:23   ` KOSAKI Motohiro
2011-06-30  2:23     ` KOSAKI Motohiro
2011-06-24 14:44 ` [PATCH 2/4] mm: vmscan: Do not apply pressure to slab if we are not applying pressure to zone Mel Gorman
2011-06-24 14:44   ` Mel Gorman
2011-06-25 21:40   ` Rik van Riel
2011-06-25 21:40     ` Rik van Riel
2011-06-28 23:38   ` Minchan Kim
2011-06-28 23:38     ` Minchan Kim
2011-06-30  2:37   ` KOSAKI Motohiro
2011-06-30  2:37     ` KOSAKI Motohiro
2011-06-24 14:44 ` [PATCH 3/4] mm: vmscan: Evaluate the watermarks against the correct classzone Mel Gorman
2011-06-24 14:44   ` Mel Gorman
2011-06-25 21:42   ` Rik van Riel [this message]
2011-06-25 21:42     ` Rik van Riel
2011-06-27  6:53   ` Minchan Kim
2011-06-27  6:53     ` Minchan Kim
2011-06-28 12:52     ` Mel Gorman
2011-06-28 12:52       ` Mel Gorman
2011-06-28 23:23       ` Minchan Kim
2011-06-28 23:23         ` Minchan Kim
2011-06-28 23:23   ` Minchan Kim
2011-06-28 23:23     ` Minchan Kim
2011-06-24 14:44 ` [PATCH 4/4] mm: vmscan: Only read new_classzone_idx from pgdat when reclaiming successfully Mel Gorman
2011-06-24 14:44   ` Mel Gorman
2011-06-25 23:17   ` Rik van Riel
2011-06-25 23:17     ` Rik van Riel
2011-06-30  9:05   ` KOSAKI Motohiro
2011-06-30  9:05     ` KOSAKI Motohiro
2011-06-30 10:19     ` Mel Gorman
2011-06-30 10:19       ` Mel Gorman
2011-07-19 16:09   ` Minchan Kim
2011-07-19 16:09     ` Minchan Kim
2011-07-20 10:48     ` Mel Gorman
2011-07-20 10:48       ` Mel Gorman
2011-07-21 15:30       ` Minchan Kim
2011-07-21 15:30         ` Minchan Kim
2011-07-21 16:07         ` Mel Gorman
2011-07-21 16:07           ` Mel Gorman
2011-07-21 16:36           ` Minchan Kim
2011-07-21 16:36             ` Minchan Kim
2011-07-21 17:01             ` Mel Gorman
2011-07-21 17:01               ` Mel Gorman
2011-07-22  0:21               ` Minchan Kim
2011-07-22  0:21                 ` Minchan Kim
2011-07-22  7:42                 ` Mel Gorman
2011-07-22  7:42                   ` Mel Gorman
2011-06-25 14:23 ` [PATCH 0/4] Stop kswapd consuming 100% CPU when highest zone is small Andrew Lutomirski
2011-06-25 14:23   ` Andrew Lutomirski
2011-07-21 15:37 ` Minchan Kim
2011-07-21 15:37   ` Minchan Kim
2011-07-21 16:09   ` Mel Gorman
2011-07-21 16:09     ` Mel Gorman
2011-07-21 16:24     ` Minchan Kim
2011-07-21 16:24       ` Minchan Kim
2011-07-21 16:36       ` Andrew Lutomirski
2011-07-21 16:36         ` Andrew Lutomirski
2011-07-21 16:42         ` Minchan Kim
2011-07-21 16:42           ` Minchan Kim
2011-07-21 16:58           ` Andrew Lutomirski
2011-07-21 16:58             ` Andrew Lutomirski
2011-07-22  0:30             ` Minchan Kim
2011-07-22  0:30               ` Minchan Kim
2011-07-22 13:21               ` Andrew Lutomirski
2011-07-22 13:21                 ` Andrew Lutomirski
  -- strict thread matches above, loose matches on Subject: below --
2011-06-24 13:43 Mel Gorman
2011-06-24 13:43 ` [PATCH 3/4] mm: vmscan: Evaluate the watermarks against the correct classzone Mel Gorman
2011-06-24 13:43   ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E065630.2070407@redhat.com \
    --to=riel@redhat.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=P@draigBrady.com \
    --cc=akpm@linux-foundation.org \
    --cc=colin.king@canonical.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@mit.edu \
    --cc=mgorman@suse.de \
    --cc=minchan.kim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.