From: Rik van Riel <riel@redhat.com>
To: Andrea Righi <andrea@betterlinux.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Minchan Kim" <minchan.kim@gmail.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>,
"Andrea Arcangeli" <aarcange@redhat.com>,
"Hugh Dickins" <hughd@google.com>,
"Jerry James" <jamesjer@betterlinux.com>,
"Marcus Sorensen" <marcus@bluehost.com>,
"Matt Heaton" <matt@bluehost.com>,
"KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com>,
"Theodore Tso" <tytso@mit.edu>,
"Shaohua Li" <shaohua.li@intel.com>,
"Pádraig Brady" <P@draigBrady.com>, linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] mm: introduce __invalidate_mapping_pages()
Date: Sun, 26 Jun 2011 18:46:46 -0400 [thread overview]
Message-ID: <4E07B6D6.8070203@redhat.com> (raw)
In-Reply-To: <1308923350-7932-2-git-send-email-andrea@betterlinux.com>
On 06/24/2011 09:49 AM, Andrea Righi wrote:
> diff --git a/mm/truncate.c b/mm/truncate.c
> index 3a29a61..90f3a97 100644
> --- a/mm/truncate.c
> +++ b/mm/truncate.c
> @@ -312,20 +312,27 @@ void truncate_inode_pages(struct address_space *mapping, loff_t lstart)
> EXPORT_SYMBOL(truncate_inode_pages);
>
> /**
> - * invalidate_mapping_pages - Invalidate all the unlocked pages of one inode
> + * __invalidate_mapping_pages - Invalidate all the unlocked pages of one inode
> * @mapping: the address_space which holds the pages to invalidate
> * @start: the offset 'from' which to invalidate
> * @end: the offset 'to' which to invalidate (inclusive)
> + * @force: always drop pages when true (otherwise, reduce cache eligibility)
I don't like the parameter name "force".
The parameter determines whether or not pages actually get
invalidated, so I'm guessing the parameter name should
reflect the function...
Maybe something like "invalidate"?
--
All rights reversed
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Andrea Righi <andrea@betterlinux.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Minchan Kim" <minchan.kim@gmail.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>,
"Andrea Arcangeli" <aarcange@redhat.com>,
"Hugh Dickins" <hughd@google.com>,
"Jerry James" <jamesjer@betterlinux.com>,
"Marcus Sorensen" <marcus@bluehost.com>,
"Matt Heaton" <matt@bluehost.com>,
"KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com>,
"Theodore Tso" <tytso@mit.edu>,
"Shaohua Li" <shaohua.li@intel.com>,
"Pádraig Brady" <P@draigBrady.com>, linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] mm: introduce __invalidate_mapping_pages()
Date: Sun, 26 Jun 2011 18:46:46 -0400 [thread overview]
Message-ID: <4E07B6D6.8070203@redhat.com> (raw)
In-Reply-To: <1308923350-7932-2-git-send-email-andrea@betterlinux.com>
On 06/24/2011 09:49 AM, Andrea Righi wrote:
> diff --git a/mm/truncate.c b/mm/truncate.c
> index 3a29a61..90f3a97 100644
> --- a/mm/truncate.c
> +++ b/mm/truncate.c
> @@ -312,20 +312,27 @@ void truncate_inode_pages(struct address_space *mapping, loff_t lstart)
> EXPORT_SYMBOL(truncate_inode_pages);
>
> /**
> - * invalidate_mapping_pages - Invalidate all the unlocked pages of one inode
> + * __invalidate_mapping_pages - Invalidate all the unlocked pages of one inode
> * @mapping: the address_space which holds the pages to invalidate
> * @start: the offset 'from' which to invalidate
> * @end: the offset 'to' which to invalidate (inclusive)
> + * @force: always drop pages when true (otherwise, reduce cache eligibility)
I don't like the parameter name "force".
The parameter determines whether or not pages actually get
invalidated, so I'm guessing the parameter name should
reflect the function...
Maybe something like "invalidate"?
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-06-26 22:49 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 13:49 [PATCH v3 0/2] fadvise: support POSIX_FADV_NOREUSE Andrea Righi
2011-06-24 13:49 ` Andrea Righi
2011-06-24 13:49 ` [PATCH v3 1/2] mm: introduce __invalidate_mapping_pages() Andrea Righi
2011-06-24 13:49 ` Andrea Righi
2011-06-26 22:46 ` Rik van Riel [this message]
2011-06-26 22:46 ` Rik van Riel
2011-06-27 7:05 ` Andrea Righi
2011-06-27 7:05 ` Andrea Righi
2011-06-24 13:49 ` [PATCH v3 2/2] fadvise: implement POSIX_FADV_NOREUSE Andrea Righi
2011-06-24 13:49 ` Andrea Righi
2011-06-26 22:47 ` Rik van Riel
2011-06-26 22:47 ` Rik van Riel
2011-06-27 7:05 ` Andrea Righi
2011-06-27 7:05 ` Andrea Righi
2011-06-27 3:04 ` [PATCH v3 0/2] fadvise: support POSIX_FADV_NOREUSE KOSAKI Motohiro
2011-06-27 3:04 ` KOSAKI Motohiro
2011-06-27 7:11 ` Andrea Righi
2011-06-27 7:11 ` Andrea Righi
2011-06-27 7:42 ` KOSAKI Motohiro
2011-06-27 7:42 ` KOSAKI Motohiro
2011-06-27 10:17 ` Pádraig Brady
2011-06-27 10:17 ` Pádraig Brady
2011-06-27 10:29 ` Andrea Righi
2011-06-27 10:29 ` Andrea Righi
2011-06-27 11:53 ` Pádraig Brady
2011-06-27 11:53 ` Pádraig Brady
2011-06-27 12:39 ` Andrea Righi
2011-06-27 12:39 ` Andrea Righi
2011-07-12 21:52 ` Patrick J. LoPresti
2011-07-12 22:22 ` Andrea Righi
2011-07-13 0:36 ` Patrick J. LoPresti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E07B6D6.8070203@redhat.com \
--to=riel@redhat.com \
--cc=P@draigBrady.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andrea@betterlinux.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=jamesjer@betterlinux.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marcus@bluehost.com \
--cc=matt@bluehost.com \
--cc=minchan.kim@gmail.com \
--cc=peterz@infradead.org \
--cc=shaohua.li@intel.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.