All of lore.kernel.org
 help / color / mirror / Atom feed
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: P@draigBrady.com
Cc: andrea@betterlinux.com, akpm@linux-foundation.org,
	minchan.kim@gmail.com, riel@redhat.com, peterz@infradead.org,
	hannes@cmpxchg.org, kamezawa.hiroyu@jp.fujitsu.com,
	aarcange@redhat.com, hughd@google.com, jamesjer@betterlinux.com,
	marcus@bluehost.com, matt@bluehost.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] fadvise: move active pages to inactive list with POSIX_FADV_DONTNEED
Date: Mon, 27 Jun 2011 18:44:51 +0900	[thread overview]
Message-ID: <4E085113.7060200@jp.fujitsu.com> (raw)
In-Reply-To: <4E084AA7.2030701@draigBrady.com>

(2011/06/27 18:17), Pádraig Brady wrote:
> On 27/06/11 06:38, KOSAKI Motohiro wrote:
>>> Hmm, What if you do want to evict it from the cache for testing purposes?
>>> Perhaps this functionality should be associated with POSIX_FADV_NOREUSE?
>>> dd has been recently modified to support invalidating the cache for a file,
>>> and it uses POSIX_FADV_DONTNEED for that.
>>> http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=5f311553
>>
>> This change don't break dd. dd don't have a special privilege of file cache
>> dropping if it's also used by other processes.
>>
>> if you want to drop a cache forcely (maybe for testing), you need to use
>> /proc/sys/vm/drop_caches. It's ok to ignore other processes activity because
>> it's privilege operation.
> 
> Well the function and privileges are separate things.
> I think we've agreed that the new functionality is
> best associated with POSIX_FADV_NOREUSE,
> and the existing functionality with POSIX_FADV_DONTNEED.
> 
> BTW, I don't think privileges are currently enforced
> as I got root to cache a file here with:
>   # (time md5sum; sleep 100) < big.file
> And a normal user was able to uncache with:
>   $ dd iflag=nocache if=big.file count=0
> Anyway as said, this is a separate "issue".

I'm failed to see your point. Why does dd need to ignore other
process activity? If no other process, this patch doesn't change
any behavior. Isn't it?



WARNING: multiple messages have this Message-ID (diff)
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: P@draigBrady.com
Cc: andrea@betterlinux.com, akpm@linux-foundation.org,
	minchan.kim@gmail.com, riel@redhat.com, peterz@infradead.org,
	hannes@cmpxchg.org, kamezawa.hiroyu@jp.fujitsu.com,
	aarcange@redhat.com, hughd@google.com, jamesjer@betterlinux.com,
	marcus@bluehost.com, matt@bluehost.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] fadvise: move active pages to inactive list with POSIX_FADV_DONTNEED
Date: Mon, 27 Jun 2011 18:44:51 +0900	[thread overview]
Message-ID: <4E085113.7060200@jp.fujitsu.com> (raw)
In-Reply-To: <4E084AA7.2030701@draigBrady.com>

(2011/06/27 18:17), Padraig Brady wrote:
> On 27/06/11 06:38, KOSAKI Motohiro wrote:
>>> Hmm, What if you do want to evict it from the cache for testing purposes?
>>> Perhaps this functionality should be associated with POSIX_FADV_NOREUSE?
>>> dd has been recently modified to support invalidating the cache for a file,
>>> and it uses POSIX_FADV_DONTNEED for that.
>>> http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=5f311553
>>
>> This change don't break dd. dd don't have a special privilege of file cache
>> dropping if it's also used by other processes.
>>
>> if you want to drop a cache forcely (maybe for testing), you need to use
>> /proc/sys/vm/drop_caches. It's ok to ignore other processes activity because
>> it's privilege operation.
> 
> Well the function and privileges are separate things.
> I think we've agreed that the new functionality is
> best associated with POSIX_FADV_NOREUSE,
> and the existing functionality with POSIX_FADV_DONTNEED.
> 
> BTW, I don't think privileges are currently enforced
> as I got root to cache a file here with:
>   # (time md5sum; sleep 100) < big.file
> And a normal user was able to uncache with:
>   $ dd iflag=nocache if=big.file count=0
> Anyway as said, this is a separate "issue".

I'm failed to see your point. Why does dd need to ignore other
process activity? If no other process, this patch doesn't change
any behavior. Isn't it?


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-06-27  9:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-22 21:51 [PATCH RFC] fadvise: move active pages to inactive list with POSIX_FADV_DONTNEED Andrea Righi
2011-06-22 21:51 ` Andrea Righi
2011-06-22 23:04 ` Rik van Riel
2011-06-22 23:04   ` Rik van Riel
2011-06-23  3:15 ` KOSAKI Motohiro
2011-06-23  3:15   ` KOSAKI Motohiro
2011-06-23  6:18   ` Andrea Righi
2011-06-23  6:18     ` Andrea Righi
2011-06-23 11:14 ` Pádraig Brady
2011-06-23 11:14   ` Pádraig Brady
2011-06-23 13:57   ` Andrea Righi
2011-06-23 13:57     ` Andrea Righi
2011-06-23 14:14     ` Pádraig Brady
2011-06-23 14:14       ` Pádraig Brady
2011-06-23 15:32       ` Andrea Righi
2011-06-23 15:32         ` Andrea Righi
2011-06-27  5:38   ` KOSAKI Motohiro
2011-06-27  5:38     ` KOSAKI Motohiro
2011-06-27  9:17     ` Pádraig Brady
2011-06-27  9:17       ` Pádraig Brady
2011-06-27  9:44       ` KOSAKI Motohiro [this message]
2011-06-27  9:44         ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E085113.7060200@jp.fujitsu.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    --cc=P@draigBrady.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrea@betterlinux.com \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=jamesjer@betterlinux.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=marcus@bluehost.com \
    --cc=matt@bluehost.com \
    --cc=minchan.kim@gmail.com \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.