Patch for Xen 4.1.1 not working with LVM volumes and pygrub on NetBSD

Patch for Xen 4.1.1 not working with LVM volumes and pygrub on NetBSD

[Roger Pau Monné]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

Hello,

Xen 4.1.1 was incorrectly passing /dev/rmapper/vg-lvname to pygrub
(notice the r in front of mapper), when it should pass
/dev/mapper/rvg-lvname (add the r to the last file) when using NetBSD.
I've patched it to work correctly. I'm attaching a unified diff with
the patch made against Xen 4.1.1 (it's a really simple modification).

Regards, Roger.

[-- Attachment #2: patch-lvm --]
[-- Type: application/octet-stream, Size: 429 bytes --]

--- tools/python/xen/xend/XendBootloader.py.orig	2011-06-14 18:03:44.000000000 +0200
+++ tools/python/xen/xend/XendBootloader.py	2011-06-26 18:06:24.000000000 +0200
@@ -44,7 +44,7 @@
         raise VmError(msg)
 
     if os.uname()[0] == "NetBSD" and disk.startswith('/dev/'):
-       disk = disk.replace("/dev/", "/dev/r")
+       disk = "/r".join(disk.rsplit("/",1))
 
     mkdir.parents("/var/run/xend/boot/", stat.S_IRWXU)
 

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Patch for Xen 4.1.1 not working with LVM volumes and pygrub on NetBSD

[Roger Pau Monné]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

Hello,

Xen 4.1.1 was incorrectly passing /dev/rmapper/vg-lvname to pygrub
(notice the r in front of mapper), when it should pass
/dev/mapper/rvg-lvname (add the r to the last file) when using NetBSD.
I've patched it to work correctly. I'm attaching a unified diff with
the patch made against Xen 4.1.1 (it's a really simple modification).

Regards, Roger.

[-- Attachment #2: patch-lvm --]
[-- Type: application/octet-stream, Size: 429 bytes --]

--- tools/python/xen/xend/XendBootloader.py.orig	2011-06-14 18:03:44.000000000 +0200
+++ tools/python/xen/xend/XendBootloader.py	2011-06-26 18:06:24.000000000 +0200
@@ -44,7 +44,7 @@
         raise VmError(msg)
 
     if os.uname()[0] == "NetBSD" and disk.startswith('/dev/'):
-       disk = disk.replace("/dev/", "/dev/r")
+       disk = "/r".join(disk.rsplit("/",1))
 
     mkdir.parents("/var/run/xend/boot/", stat.S_IRWXU)
 

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: Patch for Xen 4.1.1 not working with LVM volumes and pygrub on NetBSD

[Ian Jackson]

Roger Pau Monné writes ("[Xen-devel] Patch for Xen 4.1.1 not working with LVM volumes and pygrub on NetBSD"):
> Xen 4.1.1 was incorrectly passing /dev/rmapper/vg-lvname to pygrub
> (notice the r in front of mapper), when it should pass
> /dev/mapper/rvg-lvname (add the r to the last file) when using NetBSD.
> I've patched it to work correctly. I'm attaching a unified diff with
> the patch made against Xen 4.1.1 (it's a really simple modification).

Thanks, I have applied your patch.

Next time, though, can you please be sure to add a Signed-off-by line,
to signify your certification in accordance with the Developer's
Certificate of Origin ?  In this case I'll go ahead as it's only a
single line.

Thanks,
Ian.

>From Documentation/SubmittingPatches in the Linux kernel tree:
 
        Developer's Certificate of Origin 1.1
 
        By making a contribution to this project, I certify that:
 
        (a) The contribution was created in whole or in part by me and I
            have the right to submit it under the open source license
            indicated in the file; or
 
        (b) The contribution is based upon previous work that, to the best
            of my knowledge, is covered under an appropriate open source
            license and I have the right under that license to submit that
            work with modifications, whether created in whole or in part
            by me, under the same open source license (unless I am
            permitted to submit under a different license), as indicated
            in the file; or
 
        (c) The contribution was provided directly to me by some other
            person who certified (a), (b) or (c) and I have not modified
            it.
 
        (d) I understand and agree that this project and the contribution
            are public and that a record of the contribution (including all
            personal information I submit with it, including my sign-off) is
            maintained indefinitely and may be redistributed consistent with
            this project or the open source license(s) involved.

Re: Patch for Xen 4.1.1 not working with LVM volumes and pygrub on NetBSD

[Christoph Egger]

On 06/28/11 14:57, Ian Jackson wrote:
> Roger Pau Monné writes ("[Xen-devel] Patch for Xen 4.1.1 not working with LVM volumes and pygrub on NetBSD"):
>> Xen 4.1.1 was incorrectly passing /dev/rmapper/vg-lvname to pygrub
>> (notice the r in front of mapper), when it should pass
>> /dev/mapper/rvg-lvname (add the r to the last file) when using NetBSD.
>> I've patched it to work correctly. I'm attaching a unified diff with
>> the patch made against Xen 4.1.1 (it's a really simple modification).
>
> Thanks, I have applied your patch.
>
> Next time, though, can you please be sure to add a Signed-off-by line,
> to signify your certification in accordance with the Developer's
> Certificate of Origin ?  In this case I'll go ahead as it's only a
> single line.


The signed-off-by lines are not common in the BSD world:
http://www.netbsd.org/developers/commit-guidelines.html

>> From Documentation/SubmittingPatches in the Linux kernel tree:
>
>          Developer's Certificate of Origin 1.1


Xen kernel != Linux kernel

If you want people to follow the Linux kernel guidelines this should
be explicitely documented somewhere easy to find even for someone not
familiar with the Linux community.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Re: Patch for Xen 4.1.1 not working with LVM volumes and pygrub on NetBSD

[Tim Deegan]

At 15:16 +0200 on 28 Jun (1309274186), Christoph Egger wrote:
> If you want people to follow the Linux kernel guidelines this should
> be explicitely documented somewhere easy to find even for someone not
> familiar with the Linux community.

It's documented here: http://wiki.xen.org/xenwiki/SubmittingXenPatches

Tim.

-- 
Tim Deegan <Tim.Deegan@citrix.com>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

Re: Patch for Xen 4.1.1 not working with LVM volumes and pygrub on NetBSD

[Roger Pau Monné]

Hello,

Thanks, I will signoff next time.

2011/6/28 Tim Deegan <Tim.Deegan@citrix.com>:
> At 15:16 +0200 on 28 Jun (1309274186), Christoph Egger wrote:
>> If you want people to follow the Linux kernel guidelines this should
>> be explicitely documented somewhere easy to find even for someone not
>> familiar with the Linux community.
>
> It's documented here: http://wiki.xen.org/xenwiki/SubmittingXenPatches
>
> Tim.
>
> --
> Tim Deegan <Tim.Deegan@citrix.com>
> Principal Software Engineer, Xen Platform Team
> Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>