Re: [RFC 2/2] Don't push a repository with unpushed submodules

[Jens Lehmann <Jens.Lehmann@web.de>]

Am 29.06.2011 00:06, schrieb Marc Branchaud:
> First, I expect performance will be terrible in repositories with large
> and/or many submodules.  I'd go so far as to say that it's pretty much a
> show-stopper for our repository.

Large submodules won't be the problem here, but many submodules and/or
many commits might cause some performance degradations here. But please
notice that there is no communication with the upstream of the submodules,
we only check the refs present locally. Do you still think doing some
"git rev-list" invocations in your submodules will be a problem? Then
please say so.

> Second, there are many times where I'm working in a submodule on branch
> "TopicA" but not in branch "TopicB".  If I've made submodule changes in
> TopicA then try to push up TopicB, won't I have have to tell push to "-f"?
> But that turns off other checks that I'd rather keep.

Nope, this patch only checks the refs to be pushed, not any others. So it
will only check that all submodule commits on branch "TopicB" are pushed.

> I'd feel a lot better about this patch if the check was *off* by default and
> there was a config setting / command-line option to turn it on.

I have no objections against making that configurable, although I tend
towards making this check default "on". But please feel free to test this
feature and tell us if it really hinders you in your work or does cause
performance degradation, we'll really appreciate the feedback!

> I also agree with Junio that this kind of verification makes more sense in a
> hook on the server side.

Hmm, but isn't that assuming that the server knows (= hosts?) both the
submodule and the superproject?