From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: remove unnecessary mach/hardware.h includes
Date: Tue, 28 Jun 2011 21:41:29 -0500 [thread overview]
Message-ID: <4E0A90D9.1060601@gmail.com> (raw)
In-Reply-To: <20110628232429.GI21898@n2100.arm.linux.org.uk>
On 06/28/2011 06:24 PM, Russell King - ARM Linux wrote:
> On Tue, Jun 28, 2011 at 05:57:37PM -0500, Rob Herring wrote:
>> From: Rob Herring <rob.herring@calxeda.com>
>>
>> Remove some includes of mach/hardware.h which are not needed. hardware.h will
>> be removed completely for tegra and cns3xxx in follow on patch.
>
> At least this one is incorrect:
>
> arch/arm/mach-rpc/include/mach/hardware.h:#define IO_EC_MEMC_BASE 0x80000000
> arch/arm/kernel/ecard.c: address = IO_EC_MEMC_BASE + (slot << 12);
>
> That's just one of the defines that ecard.c uses from mach/hardare.h.
>
It happens to still compile, so it's getting included thru another
include. I see these options:
-Revert this change. RPC is not going to be built in a multi-platform
kernel anyway. Leaving it could affect how include paths get setup for
multi-platform builds.
-Move ecard.c into mach-rpc. It doesn't appear to be used by anything else.
I'll do the 1st option for now.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robherring2@gmail.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Michal Simek <monstr@monstr.eu>,
nico@fluxnic.net
Subject: Re: [PATCH 2/4] ARM: remove unnecessary mach/hardware.h includes
Date: Tue, 28 Jun 2011 21:41:29 -0500 [thread overview]
Message-ID: <4E0A90D9.1060601@gmail.com> (raw)
In-Reply-To: <20110628232429.GI21898@n2100.arm.linux.org.uk>
On 06/28/2011 06:24 PM, Russell King - ARM Linux wrote:
> On Tue, Jun 28, 2011 at 05:57:37PM -0500, Rob Herring wrote:
>> From: Rob Herring <rob.herring@calxeda.com>
>>
>> Remove some includes of mach/hardware.h which are not needed. hardware.h will
>> be removed completely for tegra and cns3xxx in follow on patch.
>
> At least this one is incorrect:
>
> arch/arm/mach-rpc/include/mach/hardware.h:#define IO_EC_MEMC_BASE 0x80000000
> arch/arm/kernel/ecard.c: address = IO_EC_MEMC_BASE + (slot << 12);
>
> That's just one of the defines that ecard.c uses from mach/hardare.h.
>
It happens to still compile, so it's getting included thru another
include. I see these options:
-Revert this change. RPC is not going to be built in a multi-platform
kernel anyway. Leaving it could affect how include paths get setup for
multi-platform builds.
-Move ecard.c into mach-rpc. It doesn't appear to be used by anything else.
I'll do the 1st option for now.
Rob
next prev parent reply other threads:[~2011-06-29 2:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 22:57 [RFC PATCH 0/4] ARM: make mach/hardware.h optional Rob Herring
2011-06-28 22:57 ` Rob Herring
2011-06-28 22:57 ` [PATCH 1/4] microblaze: move pci flag functions into asm-generic Rob Herring
2011-06-28 22:57 ` Rob Herring
2011-06-28 22:57 ` [PATCH 2/4] ARM: remove unnecessary mach/hardware.h includes Rob Herring
2011-06-28 22:57 ` Rob Herring
2011-06-28 23:24 ` Russell King - ARM Linux
2011-06-28 23:24 ` Russell King - ARM Linux
2011-06-29 2:41 ` Rob Herring [this message]
2011-06-29 2:41 ` Rob Herring
2011-06-28 22:57 ` [PATCH 3/4] ARM: pci: make pcibios_assign_all_busses use pci_has_flag Rob Herring
2011-06-28 22:57 ` Rob Herring
2011-06-28 22:57 ` [PATCH 4/4] ARM: convert PCI defines to variables Rob Herring
2011-06-28 22:57 ` Rob Herring
2011-06-28 23:41 ` Russell King - ARM Linux
2011-06-28 23:41 ` Russell King - ARM Linux
2011-06-29 2:32 ` Rob Herring
2011-06-29 2:32 ` Rob Herring
2011-06-28 23:24 ` [RFC PATCH 0/4] ARM: make mach/hardware.h optional Nicolas Pitre
2011-06-28 23:24 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0A90D9.1060601@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.