From: Anthony Liguori <anthony@codemonkey.ws>
To: Christoph Hellwig <hch@lst.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Avi Kivity <avi@redhat.com>,
Qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] Default cache mode
Date: Wed, 29 Jun 2011 09:20:03 -0500 [thread overview]
Message-ID: <4E0B3493.4080706@codemonkey.ws> (raw)
In-Reply-To: <20110629135545.GD15863@lst.de>
On 06/29/2011 08:55 AM, Christoph Hellwig wrote:
> On Wed, Jun 29, 2011 at 07:08:18AM -0500, Anthony Liguori wrote:
>> As long as we advertise wce and wce can be toggled from the guest, I don't
>> think the default is all that important. I think cache=on is the right
>> default for most common use cases.
>
> What do you mean with cache=on?
Sorry, I meant having a new cache option (maybe diskcache). Semantics
would be:
diskcache=on,wce=on 0
diskcache=on,wce=off O_SYNC
diskcache=off,wce=on O_DIRECT
diskcache=off,wce=off O_DIRECT | O_SYNC
ignore_flush could be another option too.
> We have
> cache=[none,writeback,writethrough,unsafe]. As discussed about a dozen
> times before these are an incomplete choice of the [odirect=on,off;
> osync=on,off, ignore cache flushes=on,off] matrix.
Yup, I agree that we need to deprecate
cache=[none,writeback,writethrough,unsafe] and add more meaningful tunables.
> Not using O_DIRECT when it is available is almost always the wrong choice.
> It means an additional data copy, VM pressure and exercise of often suck
> fsync/O_SYNC codepatheses, with only a benefit if you have multiple VMs
> actually using the same dataset with the same COW backing image.
Can we set globals for -drive via -readconfig?
If so, we could defer the default value to a config file setting which I
think would be the best possible scenario.
I think developers usually want diskcache=on but I also agree that
usually in production, you want diskcache=off.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2011-06-29 14:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 11:59 [Qemu-devel] Default cache mode Kevin Wolf
2011-06-29 12:06 ` Anthony Liguori
2011-06-29 12:16 ` Kevin Wolf
2011-06-29 12:23 ` Anthony Liguori
2011-06-29 12:32 ` Kevin Wolf
2011-06-29 13:51 ` Christoph Hellwig
2011-06-29 14:17 ` Michael Tokarev
2011-06-29 14:50 ` Christoph Hellwig
2011-06-29 15:07 ` Michael Tokarev
2011-06-29 13:50 ` Christoph Hellwig
2011-06-29 14:13 ` Anthony Liguori
2011-06-29 14:47 ` Christoph Hellwig
2011-06-29 16:03 ` Stefan Hajnoczi
2011-06-29 13:53 ` Frediano Ziglio
2011-06-29 14:11 ` Kevin Wolf
2011-06-29 14:12 ` Christoph Hellwig
2011-06-29 14:21 ` Kevin Wolf
2011-06-29 13:49 ` Christoph Hellwig
2011-06-29 12:08 ` Anthony Liguori
2011-06-29 13:55 ` Christoph Hellwig
2011-06-29 14:20 ` Anthony Liguori [this message]
2011-06-29 14:52 ` Christoph Hellwig
2011-06-29 15:26 ` Anthony Liguori
2011-06-29 12:21 ` Alexander Graf
2011-06-29 13:57 ` Stefan Hajnoczi
2011-06-29 14:05 ` Alexander Graf
2011-06-29 12:52 ` Stefan Hajnoczi
2011-06-29 13:56 ` Christoph Hellwig
2011-06-29 13:00 ` Avi Kivity
2011-06-29 13:05 ` Anthony Liguori
2011-06-29 13:30 ` Avi Kivity
2011-06-29 13:11 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0B3493.4080706@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=Qemu-devel@nongnu.org \
--cc=avi@redhat.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.