From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
"Michael S.Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>,
jan.kiszka@web.de, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] Add compat eventfd header
Date: Wed, 29 Jun 2011 17:52:51 +0200 [thread overview]
Message-ID: <4E0B4A53.6000903@redhat.com> (raw)
In-Reply-To: <5E0F3960-6FEB-4F97-8590-DC7AEB15BDCE@suse.de>
On 06/29/2011 03:22 PM, Alexander Graf wrote:
> Well, you need to make sure that it only gets included on Linux
> systems and if there's ever some more compatibility wrapping around
> the syscall (unlikely, but you never know), this could potentially
> break.
>
> Also, who defines SYS_eventfd? What if you're trying to build this
> code on SLES10 for example, which does not have the syscall and thus
> doesn't have it defined? Would compilation simply break?
No, he patched configure to use the compat header too, so detection
would fail at configure time and eventfd would not be used.
Paolo
prev parent reply other threads:[~2011-06-29 15:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 15:35 [Qemu-devel] [PATCH] Add compat eventfd header Michael S. Tsirkin
2011-06-29 13:02 ` Alexander Graf
2011-06-29 13:11 ` Michael S. Tsirkin
2011-06-29 13:22 ` Alexander Graf
2011-06-29 13:59 ` Michael S. Tsirkin
2011-06-29 14:07 ` Alexander Graf
2011-06-29 15:28 ` Michael S. Tsirkin
2011-06-29 15:30 ` Alexander Graf
2011-06-29 15:33 ` Michael S. Tsirkin
2011-06-29 15:52 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0B4A53.6000903@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=jan.kiszka@web.de \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.