* [PATCH] linux-omap-psp-2.6.32 kernel: Fixed User-button GPIO to correct value for -xM
@ 2011-06-30 4:51 Joel A Fernandes
2011-06-30 8:13 ` Khem Raj
0 siblings, 1 reply; 3+ messages in thread
From: Joel A Fernandes @ 2011-06-30 4:51 UTC (permalink / raw)
To: openembedded-devel; +Cc: beagleboard, jkridner, Koen
Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com>
---
...agle-cleaned-up-board-revision-conditions.patch | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch b/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
index 513a101..fb91cb6 100644
--- a/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
+++ b/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
@@ -143,8 +143,8 @@ index 4bde54b..664a9c6 100644
omap3_beagle_i2c_init();
- if (cpu_is_omap3630()) {
-+ if ((omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMAB) &&
-+ (omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMC)) {
++ if ((omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMAB) ||
++ (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMC)) {
gpio_buttons[0].gpio = 4;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] linux-omap-psp-2.6.32 kernel: Fixed User-button GPIO to correct value for -xM
2011-06-30 4:51 [PATCH] linux-omap-psp-2.6.32 kernel: Fixed User-button GPIO to correct value for -xM Joel A Fernandes
@ 2011-06-30 8:13 ` Khem Raj
2011-06-30 9:03 ` Paul Menzel
0 siblings, 1 reply; 3+ messages in thread
From: Khem Raj @ 2011-06-30 8:13 UTC (permalink / raw)
To: openembedded-devel
On 06/29/2011 09:51 PM, Joel A Fernandes wrote:
> Signed-off-by: Joel A Fernandes<agnel.joel@gmail.com>
> ---
> ...agle-cleaned-up-board-revision-conditions.patch | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch b/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
> index 513a101..fb91cb6 100644
> --- a/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
> +++ b/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
> @@ -143,8 +143,8 @@ index 4bde54b..664a9c6 100644
> omap3_beagle_i2c_init();
>
> - if (cpu_is_omap3630()) {
> -+ if ((omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMAB)&&
> -+ (omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMC)) {
> ++ if ((omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMAB) ||
> ++ (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMC)) {
> gpio_buttons[0].gpio = 4;
> }
>
while the patch seems good it does not follow the submission guidelines.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] linux-omap-psp-2.6.32 kernel: Fixed User-button GPIO to correct value for -xM
2011-06-30 8:13 ` Khem Raj
@ 2011-06-30 9:03 ` Paul Menzel
0 siblings, 0 replies; 3+ messages in thread
From: Paul Menzel @ 2011-06-30 9:03 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1683 bytes --]
Am Donnerstag, den 30.06.2011, 01:13 -0700 schrieb Khem Raj:
> On 06/29/2011 09:51 PM, Joel A Fernandes wrote:
> > Signed-off-by: Joel A Fernandes<agnel.joel@gmail.com>
> > ---
> > ...agle-cleaned-up-board-revision-conditions.patch | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch b/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
> > index 513a101..fb91cb6 100644
> > --- a/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
> > +++ b/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
> > @@ -143,8 +143,8 @@ index 4bde54b..664a9c6 100644
> > omap3_beagle_i2c_init();
> >
> > - if (cpu_is_omap3630()) {
> > -+ if ((omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMAB)&&
> > -+ (omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMC)) {
> > ++ if ((omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMAB) ||
> > ++ (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMC)) {
> > gpio_buttons[0].gpio = 4;
> > }
> >
>
> while the patch seems good it does not follow the submission guidelines.
Please read the following policies [1] in the Wiki [2][3][4].
Thanks,
Paul
[1] http://openembedded.org/index.php/Category:Policy
[2] http://openembedded.org/index.php/Commit_Patch_Message_Guidelines
[3] http://openembedded.org/index.php/Commit_Policy
[4] http://openembedded.org/index.php/Commit_log_example
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-30 9:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-30 4:51 [PATCH] linux-omap-psp-2.6.32 kernel: Fixed User-button GPIO to correct value for -xM Joel A Fernandes
2011-06-30 8:13 ` Khem Raj
2011-06-30 9:03 ` Paul Menzel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.