From: Fabien Chouteau <chouteau@adacore.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes minimuma
Date: Thu, 30 Jun 2011 10:38:35 +0200 [thread overview]
Message-ID: <4E0C360B.5060406@adacore.com> (raw)
In-Reply-To: <BANLkTikLwOzo_akmzV+jLYsSVDpi7oGsjw@mail.gmail.com>
On 28/06/2011 15:15, Stefan Hajnoczi wrote:
> On Tue, Jun 28, 2011 at 10:08 AM, Fabien Chouteau <chouteau@adacore.com> wrote:
>> On 28/06/2011 10:34, Stefan Hajnoczi wrote:
>>> This patch doesn't hurt but we'd be just as well off without it.
>>>
>>> Did you do this to fix a bug? If so, then something else in QEMU
>>> needs to be fixed, not slirp.
>>
>> When Qemu generates bad Ethernet frames, I think it's a bug.
>>
>> And again, this is the extension of a previous patch. If this patch is not
>> valid then we should revert the first, it's also a question of consistency.
>
> IMO the previous patch is not necessary either.
>
> Since there is no net subsystem maintainer who can help decide which
> way to go, I'm going to back off from this issue. Please go ahead.
>
OK thanks.
Any other comments?
--
Fabien Chouteau
next prev parent reply other threads:[~2011-06-30 8:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 12:41 [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes minimum Fabien Chouteau
2011-06-27 13:50 ` Stefan Hajnoczi
2011-06-27 14:23 ` Fabien Chouteau
2011-06-27 15:39 ` Stefan Hajnoczi
2011-06-27 16:12 ` Fabien Chouteau
2011-06-28 8:34 ` Stefan Hajnoczi
2011-06-28 9:08 ` [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes minimuma Fabien Chouteau
2011-06-28 13:15 ` Stefan Hajnoczi
2011-06-30 8:38 ` Fabien Chouteau [this message]
2011-07-05 14:24 ` Fabien Chouteau
2011-08-04 23:04 ` [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes minimum Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0C360B.5060406@adacore.com \
--to=chouteau@adacore.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.