From: Kevin Wolf <kwolf@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org,
stefano.stabellini@eu.citrix.com
Subject: Re: [Qemu-devel] [PATCH] xen_disk: treat "aio" as "raw"
Date: Thu, 30 Jun 2011 14:47:03 +0200 [thread overview]
Message-ID: <4E0C7047.3010909@redhat.com> (raw)
In-Reply-To: <4E0C6263.20908@suse.de>
Am 30.06.2011 13:47, schrieb Alexander Graf:
> On 06/24/2011 04:50 PM, stefano.stabellini@eu.citrix.com wrote:
>> From: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
>>
>> Sometimes the toolstack uses "aio" without an additional format
>> identifier, in such cases use "raw".
>
> Shouldn't this rather be a patch to the toolstack then? We do automatic
> file format recognition as default. I find magical "aio equals raw"
> subtleties rather unintuitive.
The asynchronous raw blktap driver is (was?) called "aio", so I guess
it's to stay compatible with that. Has always been this way in Xen (and
has always been confusing). As long as it stays in xen_disk.c, I don't
really mind...
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Wolf <kwolf@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org,
stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH] xen_disk: treat "aio" as "raw"
Date: Thu, 30 Jun 2011 14:47:03 +0200 [thread overview]
Message-ID: <4E0C7047.3010909@redhat.com> (raw)
In-Reply-To: <4E0C6263.20908@suse.de>
Am 30.06.2011 13:47, schrieb Alexander Graf:
> On 06/24/2011 04:50 PM, stefano.stabellini@eu.citrix.com wrote:
>> From: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
>>
>> Sometimes the toolstack uses "aio" without an additional format
>> identifier, in such cases use "raw".
>
> Shouldn't this rather be a patch to the toolstack then? We do automatic
> file format recognition as default. I find magical "aio equals raw"
> subtleties rather unintuitive.
The asynchronous raw blktap driver is (was?) called "aio", so I guess
it's to stay compatible with that. Has always been this way in Xen (and
has always been confusing). As long as it stays in xen_disk.c, I don't
really mind...
Kevin
next prev parent reply other threads:[~2011-06-30 12:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 14:50 [Qemu-devel] [PATCH] xen_disk: cope with missing xenstore "params" node stefano.stabellini
2011-06-24 14:50 ` stefano.stabellini
2011-06-24 14:50 ` [Qemu-devel] [PATCH] xen_disk: treat "aio" as "raw" stefano.stabellini
2011-06-24 14:50 ` stefano.stabellini
2011-06-30 11:47 ` [Qemu-devel] " Alexander Graf
2011-06-30 11:47 ` Alexander Graf
2011-06-30 12:47 ` Kevin Wolf [this message]
2011-06-30 12:47 ` Kevin Wolf
2011-06-30 12:45 ` [Qemu-devel] " Alexander Graf
2011-06-30 12:45 ` Alexander Graf
2011-06-30 14:20 ` [Qemu-devel] " Stefano Stabellini
2011-06-30 14:20 ` Stefano Stabellini
2011-06-30 14:32 ` [Qemu-devel] " Alexander Graf
2011-06-30 14:32 ` Alexander Graf
2011-06-30 14:39 ` [Qemu-devel] " Stefano Stabellini
2011-06-30 14:39 ` Stefano Stabellini
2011-06-24 15:06 ` [Qemu-devel] [PATCH] xen_disk: cope with missing xenstore "params" node Peter Maydell
2011-06-24 16:34 ` Stefano Stabellini
2011-06-24 16:34 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0C7047.3010909@redhat.com \
--to=kwolf@redhat.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.