From: Hannes Reinecke <hare@suse.de>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Stefan Haynoczi <stefanha@linux.vnet.ibm.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 1/3] iov: Add 'offset' parameter to iov_to_buf()
Date: Fri, 01 Jul 2011 10:07:27 +0200 [thread overview]
Message-ID: <4E0D803F.5060605@suse.de> (raw)
In-Reply-To: <0709C61D-84CB-4CD2-803D-93CE3AD66888@suse.de>
On 07/01/2011 10:02 AM, Alexander Graf wrote:
>
> On 01.07.2011, at 09:42, Hannes Reinecke wrote:
>
>> Occasionally, the buffer needs to be placed at a offset within
>> the iovec when copying the buffer to the iovec.
>
> So this is a buffer into the iovec, right? Wouldn't it make sense
> to also modify iov_to_buf respectively then, so the API stays
similar?
Ahem. That's exactly what the patch does. Except from the mixed-up
subject.
iov_to_buff() has an offset parameter, iov_from_buf() has not.
For no obvious reasons.
> Also, it'd be nice to give the parameter a more obvious name, so potential
> users can easily recognize what it offsets.
>
Yes, that sounds reasonable.
What about 'iov_off' ?
(And possibly rename 'iovcnt' to 'iov_cnt' for consistency ?)
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
WARNING: multiple messages have this Message-ID (diff)
From: Hannes Reinecke <hare@suse.de>
To: Alexander Graf <agraf@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
Stefan Haynoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] iov: Add 'offset' parameter to iov_to_buf()
Date: Fri, 01 Jul 2011 10:07:27 +0200 [thread overview]
Message-ID: <4E0D803F.5060605@suse.de> (raw)
In-Reply-To: <0709C61D-84CB-4CD2-803D-93CE3AD66888@suse.de>
On 07/01/2011 10:02 AM, Alexander Graf wrote:
>
> On 01.07.2011, at 09:42, Hannes Reinecke wrote:
>
>> Occasionally, the buffer needs to be placed at a offset within
>> the iovec when copying the buffer to the iovec.
>
> So this is a buffer into the iovec, right? Wouldn't it make sense
> to also modify iov_to_buf respectively then, so the API stays
similar?
Ahem. That's exactly what the patch does. Except from the mixed-up
subject.
iov_to_buff() has an offset parameter, iov_from_buf() has not.
For no obvious reasons.
> Also, it'd be nice to give the parameter a more obvious name, so potential
> users can easily recognize what it offsets.
>
Yes, that sounds reasonable.
What about 'iov_off' ?
(And possibly rename 'iovcnt' to 'iov_cnt' for consistency ?)
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
next prev parent reply other threads:[~2011-07-01 8:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 7:42 [PATCH 0/3] [v4] Megasas HBA emulation Hannes Reinecke
2011-07-01 7:42 ` [Qemu-devel] " Hannes Reinecke
2011-07-01 7:42 ` [PATCH 1/3] iov: Add 'offset' parameter to iov_to_buf() Hannes Reinecke
2011-07-01 7:42 ` [Qemu-devel] " Hannes Reinecke
2011-07-01 7:42 ` [PATCH 2/3] scsi: replace 'tag' with 'hba_private' pointer Hannes Reinecke
2011-07-01 7:42 ` [Qemu-devel] " Hannes Reinecke
2011-07-01 7:42 ` [PATCH 3/3] megasas: LSI Megaraid SAS emulation Hannes Reinecke
2011-07-01 7:42 ` [Qemu-devel] " Hannes Reinecke
2011-07-01 9:16 ` Alexander Graf
2011-07-01 9:16 ` [Qemu-devel] " Alexander Graf
2011-07-03 8:09 ` Michael S. Tsirkin
2011-07-03 8:09 ` [Qemu-devel] " Michael S. Tsirkin
2011-07-01 8:27 ` [PATCH 2/3] scsi: replace 'tag' with 'hba_private' pointer Paolo Bonzini
2011-07-01 8:27 ` [Qemu-devel] " Paolo Bonzini
2011-07-01 8:57 ` Hannes Reinecke
2011-07-01 8:57 ` [Qemu-devel] " Hannes Reinecke
2011-07-01 13:11 ` Hannes Reinecke
2011-07-01 13:11 ` [Qemu-devel] " Hannes Reinecke
2011-07-01 14:33 ` Paolo Bonzini
2011-07-01 14:33 ` [Qemu-devel] " Paolo Bonzini
2011-07-01 8:02 ` [PATCH 1/3] iov: Add 'offset' parameter to iov_to_buf() Alexander Graf
2011-07-01 8:02 ` [Qemu-devel] " Alexander Graf
2011-07-01 8:07 ` Hannes Reinecke [this message]
2011-07-01 8:07 ` Hannes Reinecke
2011-07-01 8:11 ` Alexander Graf
2011-07-01 8:11 ` [Qemu-devel] " Alexander Graf
2011-07-01 8:03 ` Paolo Bonzini
2011-07-01 8:03 ` [Qemu-devel] " Paolo Bonzini
2011-07-01 8:04 ` Hannes Reinecke
2011-07-01 8:04 ` [Qemu-devel] " Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0D803F.5060605@suse.de \
--to=hare@suse.de \
--cc=agraf@suse.de \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.