All of lore.kernel.org
 help / color / mirror / Atom feed
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: DMA: Add missing semicolon for the define of dma_alloc_area
Date: Fri, 01 Jul 2011 15:12:16 +0400	[thread overview]
Message-ID: <4E0DAB90.9080708@mvista.com> (raw)
In-Reply-To: <1309509472.30642.1.camel@phoenix>

Hello.

On 01-07-2011 12:37, Axel Lin wrote:

> I got below build error by: make at91x40_defconfig;make
> Fix it by adding a missing semicolon for the define of dma_alloc_area.

>    CC      arch/arm/mm/dma-mapping.o
> arch/arm/mm/dma-mapping.c:309: warning: 'struct dma_coherent_area' declared inside parameter list
> arch/arm/mm/dma-mapping.c:309: warning: its scope is only this definition or declaration, which is probably not what you want
> arch/arm/mm/dma-mapping.c: In function '__dma_alloc':
> arch/arm/mm/dma-mapping.c:324: error: expected ';' before '}' token
> arch/arm/mm/dma-mapping.c: At top level:
> arch/arm/mm/dma-mapping.c:334: warning: 'struct dma_coherent_area' declared inside parameter list
> arch/arm/mm/dma-mapping.c:374: warning: 'struct dma_coherent_area' declared inside parameter list
> make[1]: *** [arch/arm/mm/dma-mapping.o] Error 1
> make: *** [arch/arm/mm] Error 2

    You didn't fix the warning though, so not clear why you cited them....

> Signed-off-by: Axel Lin<axel.lin@gmail.com>

WBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Russell King <linux@arm.linux.org.uk>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: DMA: Add missing semicolon for the define of dma_alloc_area
Date: Fri, 01 Jul 2011 15:12:16 +0400	[thread overview]
Message-ID: <4E0DAB90.9080708@mvista.com> (raw)
In-Reply-To: <1309509472.30642.1.camel@phoenix>

Hello.

On 01-07-2011 12:37, Axel Lin wrote:

> I got below build error by: make at91x40_defconfig;make
> Fix it by adding a missing semicolon for the define of dma_alloc_area.

>    CC      arch/arm/mm/dma-mapping.o
> arch/arm/mm/dma-mapping.c:309: warning: 'struct dma_coherent_area' declared inside parameter list
> arch/arm/mm/dma-mapping.c:309: warning: its scope is only this definition or declaration, which is probably not what you want
> arch/arm/mm/dma-mapping.c: In function '__dma_alloc':
> arch/arm/mm/dma-mapping.c:324: error: expected ';' before '}' token
> arch/arm/mm/dma-mapping.c: At top level:
> arch/arm/mm/dma-mapping.c:334: warning: 'struct dma_coherent_area' declared inside parameter list
> arch/arm/mm/dma-mapping.c:374: warning: 'struct dma_coherent_area' declared inside parameter list
> make[1]: *** [arch/arm/mm/dma-mapping.o] Error 1
> make: *** [arch/arm/mm] Error 2

    You didn't fix the warning though, so not clear why you cited them....

> Signed-off-by: Axel Lin<axel.lin@gmail.com>

WBR, Sergei

  reply	other threads:[~2011-07-01 11:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-01  8:37 [PATCH] ARM: DMA: Add missing semicolon for the define of dma_alloc_area Axel Lin
2011-07-01  8:37 ` Axel Lin
2011-07-01 11:12 ` Sergei Shtylyov [this message]
2011-07-01 11:12   ` Sergei Shtylyov
2011-07-04  8:10   ` Axel Lin
2011-07-04  8:10     ` Axel Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E0DAB90.9080708@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.