All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: netdev <netdev@vger.kernel.org>, linux-nfs@vger.kernel.org
Subject: another sunrpc locking question
Date: Fri, 01 Jul 2011 12:50:02 -0700	[thread overview]
Message-ID: <4E0E24EA.20300@candelatech.com> (raw)


It seems that the rpc_shutdown_client logic grabs
a clnt->cl_lock lock, and then in the rpc_exit logic it
writes to the task->tk_action.

But, I don't see anything keeping that from racing with
the __rpc_execute() logic, which might also be modifying
the task object without any locks held.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb-my8/4N5VtI7c+919tysfdA@public.gmane.org>
To: netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: another sunrpc locking question
Date: Fri, 01 Jul 2011 12:50:02 -0700	[thread overview]
Message-ID: <4E0E24EA.20300@candelatech.com> (raw)


It seems that the rpc_shutdown_client logic grabs
a clnt->cl_lock lock, and then in the rpc_exit logic it
writes to the task->tk_action.

But, I don't see anything keeping that from racing with
the __rpc_execute() logic, which might also be modifying
the task object without any locks held.

Thanks,
Ben

-- 
Ben Greear <greearb-my8/4N5VtI7c+919tysfdA@public.gmane.org>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2011-07-01 19:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-01 19:50 Ben Greear [this message]
2011-07-01 19:50 ` another sunrpc locking question Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E0E24EA.20300@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.