Any reasons not to use "newer" ppp?

Any reasons not to use "newer" ppp?

[Steffen Sledz]

The current oe-dev master contains recipes for 2.4.4 and 2.4.5, but both are DEFAULT_PREFERENCE = "-1", so 2.4.3 is used by default.

We hit a problem in LCP open/close handling which is fixed in the newer versions.

Is there any reason *not* to go to 2.4.5?

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058

Re: Any reasons not to use "newer" ppp?

[Phil Blundell]

On Thu, 2011-06-30 at 12:12 +0200, Steffen Sledz wrote:
> The current oe-dev master contains recipes for 2.4.4 and 2.4.5, but both are DEFAULT_PREFERENCE = "-1", so 2.4.3 is used by default.
> 
> We hit a problem in LCP open/close handling which is fixed in the newer versions.
> 
> Is there any reason *not* to go to 2.4.5?

Oe-core is using 2.4.5 and presumably it works OK there.  Judging from
the commit messages there is no good reason for 2.4.5 to have been set
D_P=-1 in oe.dev, so I think you should be safe to upgrade.

p.

[PATCH] ppp: 2.4.5 seems to be ready for oe-dev too

[Steffen Sledz]

Oe-core is using 2.4.5 and it works OK there.

Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
---
 recipes/ppp/ppp_2.4.5.bb |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/recipes/ppp/ppp_2.4.5.bb b/recipes/ppp/ppp_2.4.5.bb
index 2b6b6f7..86d5ae5 100644
--- a/recipes/ppp/ppp_2.4.5.bb
+++ b/recipes/ppp/ppp_2.4.5.bb
@@ -4,8 +4,6 @@ HOMEPAGE = "http://samba.org/ppp/"
 DEPENDS = "libpcap"
 LICENSE = "BSD GPLv2"
 PR = "r1"
-# Not well tested
-DEFAULT_PREFERENCE = "-1"
 
 PARALLEL_MAKE = ""
 
-- 
1.7.6

Re: [PATCH] ppp: 2.4.5 seems to be ready for oe-dev too

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]

Am Donnerstag, den 30.06.2011, 12:22 +0200 schrieb Steffen Sledz:

ppp_2.4.5: remove `DP = "-1"`

is a more appropriate and precise commit summary in my opinion.

> Oe-core is using 2.4.5 and it works OK there.
> 
> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
> ---
>  recipes/ppp/ppp_2.4.5.bb |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes/ppp/ppp_2.4.5.bb b/recipes/ppp/ppp_2.4.5.bb
> index 2b6b6f7..86d5ae5 100644
> --- a/recipes/ppp/ppp_2.4.5.bb
> +++ b/recipes/ppp/ppp_2.4.5.bb
> @@ -4,8 +4,6 @@ HOMEPAGE = "http://samba.org/ppp/"
>  DEPENDS = "libpcap"
>  LICENSE = "BSD GPLv2"
>  PR = "r1"
> -# Not well tested
> -DEFAULT_PREFERENCE = "-1"
>  
>  PARALLEL_MAKE = ""

I am getting the following warning when building the recipe with
`minimal{,-uclibc}` which I do not get with PPP 2.4.3.

        NOTE: package ppp-2.4.5-r1: task do_qa_staging: Started
        WARNING: the following files were installed but not shipped in any package:
        WARNING:   /usr/lib/pppd/2.4.5/pppol2tp.so
        WARNING:   /usr/lib/pppd/2.4.5/openl2tp.so

Could you fix this in a separate patch before committing this patch?

With the points above fixed/done this patch is

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH] ppp: 2.4.5 seems to be ready for oe-dev too

[Steffen Sledz]

On 30.06.2011 19:28, Paul Menzel wrote:
> ppp_2.4.5: remove `DP = "-1"`
> 
> is a more appropriate and precise commit summary in my opinion.

yepp

>> Oe-core is using 2.4.5 and it works OK there.
>>
>> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
>> ---
>>  recipes/ppp/ppp_2.4.5.bb |    2 --
>>  1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/recipes/ppp/ppp_2.4.5.bb b/recipes/ppp/ppp_2.4.5.bb
>> index 2b6b6f7..86d5ae5 100644
>> --- a/recipes/ppp/ppp_2.4.5.bb
>> +++ b/recipes/ppp/ppp_2.4.5.bb
>> @@ -4,8 +4,6 @@ HOMEPAGE = "http://samba.org/ppp/"
>>  DEPENDS = "libpcap"
>>  LICENSE = "BSD GPLv2"
>>  PR = "r1"
>> -# Not well tested
>> -DEFAULT_PREFERENCE = "-1"
>>  
>>  PARALLEL_MAKE = ""
> 
> I am getting the following warning when building the recipe with
> `minimal{,-uclibc}` which I do not get with PPP 2.4.3.
> 
>         NOTE: package ppp-2.4.5-r1: task do_qa_staging: Started
>         WARNING: the following files were installed but not shipped in any package:
>         WARNING:   /usr/lib/pppd/2.4.5/pppol2tp.so
>         WARNING:   /usr/lib/pppd/2.4.5/openl2tp.so
> 
> Could you fix this in a separate patch before committing this patch?

Can please someone of the oe-core guys check if the problem is fixed there? And cherry-pick the fix to oe-dev master in that case.

Thx,
Steffen

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058

Re: [oe] Any reasons not to use "newer" ppp?

[Steffen Sledz]

On 30.06.2011 12:15, Phil Blundell wrote:
> On Thu, 2011-06-30 at 12:12 +0200, Steffen Sledz wrote:
>> The current oe-dev master contains recipes for 2.4.4 and 2.4.5, but both are DEFAULT_PREFERENCE = "-1", so 2.4.3 is used by default.
>>
>> We hit a problem in LCP open/close handling which is fixed in the newer versions.
>>
>> Is there any reason *not* to go to 2.4.5?
> 
> Oe-core is using 2.4.5 and presumably it works OK there.  Judging from
> the commit messages there is no good reason for 2.4.5 to have been set
> D_P=-1 in oe.dev, so I think you should be safe to upgrade.

While making some investingations in this i hit another problem.

The recipe *ppp_2.4.5.bb* in *oe-core* contains lines like these:
------------------>snip<-------------------
FILES_${PN}-dbg += "${libdir}/pppd/2.4.3/.debug"
FILES_ppp-oa       = "/usr/lib/pppd/2.4.3/pppoatm.so"
FILES_ppp-oe       = "/usr/sbin/pppoe-discovery /usr/lib/pppd/2.4.3/rp-pppoe.so"
FILES_ppp-radius   = "/usr/lib/pppd/2.4.3/radius.so /usr/lib/pppd/2.4.3/radattr.so /usr/lib/pppd/2.4.3/radrealms.so"
FILES_ppp-winbind  = "/usr/lib/pppd/2.4.3/winbind.so"
FILES_ppp-minconn  = "/usr/lib/pppd/2.4.3/minconn.so"
FILES_ppp-password = "/usr/lib/pppd/2.4.3/pass*.so"
------------------>snip<-------------------

I can't imagine that it is intentionally to have hardcoded pathes with *2.4.3* in it here.

The ppp_2.4.5.bb recipe in oe-dev looks much cleaner. Is there someone who feels as a maintainer of ppp and can do some housekeeping here?

Regards,
Steffen

PS: Fup set to the original thread in openembedded-devel list.

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058

Re: Any reasons not to use "newer" ppp?

[Steffen Sledz]

On 30.06.2011 12:15, Phil Blundell wrote:
> On Thu, 2011-06-30 at 12:12 +0200, Steffen Sledz wrote:
>> The current oe-dev master contains recipes for 2.4.4 and 2.4.5, but both are DEFAULT_PREFERENCE = "-1", so 2.4.3 is used by default.
>>
>> We hit a problem in LCP open/close handling which is fixed in the newer versions.
>>
>> Is there any reason *not* to go to 2.4.5?
> 
> Oe-core is using 2.4.5 and presumably it works OK there.  Judging from
> the commit messages there is no good reason for 2.4.5 to have been set
> D_P=-1 in oe.dev, so I think you should be safe to upgrade.

While making some investingations in this i hit another problem.

The recipe *ppp_2.4.5.bb* in *oe-core* contains lines like these:
------------------>snip<-------------------
FILES_${PN}-dbg += "${libdir}/pppd/2.4.3/.debug"
FILES_ppp-oa       = "/usr/lib/pppd/2.4.3/pppoatm.so"
FILES_ppp-oe       = "/usr/sbin/pppoe-discovery /usr/lib/pppd/2.4.3/rp-pppoe.so"
FILES_ppp-radius   = "/usr/lib/pppd/2.4.3/radius.so /usr/lib/pppd/2.4.3/radattr.so /usr/lib/pppd/2.4.3/radrealms.so"
FILES_ppp-winbind  = "/usr/lib/pppd/2.4.3/winbind.so"
FILES_ppp-minconn  = "/usr/lib/pppd/2.4.3/minconn.so"
FILES_ppp-password = "/usr/lib/pppd/2.4.3/pass*.so"
------------------>snip<-------------------

I can't imagine that it is intentionally to have hardcoded pathes with *2.4.3* in it here.

The ppp_2.4.5.bb recipe in oe-dev looks much cleaner. Is there someone who feels as a maintainer of ppp and can do some housekeeping here?

Regards,
Steffen

PS: Fup set to the original thread in openembedded-devel list.

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058

Re: Any reasons not to use "newer" ppp?

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 01-07-11 17:39, Steffen Sledz schreef:
> On 30.06.2011 12:15, Phil Blundell wrote:
>> On Thu, 2011-06-30 at 12:12 +0200, Steffen Sledz wrote:
>>> The current oe-dev master contains recipes for 2.4.4 and 2.4.5,
>>> but both are DEFAULT_PREFERENCE = "-1", so 2.4.3 is used by
>>> default.
>>> 
>>> We hit a problem in LCP open/close handling which is fixed in the
>>> newer versions.
>>> 
>>> Is there any reason *not* to go to 2.4.5?
>> 
>> Oe-core is using 2.4.5 and presumably it works OK there.  Judging
>> from the commit messages there is no good reason for 2.4.5 to have
>> been set D_P=-1 in oe.dev, so I think you should be safe to
>> upgrade.
> 
> While making some investingations in this i hit another problem.
> 
> The recipe *ppp_2.4.5.bb* in *oe-core* contains lines like these: 
> ------------------>snip<------------------- FILES_${PN}-dbg +=
> "${libdir}/pppd/2.4.3/.debug" FILES_ppp-oa       =
> "/usr/lib/pppd/2.4.3/pppoatm.so" FILES_ppp-oe       =
> "/usr/sbin/pppoe-discovery /usr/lib/pppd/2.4.3/rp-pppoe.so" 
> FILES_ppp-radius   = "/usr/lib/pppd/2.4.3/radius.so
> /usr/lib/pppd/2.4.3/radattr.so /usr/lib/pppd/2.4.3/radrealms.so" 
> FILES_ppp-winbind  = "/usr/lib/pppd/2.4.3/winbind.so" 
> FILES_ppp-minconn  = "/usr/lib/pppd/2.4.3/minconn.so" 
> FILES_ppp-password = "/usr/lib/pppd/2.4.3/pass*.so" 
> ------------------>snip<-------------------
> 
> I can't imagine that it is intentionally to have hardcoded pathes
> with *2.4.3* in it here.
> 
> The ppp_2.4.5.bb recipe in oe-dev looks much cleaner. Is there
> someone who feels as a maintainer of ppp and can do some housekeeping
> here?

The OE-core recipe also has a ton of QA errors being reported, so I
wouldn't use that as an example of how to do things.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFODe3qMkyGM64RGpERAj5XAJ9cHJUSIcJ6sS6bqfNYSTYB6/KgSgCeNxZk
i6REs8lKOlBywYBoXpzt+PA=
=5yYU
-----END PGP SIGNATURE-----

[PATCH v2 1/2] ppp-2.4.5: own package for PPPoL2TP plugin

[Steffen Sledz]

Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
---
 recipes/ppp/ppp_2.4.5.bb |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/recipes/ppp/ppp_2.4.5.bb b/recipes/ppp/ppp_2.4.5.bb
index 2b6b6f7..883b695 100644
--- a/recipes/ppp/ppp_2.4.5.bb
+++ b/recipes/ppp/ppp_2.4.5.bb
@@ -3,7 +3,7 @@ DESCRIPTION = "Point-to-Point Protocol (PPP) daemon"
 HOMEPAGE = "http://samba.org/ppp/"
 DEPENDS = "libpcap"
 LICENSE = "BSD GPLv2"
-PR = "r1"
+PR = "r2"
 # Not well tested
 DEFAULT_PREFERENCE = "-1"
 
@@ -49,11 +49,12 @@ do_install_append () {
 }
 
 CONFFILES_${PN} = "${sysconfdir}/ppp/pap-secrets ${sysconfdir}/ppp/chap-secrets ${sysconfdir}/ppp/options"
-PACKAGES =+ "ppp-oa ppp-oe ppp-radius ppp-winbind ppp-minconn ppp-password ppp-tools"
+PACKAGES =+ "ppp-oa ppp-l2tp ppp-oe ppp-radius ppp-winbind ppp-minconn ppp-password ppp-tools"
 FILES_${PN}        = "${sysconfdir} ${bindir} ${sbindir}/chat ${sbindir}/pppd"
 FILES_${PN}_nylon  = "${sysconfdir} ${bindir} ${sbindir}/chat ${sbindir}/pppd ${sbindir}/tdbread"
 FILES_${PN}-dbg += "${libdir}/pppd/${PV}/.debug"
 FILES_${PN}-oa       = "${libdir}/pppd/${PV}/pppoatm.so"
+FILES_${PN}-l2tp     = "${libdir}/pppd/${PV}/pppol2tp.so ${libdir}/pppd/${PV}/openl2tp.so"
 FILES_${PN}-oe       = "${sbindir}/pppoe-discovery ${libdir}/pppd/${PV}/rp-pppoe.so"
 FILES_${PN}-radius   = "${libdir}/pppd/${PV}/radius.so ${libdir}/pppd/${PV}/radattr.so ${libdir}/pppd/${PV}/radrealms.so"
 FILES_${PN}-winbind  = "${libdir}/pppd/${PV}/winbind.so"
@@ -61,6 +62,7 @@ FILES_${PN}-minconn  = "${libdir}/pppd/${PV}/minconn.so"
 FILES_${PN}-password = "${libdir}/pppd/${PV}/pass*.so"
 FILES_${PN}-tools    = "${sbindir}/pppstats ${sbindir}/pppdump"
 DESCRIPTION_ppp-oa       = "Plugin for PPP needed for PPP-over-ATM"
+DESCRIPTION_ppp-l2tp     = "Plugin for PPP needed for PPP-over-L2TP"
 DESCRIPTION_ppp-oe       = "Plugin for PPP needed for PPP-over-Ethernet"
 DESCRIPTION_ppp-radius   = "Plugin for PPP that are related to RADIUS"
 DESCRIPTION_ppp-winbind  = "Plugin for PPP to authenticate against Samba or Windows"
-- 
1.7.3.4

[PATCH v2 2/2] ppp-2.4.5: remove `DP = "-1"`

[Steffen Sledz]

Oe-core is using 2.4.5 and it works OK there.

Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
---
 recipes/ppp/ppp_2.4.5.bb |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/recipes/ppp/ppp_2.4.5.bb b/recipes/ppp/ppp_2.4.5.bb
index 883b695..faab816 100644
--- a/recipes/ppp/ppp_2.4.5.bb
+++ b/recipes/ppp/ppp_2.4.5.bb
@@ -3,9 +3,7 @@ DESCRIPTION = "Point-to-Point Protocol (PPP) daemon"
 HOMEPAGE = "http://samba.org/ppp/"
 DEPENDS = "libpcap"
 LICENSE = "BSD GPLv2"
-PR = "r2"
-# Not well tested
-DEFAULT_PREFERENCE = "-1"
+PR = "r3"
 
 PARALLEL_MAKE = ""
 
-- 
1.7.3.4

Re: [PATCH v2 1/2] ppp-2.4.5: own package for PPPoL2TP plugin

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 2893 bytes --]

Am Montag, den 04.07.2011, 10:31 +0200 schrieb Steffen Sledz:

Could you please add the following to the commit message before you
commit?

Adding that package fixes the following error message.

        NOTE: package ppp-2.4.5-r1: task do_qa_staging: Started
        WARNING: the following files were installed but not shipped in any package:
        WARNING:   /usr/lib/pppd/2.4.5/pppol2tp.so
        WARNING:   /usr/lib/pppd/2.4.5/openl2tp.so

> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
> ---
>  recipes/ppp/ppp_2.4.5.bb |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes/ppp/ppp_2.4.5.bb b/recipes/ppp/ppp_2.4.5.bb
> index 2b6b6f7..883b695 100644
> --- a/recipes/ppp/ppp_2.4.5.bb
> +++ b/recipes/ppp/ppp_2.4.5.bb
> @@ -3,7 +3,7 @@ DESCRIPTION = "Point-to-Point Protocol (PPP) daemon"
>  HOMEPAGE = "http://samba.org/ppp/"
>  DEPENDS = "libpcap"
>  LICENSE = "BSD GPLv2"
> -PR = "r1"
> +PR = "r2"
>  # Not well tested
>  DEFAULT_PREFERENCE = "-1"
>  
> @@ -49,11 +49,12 @@ do_install_append () {
>  }
>  
>  CONFFILES_${PN} = "${sysconfdir}/ppp/pap-secrets ${sysconfdir}/ppp/chap-secrets ${sysconfdir}/ppp/options"
> -PACKAGES =+ "ppp-oa ppp-oe ppp-radius ppp-winbind ppp-minconn ppp-password ppp-tools"
> +PACKAGES =+ "ppp-oa ppp-l2tp ppp-oe ppp-radius ppp-winbind ppp-minconn ppp-password ppp-tools"
>  FILES_${PN}        = "${sysconfdir} ${bindir} ${sbindir}/chat ${sbindir}/pppd"
>  FILES_${PN}_nylon  = "${sysconfdir} ${bindir} ${sbindir}/chat ${sbindir}/pppd ${sbindir}/tdbread"
>  FILES_${PN}-dbg += "${libdir}/pppd/${PV}/.debug"
>  FILES_${PN}-oa       = "${libdir}/pppd/${PV}/pppoatm.so"
> +FILES_${PN}-l2tp     = "${libdir}/pppd/${PV}/pppol2tp.so ${libdir}/pppd/${PV}/openl2tp.so"
>  FILES_${PN}-oe       = "${sbindir}/pppoe-discovery ${libdir}/pppd/${PV}/rp-pppoe.so"
>  FILES_${PN}-radius   = "${libdir}/pppd/${PV}/radius.so ${libdir}/pppd/${PV}/radattr.so ${libdir}/pppd/${PV}/radrealms.so"
>  FILES_${PN}-winbind  = "${libdir}/pppd/${PV}/winbind.so"
> @@ -61,6 +62,7 @@ FILES_${PN}-minconn  = "${libdir}/pppd/${PV}/minconn.so"
>  FILES_${PN}-password = "${libdir}/pppd/${PV}/pass*.so"
>  FILES_${PN}-tools    = "${sbindir}/pppstats ${sbindir}/pppdump"
>  DESCRIPTION_ppp-oa       = "Plugin for PPP needed for PPP-over-ATM"
> +DESCRIPTION_ppp-l2tp     = "Plugin for PPP needed for PPP-over-L2TP"
>  DESCRIPTION_ppp-oe       = "Plugin for PPP needed for PPP-over-Ethernet"
>  DESCRIPTION_ppp-radius   = "Plugin for PPP that are related to RADIUS"
>  DESCRIPTION_ppp-winbind  = "Plugin for PPP to authenticate against Samba or Windows"

Putting these additions one line above would sort it alphabetically,
would not it? If yes, it would be nice to fix this too before pushing
the commit.

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH v2 2/2] ppp-2.4.5: remove `DP = "-1"`

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]

Am Montag, den 04.07.2011, 10:31 +0200 schrieb Steffen Sledz:
> Oe-core is using 2.4.5 and it works OK there.
> 
> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
> ---
>  recipes/ppp/ppp_2.4.5.bb |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/recipes/ppp/ppp_2.4.5.bb b/recipes/ppp/ppp_2.4.5.bb
> index 883b695..faab816 100644
> --- a/recipes/ppp/ppp_2.4.5.bb
> +++ b/recipes/ppp/ppp_2.4.5.bb
> @@ -3,9 +3,7 @@ DESCRIPTION = "Point-to-Point Protocol (PPP) daemon"
>  HOMEPAGE = "http://samba.org/ppp/"
>  DEPENDS = "libpcap"
>  LICENSE = "BSD GPLv2"
> -PR = "r2"
> -# Not well tested
> -DEFAULT_PREFERENCE = "-1"
> +PR = "r3"

Is a bump of `PR` needed? The package content does not change, does it?
 
>  PARALLEL_MAKE = ""

Is the build still failing when doing a parallel build?

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH v2 2/2] ppp-2.4.5: remove `DP = "-1"`

[Steffen Sledz]

On 04.07.2011 10:54, Paul Menzel wrote:
> Am Montag, den 04.07.2011, 10:31 +0200 schrieb Steffen Sledz:
>> Oe-core is using 2.4.5 and it works OK there.
>> 
>> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de> --- recipes/ppp/ppp_2.4.5.bb |    4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
>> 
>> diff --git a/recipes/ppp/ppp_2.4.5.bb b/recipes/ppp/ppp_2.4.5.bb index 883b695..faab816 100644 --- a/recipes/ppp/ppp_2.4.5.bb +++ b/recipes/ppp/ppp_2.4.5.bb @@ -3,9 +3,7 @@ DESCRIPTION = "Point-to-Point Protocol (PPP) daemon" HOMEPAGE = "http://samba.org/ppp/" DEPENDS = "libpcap" LICENSE = "BSD GPLv2" -PR = "r2" -# Not well tested -DEFAULT_PREFERENCE = "-1" +PR = "r3"
> 
> Is a bump of `PR` needed? The package content does not change, does it?

Not really. I'll revert that before pushing.

>> PARALLEL_MAKE = ""
> 
> Is the build still failing when doing a parallel build?

No idea. And not enough time to check it. Sorry.

Steffen

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058

Re: [PATCH v2 1/2] ppp-2.4.5: own package for PPPoL2TP plugin

[Steffen Sledz]

On 04.07.2011 10:52, Paul Menzel wrote:
> Am Montag, den 04.07.2011, 10:31 +0200 schrieb Steffen Sledz:
> 
> Could you please add the following to the commit message before you commit?
> 
> Adding that package fixes the following error message.
> 
> NOTE: package ppp-2.4.5-r1: task do_qa_staging: Started WARNING: the following files were installed but not shipped in any package: WARNING:   /usr/lib/pppd/2.4.5/pppol2tp.so WARNING:   /usr/lib/pppd/2.4.5/openl2tp.so

added

>> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de> --- recipes/ppp/ppp_2.4.5.bb |    6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)
>> 
>> diff --git a/recipes/ppp/ppp_2.4.5.bb b/recipes/ppp/ppp_2.4.5.bb index 2b6b6f7..883b695 100644 --- a/recipes/ppp/ppp_2.4.5.bb +++ b/recipes/ppp/ppp_2.4.5.bb @@ -3,7 +3,7 @@ DESCRIPTION = "Point-to-Point Protocol (PPP) daemon" HOMEPAGE = "http://samba.org/ppp/" DEPENDS = "libpcap" LICENSE = "BSD GPLv2" -PR = "r1" +PR = "r2" # Not well tested DEFAULT_PREFERENCE = "-1"
>> 
>> @@ -49,11 +49,12 @@ do_install_append () { }
>> 
>> CONFFILES_${PN} = "${sysconfdir}/ppp/pap-secrets ${sysconfdir}/ppp/chap-secrets ${sysconfdir}/ppp/options" -PACKAGES =+ "ppp-oa ppp-oe ppp-radius ppp-winbind ppp-minconn ppp-password ppp-tools" +PACKAGES =+ "ppp-oa ppp-l2tp ppp-oe ppp-radius ppp-winbind ppp-minconn ppp-password ppp-tools" FILES_${PN}        = "${sysconfdir} ${bindir} ${sbindir}/chat ${sbindir}/pppd" FILES_${PN}_nylon  = "${sysconfdir} ${bindir} ${sbindir}/chat ${sbindir}/pppd ${sbindir}/tdbread" FILES_${PN}-dbg += "${libdir}/pppd/${PV}/.debug" FILES_${PN}-oa       = "${libdir}/pppd/${PV}/pppoatm.so" +FILES_${PN}-l2tp     = "${libdir}/pppd/${PV}/pppol2tp.so ${libdir}/pppd/${PV}/openl2tp.so" FILES_${PN}-oe       = "${sbindir}/pppoe-discovery ${libdir}/pppd/${PV}/rp-pppoe.so" FILES_${PN}-radius   = "${libdir}/pppd/${PV}/radius.so ${libdir}/pppd/${PV}/radattr.so ${libdir}/pppd/${PV}/radrealms.so" FILES_${PN}-winbind  = "${libdir}/pppd/${PV}/winbind.so" @@ -61,6 +62,7 @@ FILES_${PN}-minconn  =
>> "${libdir}/pppd/${PV}/minconn.so" FILES_${PN}-password = "${libdir}/pppd/${PV}/pass*.so" FILES_${PN}-tools    = "${sbindir}/pppstats ${sbindir}/pppdump" DESCRIPTION_ppp-oa       = "Plugin for PPP needed for PPP-over-ATM" +DESCRIPTION_ppp-l2tp     = "Plugin for PPP needed for PPP-over-L2TP" DESCRIPTION_ppp-oe       = "Plugin for PPP needed for PPP-over-Ethernet" DESCRIPTION_ppp-radius   = "Plugin for PPP that are related to RADIUS" DESCRIPTION_ppp-winbind  = "Plugin for PPP to authenticate against Samba or Windows"
> 
> Putting these additions one line above would sort it alphabetically, would not it? If yes, it would be nice to fix this too before pushing the commit.

sorted

> Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>

and pushed

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058

Re: [PATCH v2 2/2] ppp-2.4.5: remove `DP = "-1"`

[Steffen Sledz]

On 04.07.2011 11:09, Steffen Sledz wrote:
> On 04.07.2011 10:54, Paul Menzel wrote:
>> Am Montag, den 04.07.2011, 10:31 +0200 schrieb Steffen Sledz:
>>> Oe-core is using 2.4.5 and it works OK there.
>>>
>>> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de> --- recipes/ppp/ppp_2.4.5.bb |    4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/recipes/ppp/ppp_2.4.5.bb b/recipes/ppp/ppp_2.4.5.bb index 883b695..faab816 100644 --- a/recipes/ppp/ppp_2.4.5.bb +++ b/recipes/ppp/ppp_2.4.5.bb @@ -3,9 +3,7 @@ DESCRIPTION = "Point-to-Point Protocol (PPP) daemon" HOMEPAGE = "http://samba.org/ppp/" DEPENDS = "libpcap" LICENSE = "BSD GPLv2" -PR = "r2" -# Not well tested -DEFAULT_PREFERENCE = "-1" +PR = "r3"
>>
>> Is a bump of `PR` needed? The package content does not change, does it?
> 
> Not really. I'll revert that before pushing.

pushed

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058