All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jinyoung Park <jinyoungp@nvidia.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Liam Girdwood <lrg@ti.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 1/2] regulator: aat2870: Fix the logic of checking if no id is matched in aat2870_get_regulator
Date: Wed, 6 Jul 2011 15:28:49 +0900	[thread overview]
Message-ID: <4E1400A1.4030104@nvidia.com> (raw)
In-Reply-To: <1309923277.26847.5.camel@phoenix>

Hi, Axel

  > In current implementation, the pointer ri is not NULL if no id is 
matched.
  > Fix it by checking i == ARRAY_SIZE(aat2870_regulators) if no id is 
matched.
You are right, the ri never be NULL in current implementation.
That's my mistake, I didn't find it when writing and verifying the driver.

Thanks,
Jin.

  parent reply	other threads:[~2011-07-06  6:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-06  3:34 [PATCH 1/2] regulator: aat2870: Fix the logic of checking if no id is matched in aat2870_get_regulator Axel Lin
2011-07-06  3:36 ` [PATCH 2/2] regulator: aat2870: Remove a redundant bitwise and operation Axel Lin
2011-07-06  6:28 ` Jinyoung Park [this message]
2011-07-06  6:44 ` [PATCH 1/2] regulator: aat2870: Fix the logic of checking if no id is matched in aat2870_get_regulator Mark Brown
2011-07-06 19:31 ` Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1400A1.4030104@nvidia.com \
    --to=jinyoungp@nvidia.com \
    --cc=axel.lin@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.