Re: [PATCH 1/2] regulator: aat2870: Fix the logic of checking if no id is matched in aat2870_get_regulator

[Liam Girdwood <lrg@ti.com>]

On 06/07/11 04:34, Axel Lin wrote:
> In current implementation, the pointer ri is not NULL if no id is matched.
> Fix it by checking i == ARRAY_SIZE(aat2870_regulators) if no id is matched.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
>  drivers/regulator/aat2870-regulator.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/regulator/aat2870-regulator.c b/drivers/regulator/aat2870-regulator.c
> index cd41045..11d1ab4 100644
> --- a/drivers/regulator/aat2870-regulator.c
> +++ b/drivers/regulator/aat2870-regulator.c
> @@ -159,7 +159,7 @@ static struct aat2870_regulator *aat2870_get_regulator(int id)
>  			break;
>  	}
>  
> -	if (!ri)
> +	if (i == ARRAY_SIZE(aat2870_regulators))
>  		return NULL;
>  
>  	ri->enable_addr = AAT2870_LDO_EN;

Can you resend both of these to Samuel with Mark's Ack as aat2870 went upstream via MFD.

Liam