All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: Vinod Koul <vkoul@infradead.org>,
	Shawn Guo <shawn.guo@linaro.org>,
	linux-mtd@lists.infradead.org,
	Wolfram Sang <w.sang@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dmaengine: mxs-dma: skip request_irq for NO_IRQ
Date: Thu, 7 Jul 2011 11:23:28 +0800	[thread overview]
Message-ID: <4E1526B0.5060308@freescale.com> (raw)
In-Reply-To: <20110707032441.GF4034@S2100-06.ap.freescale.net>

于 2011年07月07日 11:24, Shawn Guo 写道:
> On Thu, Jul 07, 2011 at 07:36:00AM +0530, Vinod Koul wrote:
>> On Thu, 2011-07-07 at 08:15 +0800, Shawn Guo wrote:
>>> On Thu, Jun 30, 2011 at 04:06:33PM +0800, Shawn Guo wrote:
>>>> In general, the mxs-dma users get separate irq for each channel,
>>>> but gpmi is special one which has only one irq shared by all gpmi
>>>> channels.  It causes mxs_dma channel allocation function fail for
>>>> all other gpmi channels except the first one calling into the
>>>> function.
>>>>
>>>> The patch gets request_irq call skipped for NO_IRQ case, and leaves
>>>> this gpmi specific quirk to gpmi driver to sort out.  It will fix
>>>> above problem if gpmi driver sets chan_irq as gpmi irq for only one
>>>> channel and NO_IRQ for all the rest channels.
>>>>
>>>> Signed-off-by: Shawn Guo<shawn.guo@linaro.org>
>>>> Cc: Vinod Koul<vinod.koul@intel.com>
>>>> ---
>>> Hi Vinod,
>>>
>>> Can you please take this patch?
>>>
>>> Regards,
>>> Shawn
>> Looks okay to me. Have queued it up and should show up in my tree latest by early next week.
>> I am on road, hence the delay...
>>
> No problem.  Thanks, Vinod.
>
thanks. I will submit the next GPMI version which will based this patch.

Best Regards
Huang Shijie

WARNING: multiple messages have this Message-ID (diff)
From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: mxs-dma: skip request_irq for NO_IRQ
Date: Thu, 7 Jul 2011 11:23:28 +0800	[thread overview]
Message-ID: <4E1526B0.5060308@freescale.com> (raw)
In-Reply-To: <20110707032441.GF4034@S2100-06.ap.freescale.net>

? 2011?07?07? 11:24, Shawn Guo ??:
> On Thu, Jul 07, 2011 at 07:36:00AM +0530, Vinod Koul wrote:
>> On Thu, 2011-07-07 at 08:15 +0800, Shawn Guo wrote:
>>> On Thu, Jun 30, 2011 at 04:06:33PM +0800, Shawn Guo wrote:
>>>> In general, the mxs-dma users get separate irq for each channel,
>>>> but gpmi is special one which has only one irq shared by all gpmi
>>>> channels.  It causes mxs_dma channel allocation function fail for
>>>> all other gpmi channels except the first one calling into the
>>>> function.
>>>>
>>>> The patch gets request_irq call skipped for NO_IRQ case, and leaves
>>>> this gpmi specific quirk to gpmi driver to sort out.  It will fix
>>>> above problem if gpmi driver sets chan_irq as gpmi irq for only one
>>>> channel and NO_IRQ for all the rest channels.
>>>>
>>>> Signed-off-by: Shawn Guo<shawn.guo@linaro.org>
>>>> Cc: Vinod Koul<vinod.koul@intel.com>
>>>> ---
>>> Hi Vinod,
>>>
>>> Can you please take this patch?
>>>
>>> Regards,
>>> Shawn
>> Looks okay to me. Have queued it up and should show up in my tree latest by early next week.
>> I am on road, hence the delay...
>>
> No problem.  Thanks, Vinod.
>
thanks. I will submit the next GPMI version which will based this patch.

Best Regards
Huang Shijie

  reply	other threads:[~2011-07-07  3:23 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-29  8:24 [PATCH v7 0/3] add the GPMI controller driver for IMX23/IMX28 Huang Shijie
2011-06-29  8:24 ` Huang Shijie
2011-06-29  8:24 ` Huang Shijie
2011-06-29  8:24   ` Huang Shijie
2011-06-29  8:24 ` [PATCH v7 1/3] MTD : add the common code for GPMI-NFC controller driver Huang Shijie
2011-06-29  8:24   ` Huang Shijie
2011-06-29 10:06   ` Wolfram Sang
2011-06-29 10:06     ` Wolfram Sang
2011-06-29 10:33     ` Wolfram Sang
2011-06-29 10:33       ` Wolfram Sang
2011-06-29 10:46       ` Huang Shijie
2011-06-29 10:46         ` Huang Shijie
2011-06-29 12:29         ` Wolfram Sang
2011-06-29 12:29           ` Wolfram Sang
2011-06-29 12:42           ` Russell King - ARM Linux
2011-06-29 12:42             ` Russell King - ARM Linux
2011-06-29 12:49             ` Wolfram Sang
2011-06-29 12:49               ` Wolfram Sang
2011-06-29 14:00           ` Shawn Guo
2011-06-29 14:00             ` Shawn Guo
2011-06-29 14:15             ` Wolfram Sang
2011-06-29 14:15               ` Wolfram Sang
2011-06-29 14:37               ` Shawn Guo
2011-06-29 14:37                 ` Shawn Guo
2011-06-30  4:46                 ` Wolfram Sang
2011-06-30  4:46                   ` Wolfram Sang
2011-06-30  5:28                   ` Shawn Guo
2011-06-30  5:28                     ` Shawn Guo
2011-06-30  8:06                     ` [PATCH] dmaengine: mxs-dma: skip request_irq for NO_IRQ Shawn Guo
2011-06-30  8:06                       ` Shawn Guo
2011-07-07  0:15                       ` Shawn Guo
2011-07-07  0:15                         ` Shawn Guo
2011-07-07  2:06                         ` Vinod Koul
2011-07-07  2:06                           ` Vinod Koul
2011-07-07  3:24                           ` Shawn Guo
2011-07-07  3:24                             ` Shawn Guo
2011-07-07  3:23                             ` Huang Shijie [this message]
2011-07-07  3:23                               ` Huang Shijie
2011-07-13 23:31                             ` Koul, Vinod
2011-07-13 23:31                               ` Koul, Vinod
2011-06-29 12:38   ` [PATCH v7 1/3] MTD : add the common code for GPMI-NFC controller driver Russell King - ARM Linux
2011-06-29 12:38     ` Russell King - ARM Linux
2011-06-30  1:50     ` Huang Shijie
2011-06-30  1:50       ` Huang Shijie
2011-06-30 10:27   ` Wolfram Sang
2011-06-30 10:27     ` Wolfram Sang
2011-06-30 17:04     ` Wolfram Sang
2011-06-30 17:04       ` Wolfram Sang
2011-07-01  5:41       ` Artem Bityutskiy
2011-07-01  5:41         ` Artem Bityutskiy
2011-07-01  6:47         ` Huang Shijie
2011-07-01  6:47           ` Huang Shijie
2011-06-29  8:24 ` [PATCH v7 2/3] MTD : add support for imx23 and imx28 Huang Shijie
2011-06-29  8:24   ` Huang Shijie
2011-06-29  8:24 ` [PATCH v7 3/3] MTD : add GPMI-NFC driver in the config and Makefile Huang Shijie
2011-06-29  8:24   ` Huang Shijie
2011-06-30 10:40 ` [PATCH v7 0/3] add the GPMI controller driver for IMX23/IMX28 Wolfram Sang
2011-06-30 10:40   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1526B0.5060308@freescale.com \
    --to=b32955@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=shawn.guo@freescale.com \
    --cc=shawn.guo@linaro.org \
    --cc=vkoul@infradead.org \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.