All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"w.sang@pengutronix.de" <w.sang@pengutronix.de>,
	"thierry.nolf.barco@gmail.com" <thierry.nolf.barco@gmail.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	"LW@karo-electronics.de" <LW@karo-electronics.de>
Subject: Re: reply: [PATCH v5 1/3] ARM: mxs: add GPMI-NFC support for	imx23/imx28
Date: Thu, 7 Jul 2011 16:56:01 +0800	[thread overview]
Message-ID: <4E1574A1.4050502@freescale.com> (raw)
In-Reply-To: <201107011109.27206.arnd@arndb.de>

Hi:
> On Friday 01 July 2011 10:57:40 Huang Shijie wrote:
>>>> It's annoying, but it really saves some lines.
>>> It would save more lines if you introduce the macros globally and
>>> convert all existing resource definitions ;-)
>> The origin code did not use any macros.
>> Some one suggested me to use macros.
>> So i used the macros.
>>
>> Do i have to drop the macros?
> Can you find out who made the suggestion? Let's first reach consensus
> about how we want to do these things in the future.
http://www.spinics.net/lists/arm-kernel/msg121384.html

Thanks to your comments.


Best Regards
Huang Shijie
> My opinion is that we should not have macros like these in any platform
> specific code: If the macros are a good idea, we should define them
> globally and let everyone use the same macros. If we decide not to have
> them in global code, it would be even worse to have them in specific
> platforms.
>
> 	Arnd
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

WARNING: multiple messages have this Message-ID (diff)
From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: reply: [PATCH v5 1/3] ARM: mxs: add GPMI-NFC support for	imx23/imx28
Date: Thu, 7 Jul 2011 16:56:01 +0800	[thread overview]
Message-ID: <4E1574A1.4050502@freescale.com> (raw)
In-Reply-To: <201107011109.27206.arnd@arndb.de>

Hi:
> On Friday 01 July 2011 10:57:40 Huang Shijie wrote:
>>>> It's annoying, but it really saves some lines.
>>> It would save more lines if you introduce the macros globally and
>>> convert all existing resource definitions ;-)
>> The origin code did not use any macros.
>> Some one suggested me to use macros.
>> So i used the macros.
>>
>> Do i have to drop the macros?
> Can you find out who made the suggestion? Let's first reach consensus
> about how we want to do these things in the future.
http://www.spinics.net/lists/arm-kernel/msg121384.html

Thanks to your comments.


Best Regards
Huang Shijie
> My opinion is that we should not have macros like these in any platform
> specific code: If the macros are a good idea, we should define them
> globally and let everyone use the same macros. If we decide not to have
> them in global code, it would be even worse to have them in specific
> platforms.
>
> 	Arnd
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

  reply	other threads:[~2011-07-07  8:56 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-30 16:12 reply: [PATCH v5 1/3] ARM: mxs: add GPMI-NFC support for imx23/imx28 Huang Shijie-B32955
2011-06-30 16:12 ` Huang Shijie-B32955
2011-06-30 22:29 ` Arnd Bergmann
2011-06-30 22:29   ` Arnd Bergmann
2011-07-01  6:44   ` Uwe Kleine-König
2011-07-01  6:44     ` Uwe Kleine-König
2011-07-01  8:57   ` Huang Shijie
2011-07-01  8:57     ` Huang Shijie
2011-07-01  9:09     ` Arnd Bergmann
2011-07-01  9:09       ` Arnd Bergmann
2011-07-07  8:56       ` Huang Shijie [this message]
2011-07-07  8:56         ` Huang Shijie
2011-07-07 15:57         ` Arnd Bergmann
2011-07-07 15:57           ` Arnd Bergmann
2011-07-07 20:48           ` reply: [PATCH v5 1/3] ARM: mxs: add GPMI-NFC support for?imx23/imx28 Uwe Kleine-König
2011-07-07 20:48             ` Uwe Kleine-König
2011-07-07 21:04             ` Arnd Bergmann
2011-07-07 21:04               ` Arnd Bergmann
2011-07-11 14:40               ` [PATCH] new helper to define common struct resource constructs Uwe Kleine-König
2011-07-11 14:40                 ` Uwe Kleine-König
2011-07-11 15:03                 ` [PATCH] ARM: mxc: use new helpers to define common struct resource entries Uwe Kleine-König
2011-07-11 15:03                   ` Uwe Kleine-König
2011-07-12 13:29                 ` [PATCH] new helper to define common struct resource constructs Arnd Bergmann
2011-07-12 13:29                   ` Arnd Bergmann
2011-07-12 13:29                   ` Arnd Bergmann
2011-07-12 17:13                   ` H Hartley Sweeten
2011-07-12 17:13                     ` H Hartley Sweeten
2011-07-12 18:31                     ` [PATCH v2] " Uwe Kleine-König
2011-07-12 18:31                       ` Uwe Kleine-König
2011-07-12 18:31                       ` Uwe Kleine-König
2011-07-13 21:18                   ` [PATCH] " Andrew Morton
2011-07-13 21:18                     ` Andrew Morton
2011-07-13 21:18                     ` Andrew Morton
2011-07-13 21:42                     ` Arnd Bergmann
2011-07-13 21:42                       ` Arnd Bergmann
2011-07-13 21:42                       ` Arnd Bergmann
2011-07-13 22:15                       ` H Hartley Sweeten
2011-07-13 22:15                         ` H Hartley Sweeten
2011-07-14  8:11                     ` [PATCH v3] " Uwe Kleine-König
2011-07-14  8:11                       ` Uwe Kleine-König
2011-07-14  8:11                       ` Uwe Kleine-König
2011-07-14 11:34                       ` Lothar Waßmann
2011-07-14 11:34                         ` Lothar Waßmann
2011-07-14 11:34                         ` Lothar Waßmann
2011-07-01 14:52     ` reply: [PATCH v5 1/3] ARM: mxs: add GPMI-NFC support for imx23/imx28 Arnd Bergmann
2011-07-01 14:52       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1574A1.4050502@freescale.com \
    --to=b32955@freescale.com \
    --cc=LW@karo-electronics.de \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    --cc=thierry.nolf.barco@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.