From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: linux-mmc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
Chris Ball <cjb@laptop.org>,
linux-arm-kernel@lists.infradead.org, patches@linaro.org
Subject: Re: [PATCH v2 2/3] mmc: sdhci-pltfm: dt device does not pass parent to sdhci_alloc_host
Date: Thu, 07 Jul 2011 15:33:15 +0400 [thread overview]
Message-ID: <4E15997B.6080804@mvista.com> (raw)
In-Reply-To: <1309879568-25837-3-git-send-email-shawn.guo@linaro.org>
Hello.
On 05-07-2011 19:26, Shawn Guo wrote:
> Neither platform based nor dt based device needs to pass the parent
> to sdhci_alloc_host. There is no difference between platform and dt
> on this point.
> The patch makes the change to pass device itself than its parent to
Maybe "rather than"?
> sdhci_alloc_host for dt case too. Otherwise the probe function of
> sdhci based drivers which is shared between platform and dt will
> fail on dt case.
> Signed-off-by: Shawn Guo<shawn.guo@linaro.org>
> Acked-by: Grant Likely<grant.likely@secretlab.ca>
> Cc: Chris Ball<cjb@laptop.org>
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] mmc: sdhci-pltfm: dt device does not pass parent to sdhci_alloc_host
Date: Thu, 07 Jul 2011 15:33:15 +0400 [thread overview]
Message-ID: <4E15997B.6080804@mvista.com> (raw)
In-Reply-To: <1309879568-25837-3-git-send-email-shawn.guo@linaro.org>
Hello.
On 05-07-2011 19:26, Shawn Guo wrote:
> Neither platform based nor dt based device needs to pass the parent
> to sdhci_alloc_host. There is no difference between platform and dt
> on this point.
> The patch makes the change to pass device itself than its parent to
Maybe "rather than"?
> sdhci_alloc_host for dt case too. Otherwise the probe function of
> sdhci based drivers which is shared between platform and dt will
> fail on dt case.
> Signed-off-by: Shawn Guo<shawn.guo@linaro.org>
> Acked-by: Grant Likely<grant.likely@secretlab.ca>
> Cc: Chris Ball<cjb@laptop.org>
WBR, Sergei
next prev parent reply other threads:[~2011-07-07 11:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 15:26 [PATCH v2 0/3] Add device tree probe for sdhci-esdhc-imx Shawn Guo
2011-07-05 15:26 ` Shawn Guo
2011-07-05 15:26 ` [PATCH v2 1/3] mmc: sdhci-esdhc-imx: get rid of the uses of cpu_is_mx() Shawn Guo
2011-07-05 15:26 ` Shawn Guo
2011-07-05 17:47 ` Grant Likely
2011-07-05 17:47 ` Grant Likely
2011-07-05 15:26 ` [PATCH v2 2/3] mmc: sdhci-pltfm: dt device does not pass parent to sdhci_alloc_host Shawn Guo
2011-07-05 15:26 ` Shawn Guo
2011-07-07 11:33 ` Sergei Shtylyov [this message]
2011-07-07 11:33 ` Sergei Shtylyov
2011-07-05 15:26 ` [PATCH v2 3/3] mmc: sdhci-esdhc-imx: add device tree probe support Shawn Guo
2011-07-05 15:26 ` Shawn Guo
2011-07-05 17:54 ` Grant Likely
2011-07-05 17:54 ` Grant Likely
2011-07-06 3:31 ` Shawn Guo
2011-07-06 3:31 ` Shawn Guo
2011-07-06 15:43 ` Shawn Guo
2011-07-06 15:43 ` Shawn Guo
2011-07-06 15:50 ` Grant Likely
2011-07-06 15:50 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E15997B.6080804@mvista.com \
--to=sshtylyov@mvista.com \
--cc=cjb@laptop.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.