* [PATCH 0/1] the fix to bug 1208
@ 2011-07-07 8:39 Dexuan Cui
2011-07-07 8:39 ` [PATCH 1/1] powertop: inherit update-alternatives and use a higher priority than busybox Dexuan Cui
2011-07-07 12:37 ` [PATCH 0/1] the fix to bug 1208 Richard Purdie
0 siblings, 2 replies; 10+ messages in thread
From: Dexuan Cui @ 2011-07-07 8:39 UTC (permalink / raw)
To: openembedded-core
The following changes since commit ad2363278f0ea86fcf3464f8f6073d3a3d06be63:
uclibc: Fix compilation in thumb mode (2011-07-02 00:02:24 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib dcui/distro
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dcui/distro
Dexuan Cui (1):
powertop: inherit update-alternatives and use a higher priority than
busybox
meta/recipes-kernel/powertop/powertop_1.13.bb | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
--
1.7.6
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 1/1] powertop: inherit update-alternatives and use a higher priority than busybox 2011-07-07 8:39 [PATCH 0/1] the fix to bug 1208 Dexuan Cui @ 2011-07-07 8:39 ` Dexuan Cui 2011-07-07 15:40 ` Tom Rini 2011-07-07 12:37 ` [PATCH 0/1] the fix to bug 1208 Richard Purdie 1 sibling, 1 reply; 10+ messages in thread From: Dexuan Cui @ 2011-07-07 8:39 UTC (permalink / raw) To: openembedded-core busybox-1.18.4 installs /bin/powertop and the powertop recipe installs /usr/bin/powertop. So, in PATH, if /bin appears before /usr/bin, we would run the version offered by busybox, which has a very limited function (e.g., no parameter is accepted) and this causes trouble to eclipse plugin. We can use update-alternatives for powertop with higher priority to resolve the issue. Fixes [YOCTO #1208] Signed-off-by: Dexuan Cui <dexuan.cui@intel.com> --- meta/recipes-kernel/powertop/powertop_1.13.bb | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/meta/recipes-kernel/powertop/powertop_1.13.bb b/meta/recipes-kernel/powertop/powertop_1.13.bb index dff4fcd..472a2bb 100644 --- a/meta/recipes-kernel/powertop/powertop_1.13.bb +++ b/meta/recipes-kernel/powertop/powertop_1.13.bb @@ -11,7 +11,7 @@ DEPENDS = "virtual/libintl ncurses" # powertop 1.13 needs lspci RDEPENDS_${PN} = "pciutils" -PR = "r0" +PR = "r1" SRC_URI = "http://www.lesswatts.org/projects/powertop/download/powertop-${PV}.tar.gz \ file://stub_out_the_ncurses_calls_in_dump_mode.patch" @@ -22,6 +22,12 @@ SRC_URI[sha256sum] = "2bc866089496877dd26d2d316ad5763ab8ecb5e28aefba44bc5d355dcd CFLAGS += "${LDFLAGS}" EXTRA_OEMAKE = "VERSION=\"${PV}\"" +inherit update-alternatives +ALTERNATIVE_NAME = "powertop" +ALTERNATIVE_PATH = "${bindir}/powertop" +ALTERNATIVE_LINK = "${base_bindir}/powertop" +ALTERNATIVE_PRIORITY = "100" + do_configure() { # We do not build ncurses with wide char support sed -i -e "s/lncursesw/lncurses/" ${S}/Makefile -- 1.7.6 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] powertop: inherit update-alternatives and use a higher priority than busybox 2011-07-07 8:39 ` [PATCH 1/1] powertop: inherit update-alternatives and use a higher priority than busybox Dexuan Cui @ 2011-07-07 15:40 ` Tom Rini 2011-07-08 1:40 ` Cui, Dexuan 0 siblings, 1 reply; 10+ messages in thread From: Tom Rini @ 2011-07-07 15:40 UTC (permalink / raw) To: openembedded-core On 07/07/2011 01:39 AM, Dexuan Cui wrote: > busybox-1.18.4 installs /bin/powertop and the powertop recipe installs > /usr/bin/powertop. So, in PATH, if /bin appears before /usr/bin, we would > run the version offered by busybox, which has a very limited function (e.g., > no parameter is accepted) and this causes trouble to eclipse plugin. > > We can use update-alternatives for powertop with higher priority to resolve > the issue. > > Fixes [YOCTO #1208] > > Signed-off-by: Dexuan Cui <dexuan.cui@intel.com> This fix seems a bit incomplete. Why is busybox putting powertop into /bin when it almost certainly belongs in /usr/bin like the real recipe was placing it. busybox needs a fix here too. -- Tom Rini Mentor Graphics Corporation ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] powertop: inherit update-alternatives and use a higher priority than busybox 2011-07-07 15:40 ` Tom Rini @ 2011-07-08 1:40 ` Cui, Dexuan 2011-07-08 7:25 ` Koen Kooi 0 siblings, 1 reply; 10+ messages in thread From: Cui, Dexuan @ 2011-07-08 1:40 UTC (permalink / raw) To: 'Patches and discussions about the oe-core layer' Tom Rini wrote: > On 07/07/2011 01:39 AM, Dexuan Cui wrote: >> busybox-1.18.4 installs /bin/powertop and the powertop recipe >> installs /usr/bin/powertop. So, in PATH, if /bin appears before >> /usr/bin, we would run the version offered by busybox, which has a >> very limited function (e.g., no parameter is accepted) and this >> causes trouble to eclipse plugin. >> >> We can use update-alternatives for powertop with higher priority to >> resolve the issue. >> >> Fixes [YOCTO #1208] >> >> Signed-off-by: Dexuan Cui <dexuan.cui@intel.com> > > This fix seems a bit incomplete. Why is busybox putting powertop into > /bin when it almost certainly belongs in /usr/bin like the real recipe > was placing it. busybox needs a fix here too. Thanks for the comment! I was hesitant about fixing busybox as I wasn't sure if it's worthy to make a patch to only fix the path for busybox. I don't know why busybox puts it into /bin. I think the best place may be /usr/sbin/. A little unluckily this patch to powertop has been already in poky master... So maybe we could try to fix the recipes in future, e.g., when upgrading them. Thanks, -- Dexuan ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] powertop: inherit update-alternatives and use a higher priority than busybox 2011-07-08 1:40 ` Cui, Dexuan @ 2011-07-08 7:25 ` Koen Kooi 2011-07-08 15:00 ` Richard Purdie 0 siblings, 1 reply; 10+ messages in thread From: Koen Kooi @ 2011-07-08 7:25 UTC (permalink / raw) To: Patches and discussions about the oe-core layer Cc: Patches and discussions about the oe-core layer Op 8 jul. 2011 om 02:40 heeft "Cui, Dexuan" <dexuan.cui@intel.com> het volgende geschreven: > Tom Rini wrote: >> On 07/07/2011 01:39 AM, Dexuan Cui wrote: >>> busybox-1.18.4 installs /bin/powertop and the powertop recipe >>> installs /usr/bin/powertop. So, in PATH, if /bin appears before >>> /usr/bin, we would run the version offered by busybox, which has a >>> very limited function (e.g., no parameter is accepted) and this >>> causes trouble to eclipse plugin. >>> >>> We can use update-alternatives for powertop with higher priority to >>> resolve the issue. >>> >>> Fixes [YOCTO #1208] >>> >>> Signed-off-by: Dexuan Cui <dexuan.cui@intel.com> >> >> This fix seems a bit incomplete. Why is busybox putting powertop into >> /bin when it almost certainly belongs in /usr/bin like the real recipe >> was placing it. busybox needs a fix here too. > Thanks for the comment! > I was hesitant about fixing busybox as I wasn't sure if it's worthy to make a patch to only fix the path for busybox. I don't know why busybox puts it into /bin. I think the best place may be /usr/sbin/. > A little unluckily this patch to powertop has been already in poky master... So maybe we could try to fix the recipes in future, e.g., when upgrading them. we should do the right thing in oe-core, the poky people can clean up on their own. > > Thanks, > -- Dexuan > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] powertop: inherit update-alternatives and use a higher priority than busybox 2011-07-08 7:25 ` Koen Kooi @ 2011-07-08 15:00 ` Richard Purdie 2011-07-08 15:57 ` Koen Kooi 0 siblings, 1 reply; 10+ messages in thread From: Richard Purdie @ 2011-07-08 15:00 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Fri, 2011-07-08 at 08:25 +0100, Koen Kooi wrote: > > Op 8 jul. 2011 om 02:40 heeft "Cui, Dexuan" <dexuan.cui@intel.com> het volgende geschreven: > > > Tom Rini wrote: > >> On 07/07/2011 01:39 AM, Dexuan Cui wrote: > >>> busybox-1.18.4 installs /bin/powertop and the powertop recipe > >>> installs /usr/bin/powertop. So, in PATH, if /bin appears before > >>> /usr/bin, we would run the version offered by busybox, which has a > >>> very limited function (e.g., no parameter is accepted) and this > >>> causes trouble to eclipse plugin. > >>> > >>> We can use update-alternatives for powertop with higher priority to > >>> resolve the issue. > >>> > >>> Fixes [YOCTO #1208] > >>> > >>> Signed-off-by: Dexuan Cui <dexuan.cui@intel.com> > >> > >> This fix seems a bit incomplete. Why is busybox putting powertop into > >> /bin when it almost certainly belongs in /usr/bin like the real recipe > >> was placing it. busybox needs a fix here too. > > Thanks for the comment! > > I was hesitant about fixing busybox as I wasn't sure if it's worthy > to make a patch to only fix the path for busybox. I don't know why > busybox puts it into /bin. I think the best place may be /usr/sbin/. > > A little unluckily this patch to powertop has been already in poky > master... So maybe we could try to fix the recipes in future, e.g., > when upgrading them. > > we should do the right thing in oe-core, the poky people can clean up on their own. I don't think anyone is suggesting we shouldn't do the right thing in OE-Core? :) I merged the original patch on the grounds that its was an improvement to the situation. We've identified a better improvement so can someone please send me the patch and I'll likely merge that too. FWIW, I agree that powertop should really be under /usr/... Cheers, Richard ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] powertop: inherit update-alternatives and use a higher priority than busybox 2011-07-08 15:00 ` Richard Purdie @ 2011-07-08 15:57 ` Koen Kooi 2011-07-08 16:43 ` Richard Purdie 0 siblings, 1 reply; 10+ messages in thread From: Koen Kooi @ 2011-07-08 15:57 UTC (permalink / raw) To: Patches and discussions about the oe-core layer Cc: Patches and discussions about the oe-core layer Op 8 jul. 2011 om 16:00 heeft Richard Purdie <richard.purdie@linuxfoundation.org> het volgende geschreven: > On Fri, 2011-07-08 at 08:25 +0100, Koen Kooi wrote: >> >> Op 8 jul. 2011 om 02:40 heeft "Cui, Dexuan" <dexuan.cui@intel.com> het volgende geschreven: >> >>> Tom Rini wrote: >>>> On 07/07/2011 01:39 AM, Dexuan Cui wrote: >>>>> busybox-1.18.4 installs /bin/powertop and the powertop recipe >>>>> installs /usr/bin/powertop. So, in PATH, if /bin appears before >>>>> /usr/bin, we would run the version offered by busybox, which has a >>>>> very limited function (e.g., no parameter is accepted) and this >>>>> causes trouble to eclipse plugin. >>>>> >>>>> We can use update-alternatives for powertop with higher priority to >>>>> resolve the issue. >>>>> >>>>> Fixes [YOCTO #1208] >>>>> >>>>> Signed-off-by: Dexuan Cui <dexuan.cui@intel.com> >>>> >>>> This fix seems a bit incomplete. Why is busybox putting powertop into >>>> /bin when it almost certainly belongs in /usr/bin like the real recipe >>>> was placing it. busybox needs a fix here too. >>> Thanks for the comment! >>> I was hesitant about fixing busybox as I wasn't sure if it's worthy >> to make a patch to only fix the path for busybox. I don't know why >> busybox puts it into /bin. I think the best place may be /usr/sbin/. >>> A little unluckily this patch to powertop has been already in poky >> master... So maybe we could try to fix the recipes in future, e.g., >> when upgrading them. >> >> we should do the right thing in oe-core, the poky people can clean up on their own. > > I don't think anyone is suggesting we shouldn't do the right thing in > OE-Core? :) > > I merged the original patch on the grounds that its was an improvement > to the situation. We've identified a better improvement so can someone > please send me the patch and I'll likely merge that too. the email makes it seem that the patch was merged into poky, but not oe-core. When reading it like that the proposal involved merging the 'incomplete' patch for the sake of keeping poky and oe-core in sync > > FWIW, I agree that powertop should really be under /usr/... > > Cheers, > > Richard > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] powertop: inherit update-alternatives and use a higher priority than busybox 2011-07-08 15:57 ` Koen Kooi @ 2011-07-08 16:43 ` Richard Purdie 2011-07-08 20:45 ` Koen Kooi 0 siblings, 1 reply; 10+ messages in thread From: Richard Purdie @ 2011-07-08 16:43 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Fri, 2011-07-08 at 16:57 +0100, Koen Kooi wrote: > > Op 8 jul. 2011 om 16:00 heeft Richard Purdie <richard.purdie@linuxfoundation.org> het volgende geschreven: > > > On Fri, 2011-07-08 at 08:25 +0100, Koen Kooi wrote: > >> > >> Op 8 jul. 2011 om 02:40 heeft "Cui, Dexuan" <dexuan.cui@intel.com> het volgende geschreven: > >> > >>> Tom Rini wrote: > >>>> On 07/07/2011 01:39 AM, Dexuan Cui wrote: > >>>>> busybox-1.18.4 installs /bin/powertop and the powertop recipe > >>>>> installs /usr/bin/powertop. So, in PATH, if /bin appears before > >>>>> /usr/bin, we would run the version offered by busybox, which has a > >>>>> very limited function (e.g., no parameter is accepted) and this > >>>>> causes trouble to eclipse plugin. > >>>>> > >>>>> We can use update-alternatives for powertop with higher priority to > >>>>> resolve the issue. > >>>>> > >>>>> Fixes [YOCTO #1208] > >>>>> > >>>>> Signed-off-by: Dexuan Cui <dexuan.cui@intel.com> > >>>> > >>>> This fix seems a bit incomplete. Why is busybox putting powertop into > >>>> /bin when it almost certainly belongs in /usr/bin like the real recipe > >>>> was placing it. busybox needs a fix here too. > >>> Thanks for the comment! > >>> I was hesitant about fixing busybox as I wasn't sure if it's worthy > >> to make a patch to only fix the path for busybox. I don't know why > >> busybox puts it into /bin. I think the best place may be /usr/sbin/. > >>> A little unluckily this patch to powertop has been already in poky > >> master... So maybe we could try to fix the recipes in future, e.g., > >> when upgrading them. > >> > >> we should do the right thing in oe-core, the poky people can clean up on their own. > > > > I don't think anyone is suggesting we shouldn't do the right thing in > > OE-Core? :) > > > > I merged the original patch on the grounds that its was an improvement > > to the situation. We've identified a better improvement so can someone > > please send me the patch and I'll likely merge that too. > > the email makes it seem that the patch was merged into poky, but not > oe-core. When reading it like that the proposal involved merging the > 'incomplete' patch for the sake of keeping poky and oe-core in sync The OE-Core component of Poky always stays in sync now... Cheers, Richard ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] powertop: inherit update-alternatives and use a higher priority than busybox 2011-07-08 16:43 ` Richard Purdie @ 2011-07-08 20:45 ` Koen Kooi 0 siblings, 0 replies; 10+ messages in thread From: Koen Kooi @ 2011-07-08 20:45 UTC (permalink / raw) To: Patches and discussions about the oe-core layer Op 8 jul. 2011 om 18:43 heeft Richard Purdie <richard.purdie@linuxfoundation.org> het volgende geschreven: > On Fri, 2011-07-08 at 16:57 +0100, Koen Kooi wrote: >> >> Op 8 jul. 2011 om 16:00 heeft Richard Purdie <richard.purdie@linuxfoundation.org> het volgende geschreven: >> >>> On Fri, 2011-07-08 at 08:25 +0100, Koen Kooi wrote: >>>> >>>> Op 8 jul. 2011 om 02:40 heeft "Cui, Dexuan" <dexuan.cui@intel.com> het volgende geschreven: >>>> >>>>> Tom Rini wrote: >>>>>> On 07/07/2011 01:39 AM, Dexuan Cui wrote: >>>>>>> busybox-1.18.4 installs /bin/powertop and the powertop recipe >>>>>>> installs /usr/bin/powertop. So, in PATH, if /bin appears before >>>>>>> /usr/bin, we would run the version offered by busybox, which has a >>>>>>> very limited function (e.g., no parameter is accepted) and this >>>>>>> causes trouble to eclipse plugin. >>>>>>> >>>>>>> We can use update-alternatives for powertop with higher priority to >>>>>>> resolve the issue. >>>>>>> >>>>>>> Fixes [YOCTO #1208] >>>>>>> >>>>>>> Signed-off-by: Dexuan Cui <dexuan.cui@intel.com> >>>>>> >>>>>> This fix seems a bit incomplete. Why is busybox putting powertop into >>>>>> /bin when it almost certainly belongs in /usr/bin like the real recipe >>>>>> was placing it. busybox needs a fix here too. >>>>> Thanks for the comment! >>>>> I was hesitant about fixing busybox as I wasn't sure if it's worthy >>>> to make a patch to only fix the path for busybox. I don't know why >>>> busybox puts it into /bin. I think the best place may be /usr/sbin/. >>>>> A little unluckily this patch to powertop has been already in poky >>>> master... So maybe we could try to fix the recipes in future, e.g., >>>> when upgrading them. >>>> >>>> we should do the right thing in oe-core, the poky people can clean up on their own. >>> >>> I don't think anyone is suggesting we shouldn't do the right thing in >>> OE-Core? :) >>> >>> I merged the original patch on the grounds that its was an improvement >>> to the situation. We've identified a better improvement so can someone >>> please send me the patch and I'll likely merge that too. >> >> the email makes it seem that the patch was merged into poky, but not >> oe-core. When reading it like that the proposal involved merging the >> 'incomplete' patch for the sake of keeping poky and oe-core in sync > > The OE-Core component of Poky always stays in sync now... I realized that later, I'm way too tired to think properly. sorry about the fuss > > Cheers, > > Richard > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/1] the fix to bug 1208 2011-07-07 8:39 [PATCH 0/1] the fix to bug 1208 Dexuan Cui 2011-07-07 8:39 ` [PATCH 1/1] powertop: inherit update-alternatives and use a higher priority than busybox Dexuan Cui @ 2011-07-07 12:37 ` Richard Purdie 1 sibling, 0 replies; 10+ messages in thread From: Richard Purdie @ 2011-07-07 12:37 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Thu, 2011-07-07 at 16:39 +0800, Dexuan Cui wrote: > The following changes since commit ad2363278f0ea86fcf3464f8f6073d3a3d06be63: > > uclibc: Fix compilation in thumb mode (2011-07-02 00:02:24 +0100) > > are available in the git repository at: > git://git.pokylinux.org/poky-contrib dcui/distro > http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dcui/distro > > Dexuan Cui (1): > powertop: inherit update-alternatives and use a higher priority than > busybox Merged to master, thanks. Richard ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2011-07-08 20:49 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-07-07 8:39 [PATCH 0/1] the fix to bug 1208 Dexuan Cui 2011-07-07 8:39 ` [PATCH 1/1] powertop: inherit update-alternatives and use a higher priority than busybox Dexuan Cui 2011-07-07 15:40 ` Tom Rini 2011-07-08 1:40 ` Cui, Dexuan 2011-07-08 7:25 ` Koen Kooi 2011-07-08 15:00 ` Richard Purdie 2011-07-08 15:57 ` Koen Kooi 2011-07-08 16:43 ` Richard Purdie 2011-07-08 20:45 ` Koen Kooi 2011-07-07 12:37 ` [PATCH 0/1] the fix to bug 1208 Richard Purdie
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.