[PATCH-proposal] fix vlc building (-fPIC error) by patching live555 recipe

[PATCH-proposal] fix vlc building (-fPIC error) by patching live555 recipe

[Sylvain Paré]

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

Hi,

Attached a patch to fix this kind of error while building VLC :

libliveMedia.a: relocation R_ARM_MOVW_ABS_NC against `a local symbol' can
not be used when making a shared object; recompile with -fPIC
|
/home/sylvain/dev/SHR-Build/shr-unstable/tmp/sysroots/armv7a-oe-linux-gnueabi/usr/lib/libliveMedia.a:
could not read symbols: Bad value
| collect2: ld returned 1 exit status

Let me know if it is not good enough, and if the patch is accepted.

Thanks by advance.

Regards,

Sylvain Paré (aka GarthPS)

[-- Attachment #2: fix-fPIC-error-onbuilding-vlc.patch --]
[-- Type: application/octet-stream, Size: 445 bytes --]

diff --git a/recipes/live555/live555.inc b/recipes/live555/live555.inc
index 14e97bb..7951b46 100644
--- a/recipes/live555/live555.inc
+++ b/recipes/live555/live555.inc
@@ -18,7 +18,9 @@ TARGET_CC_ARCH += "${LDFLAGS}"
 
 do_configure() {
 	cp ${WORKDIR}/config.linux-cross .
+        echo "COMPILE_OPTS+=" -fPIC "" >> config.linux-cross
 	./genMakefiles linux-cross
+        find . -name 'Makefile' -exec fix-makefile {} \;
 }
 
 do_compile() {

Re: [PATCH-proposal] fix vlc building (-fPIC error) by patching live555 recipe

[Denis 'GNUtoo' Carikli]

>Let me know if it is not good enough, and if the patch is accepted.
hi,
First thanks for the patch, unfortunately it's in the wrong format, you should 
rather use git (git add + git commit + git format-patch + git-send-email ) as 
described in the patch sending guide:
http://www.openembedded.org/index.php/How_to_submit_a_patch_for_dummies

Then I wonder what is fix-makefile.

I'd like vlc to get fixed. Thanks again for caring about vlc.

Denis.

Re: [PATCH-proposal] fix vlc building (-fPIC error) by patching live555 recipe

[Sylvain Paré]

[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]

Hi,

Attached the new patch. is this ok for you this time ?
About the fix-makefile I don't know and did not take the time, just followed
this http://forum.videolan.org/viewtopic.php?f=13&t=46465
I just know that it works for me :)

So with this patch vlc will be build wilth live555 support. Before that if
live555 was present(built without fPIC flag by default) vlc did not build
successfully
But if you did clean live555 then vlc build process would detect it and then
build successfully deactivating live555 support (that is why I did succeed
to build the last time without understanding it)

With pleasure!

A 1.1.10 recipe could be cool too but It was above my skills/time for now.(
had some compile error and did not took the time to fix it)

Sylvain

2011/7/6 Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>

> >Let me know if it is not good enough, and if the patch is accepted.
> hi,
> First thanks for the patch, unfortunately it's in the wrong format, you
> should
> rather use git (git add + git commit + git format-patch + git-send-email )
> as
> described in the patch sending guide:
> http://www.openembedded.org/index.php/How_to_submit_a_patch_for_dummies
>
> Then I wonder what is fix-makefile.
>
> I'd like vlc to get fixed. Thanks again for caring about vlc.
>
> Denis.
>

[-- Attachment #2: 0001-live555-recipe-added-fPIC-flag-need-by-VLC-to-build-.patch --]
[-- Type: application/octet-stream, Size: 982 bytes --]

From 2506aca53ecdb49bdc233c77b1e4ce8b39204611 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sylvain=20'GarthPS'=20Par=C3=A9?= <sylvain.pare@gmail.com>
Date: Wed, 6 Jul 2011 22:15:43 +0200
Subject: [PATCH] live555 recipe: added -fPIC flag need by VLC to build with live555 support
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Sylvain 'GarthPS' Paré <sylvain.pare@gmail.com>
---
 recipes/live555/live555.inc |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/recipes/live555/live555.inc b/recipes/live555/live555.inc
index 14e97bb..7951b46 100644
--- a/recipes/live555/live555.inc
+++ b/recipes/live555/live555.inc
@@ -18,7 +18,9 @@ TARGET_CC_ARCH += "${LDFLAGS}"
 
 do_configure() {
 	cp ${WORKDIR}/config.linux-cross .
+        echo "COMPILE_OPTS+=" -fPIC "" >> config.linux-cross
 	./genMakefiles linux-cross
+        find . -name 'Makefile' -exec fix-makefile {} \;
 }
 
 do_compile() {
-- 
1.7.4.1

Re: [PATCH-proposal] fix vlc building (-fPIC error) by patching live555 recipe

[Sylvain Paré]

[-- Attachment #1: Type: text/plain, Size: 976 bytes --]

Patch attached. removed unneeded line


From 9e01ea60bf7790f1250ef24a317507e255f3f947 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sylvain=20'GarthPS'=20Par=C3=A9?= <sylvain.pare@gmail.com>
Date: Wed, 6 Jul 2011 23:36:14 +0200
Subject: [PATCH] live555 recipe: added -fPIC flag need by VLC to build with
live555 support
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Sylvain 'GarthPS' Paré <sylvain.pare@gmail.com>
---
 recipes/live555/live555.inc |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/recipes/live555/live555.inc b/recipes/live555/live555.inc
index 14e97bb..6de57cb 100644
--- a/recipes/live555/live555.inc
+++ b/recipes/live555/live555.inc
@@ -18,6 +18,7 @@ TARGET_CC_ARCH += "${LDFLAGS}"

 do_configure() {
     cp ${WORKDIR}/config.linux-cross .
+    echo "COMPILE_OPTS+=" -fPIC "" >> config.linux-cross
     ./genMakefiles linux-cross
 }

-- 
1.7.4.1

[-- Attachment #2: 0001-live555-recipe-added-fPIC-flag-need-by-VLC-to-build-.patch --]
[-- Type: application/octet-stream, Size: 900 bytes --]

From 9e01ea60bf7790f1250ef24a317507e255f3f947 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sylvain=20'GarthPS'=20Par=C3=A9?= <sylvain.pare@gmail.com>
Date: Wed, 6 Jul 2011 23:36:14 +0200
Subject: [PATCH] live555 recipe: added -fPIC flag need by VLC to build with live555 support
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Sylvain 'GarthPS' Paré <sylvain.pare@gmail.com>
---
 recipes/live555/live555.inc |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/recipes/live555/live555.inc b/recipes/live555/live555.inc
index 14e97bb..6de57cb 100644
--- a/recipes/live555/live555.inc
+++ b/recipes/live555/live555.inc
@@ -18,6 +18,7 @@ TARGET_CC_ARCH += "${LDFLAGS}"
 
 do_configure() {
 	cp ${WORKDIR}/config.linux-cross .
+	echo "COMPILE_OPTS+=" -fPIC "" >> config.linux-cross
 	./genMakefiles linux-cross
 }
 
-- 
1.7.4.1

Re: [PATCH-proposal] fix vlc building (-fPIC error) by patching live555 recipe

[Sylvain Paré]

[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]

ok sorry for the noise.. last time with INC_PR updated

From d8eaabb63088dc68b7bba3f5a6ac6a31e65a36e6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sylvain=20'GarthPS'=20Par=C3=A9?= <sylvain.pare@gmail.com>
Date: Wed, 6 Jul 2011 23:53:42 +0200
Subject: [PATCH] live555 recipe: added -fPIC flag need by VLC to build with
live555 support
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Sylvain 'GarthPS' Paré <sylvain.pare@gmail.com>
---
 recipes/live555/live555.inc |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/recipes/live555/live555.inc b/recipes/live555/live555.inc
index 14e97bb..f1e21dc 100644
--- a/recipes/live555/live555.inc
+++ b/recipes/live555/live555.inc
@@ -7,7 +7,7 @@ HOMEPAGE = "http://live.com/"
 LICENSE = "LGPL"
 SECTION = "devel"

-INC_PR = "r1"
+INC_PR = "r2"

 URLV =
"${@bb.data.getVar('PV',d,1)[0:4]}.${@bb.data.getVar('PV',d,1)[4:6]}.${@bb.data.getVar('PV',d,1)[6:8]}"
 SRC_URI = "http://www.live555.com/liveMedia/public/live.${URLV}.tar.gz \
@@ -18,6 +18,7 @@ TARGET_CC_ARCH += "${LDFLAGS}"

 do_configure() {
     cp ${WORKDIR}/config.linux-cross .
+    echo "COMPILE_OPTS+=" -fPIC "" >> config.linux-cross
     ./genMakefiles linux-cross
 }

-- 
1.7.4.1

[-- Attachment #2: 0001-live555-recipe-added-fPIC-flag-need-by-VLC-to-build-.patch --]
[-- Type: application/octet-stream, Size: 1205 bytes --]

From d8eaabb63088dc68b7bba3f5a6ac6a31e65a36e6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sylvain=20'GarthPS'=20Par=C3=A9?= <sylvain.pare@gmail.com>
Date: Wed, 6 Jul 2011 23:53:42 +0200
Subject: [PATCH] live555 recipe: added -fPIC flag need by VLC to build with live555 support
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Sylvain 'GarthPS' Paré <sylvain.pare@gmail.com>
---
 recipes/live555/live555.inc |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/recipes/live555/live555.inc b/recipes/live555/live555.inc
index 14e97bb..f1e21dc 100644
--- a/recipes/live555/live555.inc
+++ b/recipes/live555/live555.inc
@@ -7,7 +7,7 @@ HOMEPAGE = "http://live.com/"
 LICENSE = "LGPL"
 SECTION = "devel"
 
-INC_PR = "r1"
+INC_PR = "r2"
 
 URLV = "${@bb.data.getVar('PV',d,1)[0:4]}.${@bb.data.getVar('PV',d,1)[4:6]}.${@bb.data.getVar('PV',d,1)[6:8]}"
 SRC_URI = "http://www.live555.com/liveMedia/public/live.${URLV}.tar.gz \
@@ -18,6 +18,7 @@ TARGET_CC_ARCH += "${LDFLAGS}"
 
 do_configure() {
 	cp ${WORKDIR}/config.linux-cross .
+	echo "COMPILE_OPTS+=" -fPIC "" >> config.linux-cross
 	./genMakefiles linux-cross
 }
 
-- 
1.7.4.1

Re: [PATCH-proposal] fix vlc building (-fPIC error) by patching live555 recipe

[Khem Raj]

On 07/06/2011 02:44 PM, Sylvain Paré wrote:
> Patch attached. removed unneeded line
>
>
>  From 9e01ea60bf7790f1250ef24a317507e255f3f947 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Sylvain=20'GarthPS'=20Par=C3=A9?=<sylvain.pare@gmail.com>
> Date: Wed, 6 Jul 2011 23:36:14 +0200
> Subject: [PATCH] live555 recipe: added -fPIC flag need by VLC to build with
> live555 support
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> Signed-off-by: Sylvain 'GarthPS' Paré<sylvain.pare@gmail.com>
> ---
>   recipes/live555/live555.inc |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/recipes/live555/live555.inc b/recipes/live555/live555.inc
> index 14e97bb..6de57cb 100644
> --- a/recipes/live555/live555.inc
> +++ b/recipes/live555/live555.inc
> @@ -18,6 +18,7 @@ TARGET_CC_ARCH += "${LDFLAGS}"
>
>   do_configure() {
>       cp ${WORKDIR}/config.linux-cross .
> +    echo "COMPILE_OPTS+=" -fPIC "">>  config.linux-cross

Did you try adding -fPIC to CFLAGS

>       ./genMakefiles linux-cross
>   }
>
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Re: [PATCH-proposal] fix vlc building (-fPIC error) by patching live555 recipe

[Sylvain Paré]

Direclty in the recipe yeah and it did not work. But I have adoubt about
testing it directly in the config.linux-cross file..
Why ? (because as C_FLAGS =               $(COMPILE_OPTS) ...) in this same
file


2011/7/8 Khem Raj <raj.khem@gmail.com>

> On 07/06/2011 02:44 PM, Sylvain Paré wrote:
>
>> Patch attached. removed unneeded line
>>
>>
>>  From 9e01ea60bf7790f1250ef24a317507**e255f3f947 Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Sylvain=20'GarthPS'=**20Par=C3=A9?=<sylvain.pare@**
>> gmail.com <sylvain.pare@gmail.com>>
>> Date: Wed, 6 Jul 2011 23:36:14 +0200
>> Subject: [PATCH] live555 recipe: added -fPIC flag need by VLC to build
>> with
>> live555 support
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
>> Signed-off-by: Sylvain 'GarthPS' Paré<sylvain.pare@gmail.com>
>> ---
>>  recipes/live555/live555.inc |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/recipes/live555/live555.inc b/recipes/live555/live555.inc
>> index 14e97bb..6de57cb 100644
>> --- a/recipes/live555/live555.inc
>> +++ b/recipes/live555/live555.inc
>> @@ -18,6 +18,7 @@ TARGET_CC_ARCH += "${LDFLAGS}"
>>
>>  do_configure() {
>>      cp ${WORKDIR}/config.linux-cross .
>> +    echo "COMPILE_OPTS+=" -fPIC "">>  config.linux-cross
>>
>
> Did you try adding -fPIC to CFLAGS
>
>       ./genMakefiles linux-cross
>>  }
>>
>>
>>
>>
>> ______________________________**_________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.**openembedded.org<Openembedded-devel@lists.openembedded.org>
>> http://lists.linuxtogo.org/**cgi-bin/mailman/listinfo/**
>> openembedded-devel<http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel>
>>
>
>
> ______________________________**_________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.**openembedded.org<Openembedded-devel@lists.openembedded.org>
> http://lists.linuxtogo.org/**cgi-bin/mailman/listinfo/**openembedded-devel<http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel>
>