From: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 5/6] dt: add empty of_property_read_u32[_array] for non-dt
Date: Fri, 08 Jul 2011 07:33:53 -0500 [thread overview]
Message-ID: <4E16F931.1050109@gmail.com> (raw)
In-Reply-To: <1310113654-25887-6-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Shawn,
On 07/08/2011 03:27 AM, Shawn Guo wrote:
> The patch adds empty functions of_property_read_u32 and
> of_property_read_u32_array for non-dt build, so that drivers
> migrating to dt can save some '#ifdef CONFIG_OF'.
>
> Signed-off-by: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Cc: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
> Cc: Thomas Abraham <thomas.abraham-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> ---
> include/linux/of.h | 15 +++++++++++++++
> 1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 4761046..4ef636e 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -255,5 +255,20 @@ static inline bool of_have_populated_dt(void)
> return false;
> }
>
> +static inline int of_property_read_u32_array(const struct device_node *np,
> + char *propname,
> + u32 *out_values,
> + size_t sz)
> +{
> + return -ENOSYS;
> +}
> +
> +static inline int of_property_read_u32(const struct device_node *np,
> + char *propname,
> + u32 *out_value)
> +{
> + return -ENOSYS;
> +}
> +
> #endif /* CONFIG_OF */
> #endif /* _LINUX_OF_H */
You should include the string read function as well for completeness.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] dt: add empty of_property_read_u32[_array] for non-dt
Date: Fri, 08 Jul 2011 07:33:53 -0500 [thread overview]
Message-ID: <4E16F931.1050109@gmail.com> (raw)
In-Reply-To: <1310113654-25887-6-git-send-email-shawn.guo@linaro.org>
Shawn,
On 07/08/2011 03:27 AM, Shawn Guo wrote:
> The patch adds empty functions of_property_read_u32 and
> of_property_read_u32_array for non-dt build, so that drivers
> migrating to dt can save some '#ifdef CONFIG_OF'.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Thomas Abraham <thomas.abraham@linaro.org>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> ---
> include/linux/of.h | 15 +++++++++++++++
> 1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 4761046..4ef636e 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -255,5 +255,20 @@ static inline bool of_have_populated_dt(void)
> return false;
> }
>
> +static inline int of_property_read_u32_array(const struct device_node *np,
> + char *propname,
> + u32 *out_values,
> + size_t sz)
> +{
> + return -ENOSYS;
> +}
> +
> +static inline int of_property_read_u32(const struct device_node *np,
> + char *propname,
> + u32 *out_value)
> +{
> + return -ENOSYS;
> +}
> +
> #endif /* CONFIG_OF */
> #endif /* _LINUX_OF_H */
You should include the string read function as well for completeness.
Rob
next prev parent reply other threads:[~2011-07-08 12:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 8:27 [PATCH 0/6] Add device tree support for imx spi driver Shawn Guo
2011-07-08 8:27 ` Shawn Guo
[not found] ` <1310113654-25887-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-07-08 8:27 ` [PATCH 1/6] ARM: mxc: remove unnecessary header file inclusion from gpio.h Shawn Guo
2011-07-08 8:27 ` Shawn Guo
2011-07-08 8:27 ` [PATCH 2/6] spi/imx: use soc name in spi device type naming scheme Shawn Guo
2011-07-08 8:27 ` Shawn Guo
[not found] ` <1310113654-25887-3-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-07-08 10:58 ` Sascha Hauer
2011-07-08 10:58 ` Sascha Hauer
[not found] ` <20110708105851.GF6069-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-07-09 7:00 ` Shawn Guo
2011-07-09 7:00 ` Shawn Guo
[not found] ` <20110709070001.GE13962-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-07-11 6:32 ` Sascha Hauer
2011-07-11 6:32 ` Sascha Hauer
2011-07-08 8:27 ` [PATCH 3/6] spi/imx: copy gpio number passed by platform data into driver private data Shawn Guo
2011-07-08 8:27 ` Shawn Guo
2011-07-08 8:27 ` [PATCH 4/6] dt: add helper function to read u32 arrays Shawn Guo
2011-07-08 8:27 ` Shawn Guo
2011-07-08 8:27 ` [PATCH 5/6] dt: add empty of_property_read_u32[_array] for non-dt Shawn Guo
2011-07-08 8:27 ` Shawn Guo
[not found] ` <1310113654-25887-6-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-07-08 12:33 ` Rob Herring [this message]
2011-07-08 12:33 ` Rob Herring
2011-07-08 18:49 ` Grant Likely
2011-07-08 18:49 ` Grant Likely
2011-07-08 8:27 ` [PATCH 6/6] spi/imx: add device tree probe support Shawn Guo
2011-07-08 8:27 ` Shawn Guo
2011-07-08 19:01 ` [PATCH 0/6] Add device tree support for imx spi driver Grant Likely
2011-07-08 19:01 ` Grant Likely
[not found] ` <20110708190142.GD9070-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2011-07-09 6:44 ` Shawn Guo
2011-07-09 6:44 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E16F931.1050109@gmail.com \
--to=robherring2-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.