From: troy.kisky@boundarydevices.com (Troy Kisky)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net/fec: gasket needs to be enabled for some i.mx
Date: Fri, 08 Jul 2011 11:38:09 -0700 [thread overview]
Message-ID: <4E174E91.2090609@boundarydevices.com> (raw)
In-Reply-To: <20110708101810.GE6069@pengutronix.de>
On 7/8/2011 3:18 AM, Sascha Hauer wrote:
> On Fri, Jul 01, 2011 at 06:11:22PM +0800, Shawn Guo wrote:
>> On the recent i.mx (mx25/50/53), there is a gasket inside fec
>> controller which needs to be enabled no matter phy works in MII
>> or RMII mode.
>>
>> The current code enables the gasket only when phy interface is RMII.
>> It's broken when the driver works with a MII phy. The patch uses
>> platform_device_id to distinguish the SoCs that have the gasket and
>> enables it on these SoCs for both MII and RMII mode.
>>
>> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
While you're making changes, you can change this to
Reported-by: Troy Kisky
Thanks
>> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
>> Cc: David S. Miller <davem@davemloft.net>
>> Cc: Sascha Hauer <s.hauer@pengutronix.de>
>> ---
>> arch/arm/mach-imx/clock-imx25.c | 2 +-
>> arch/arm/mach-imx/clock-imx27.c | 2 +-
>> arch/arm/mach-imx/clock-imx35.c | 2 +-
>> arch/arm/mach-mx5/clock-mx51-mx53.c | 4 +-
>> arch/arm/plat-mxc/devices/platform-fec.c | 17 ++++++++-------
>> arch/arm/plat-mxc/include/mach/devices-common.h | 1 +
>> drivers/net/fec.c | 26 ++++++++++++++++++++--
>> 7 files changed, 38 insertions(+), 16 deletions(-)
>
> Just realized that this change breaks m68k support. You shouldn't remove
> DRIVER_NAME from fec_devtype[]
>
>
> Sascha
>
WARNING: multiple messages have this Message-ID (diff)
From: Troy Kisky <troy.kisky@boundarydevices.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
u.kleine-koenig@pengutronix.de, LW@KARO-electronics.de,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net/fec: gasket needs to be enabled for some i.mx
Date: Fri, 08 Jul 2011 11:38:09 -0700 [thread overview]
Message-ID: <4E174E91.2090609@boundarydevices.com> (raw)
In-Reply-To: <20110708101810.GE6069@pengutronix.de>
On 7/8/2011 3:18 AM, Sascha Hauer wrote:
> On Fri, Jul 01, 2011 at 06:11:22PM +0800, Shawn Guo wrote:
>> On the recent i.mx (mx25/50/53), there is a gasket inside fec
>> controller which needs to be enabled no matter phy works in MII
>> or RMII mode.
>>
>> The current code enables the gasket only when phy interface is RMII.
>> It's broken when the driver works with a MII phy. The patch uses
>> platform_device_id to distinguish the SoCs that have the gasket and
>> enables it on these SoCs for both MII and RMII mode.
>>
>> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
While you're making changes, you can change this to
Reported-by: Troy Kisky
Thanks
>> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
>> Cc: David S. Miller <davem@davemloft.net>
>> Cc: Sascha Hauer <s.hauer@pengutronix.de>
>> ---
>> arch/arm/mach-imx/clock-imx25.c | 2 +-
>> arch/arm/mach-imx/clock-imx27.c | 2 +-
>> arch/arm/mach-imx/clock-imx35.c | 2 +-
>> arch/arm/mach-mx5/clock-mx51-mx53.c | 4 +-
>> arch/arm/plat-mxc/devices/platform-fec.c | 17 ++++++++-------
>> arch/arm/plat-mxc/include/mach/devices-common.h | 1 +
>> drivers/net/fec.c | 26 ++++++++++++++++++++--
>> 7 files changed, 38 insertions(+), 16 deletions(-)
>
> Just realized that this change breaks m68k support. You shouldn't remove
> DRIVER_NAME from fec_devtype[]
>
>
> Sascha
>
next prev parent reply other threads:[~2011-07-08 18:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1309387098-30680-1-git-send-email-troy.kisky@boundarydevices.com>
2011-06-29 22:50 ` [PATCH 1/1] net/fec: iMX53 needs gasket for both MII and RMII Troy Kisky
2011-06-30 19:04 ` Fabio Estevam
2011-06-30 16:19 ` Shawn Guo
2011-06-30 18:49 ` Troy Kisky
2011-07-01 10:12 ` Shawn Guo
2011-07-01 10:11 ` [PATCH] net/fec: gasket needs to be enabled for some i.mx Shawn Guo
2011-07-01 10:11 ` Shawn Guo
2011-07-04 6:55 ` Sascha Hauer
2011-07-04 6:55 ` Sascha Hauer
2011-07-06 5:14 ` Shawn Guo
2011-07-06 5:14 ` Shawn Guo
2011-07-07 11:12 ` David Miller
2011-07-07 11:12 ` David Miller
2011-07-07 13:41 ` Shawn Guo
2011-07-07 13:41 ` Shawn Guo
2011-07-07 18:44 ` Grant Likely
2011-07-07 18:44 ` Grant Likely
2011-07-08 0:06 ` Shawn Guo
2011-07-08 0:06 ` Shawn Guo
2011-07-22 2:00 ` Shawn Guo
2011-07-22 2:00 ` Shawn Guo
2011-07-08 10:18 ` Sascha Hauer
2011-07-08 10:18 ` Sascha Hauer
2011-07-08 18:38 ` Troy Kisky [this message]
2011-07-08 18:38 ` Troy Kisky
2011-07-09 5:45 ` Shawn Guo
2011-07-09 5:45 ` Shawn Guo
2011-07-09 5:44 ` Shawn Guo
2011-07-09 5:44 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E174E91.2090609@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.