From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: tony.luck@intel.com
Cc: fenghua.yu@intel.com, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: ia64: replace old cpumask functions with new one
Date: Tue, 12 Jul 2011 08:27:08 +0000 [thread overview]
Message-ID: <4E1C055C.1030103@jp.fujitsu.com> (raw)
In-Reply-To: <CA+8MBbLg4jBmaYkVW13WReNm8nyP1p0k3CPN=pQmvwPfRKyeQA@mail.gmail.com>
(2011/07/07 6:14), Tony Luck wrote:
> 2011/6/23 KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>:
>> We plan to remove old obsolete cpumask functions and plan to
>> change task->cpus_allowed implementation in future.
> ...
>> arch/ia64/kernel/smpboot.c | 56 +++++++++++++++---------------
>
> I get some new warnings in this file with your patch:
>
>
> arch/ia64/kernel/smpboot.c:454: warning: passing argument 2 of
> ‘cpumask_set_cpu’ discards qualifiers from pointer target type
> arch/ia64/kernel/smpboot.c:581: warning: passing argument 1 of
> ‘cpumask_clear’ discards qualifiers from pointer target type
> arch/ia64/kernel/smpboot.c:613: warning: passing argument 2 of
> ‘cpumask_set_cpu’ discards qualifiers from pointer target type
> arch/ia64/kernel/smpboot.c:637: warning: passing argument 2 of
> ‘cpumask_set_cpu’ discards qualifiers from pointer target type
> arch/ia64/kernel/smpboot.c:745: warning: passing argument 2 of
> ‘cpumask_clear_cpu’ discards qualifiers from pointer target type
>
> Four of the five involve "cpu_callin_mask" which is "volatile", the other is for
> "cpu_present_mask" - not sure what the problem is for this one.
Sorry for the delay. I'm sorry for the annoying you.
But ummm.. I can't understand the author expect which effect by this volatile.
If I am correct, its volatile has no effect. we can simply remove it.
So, I'll respin this.
Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: tony.luck@intel.com
Cc: fenghua.yu@intel.com, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: ia64: replace old cpumask functions with new one
Date: Tue, 12 Jul 2011 17:27:08 +0900 [thread overview]
Message-ID: <4E1C055C.1030103@jp.fujitsu.com> (raw)
In-Reply-To: <CA+8MBbLg4jBmaYkVW13WReNm8nyP1p0k3CPN=pQmvwPfRKyeQA@mail.gmail.com>
(2011/07/07 6:14), Tony Luck wrote:
> 2011/6/23 KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>:
>> We plan to remove old obsolete cpumask functions and plan to
>> change task->cpus_allowed implementation in future.
> ...
>> arch/ia64/kernel/smpboot.c | 56 +++++++++++++++---------------
>
> I get some new warnings in this file with your patch:
>
>
> arch/ia64/kernel/smpboot.c:454: warning: passing argument 2 of
> ‘cpumask_set_cpu’ discards qualifiers from pointer target type
> arch/ia64/kernel/smpboot.c:581: warning: passing argument 1 of
> ‘cpumask_clear’ discards qualifiers from pointer target type
> arch/ia64/kernel/smpboot.c:613: warning: passing argument 2 of
> ‘cpumask_set_cpu’ discards qualifiers from pointer target type
> arch/ia64/kernel/smpboot.c:637: warning: passing argument 2 of
> ‘cpumask_set_cpu’ discards qualifiers from pointer target type
> arch/ia64/kernel/smpboot.c:745: warning: passing argument 2 of
> ‘cpumask_clear_cpu’ discards qualifiers from pointer target type
>
> Four of the five involve "cpu_callin_mask" which is "volatile", the other is for
> "cpu_present_mask" - not sure what the problem is for this one.
Sorry for the delay. I'm sorry for the annoying you.
But ummm.. I can't understand the author expect which effect by this volatile.
If I am correct, its volatile has no effect. we can simply remove it.
So, I'll respin this.
Thanks.
next prev parent reply other threads:[~2011-07-12 8:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 10:55 ia64: replace old cpumask functions with new one KOSAKI Motohiro
2011-06-23 10:55 ` KOSAKI Motohiro
2011-07-06 21:14 ` Tony Luck
2011-07-06 21:14 ` Tony Luck
2011-07-12 8:27 ` KOSAKI Motohiro [this message]
2011-07-12 8:27 ` KOSAKI Motohiro
2011-07-13 21:47 ` Luck, Tony
2011-07-13 21:47 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1C055C.1030103@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=fenghua.yu@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.