From: Li Zefan <lizf@cn.fujitsu.com>
To: Qiang Zhu <qiang.zhu@yahoo.cn>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: sign a bug in “set_extent_bit”
Date: Wed, 13 Jul 2011 09:30:57 +0800 [thread overview]
Message-ID: <4E1CF551.3060405@cn.fujitsu.com> (raw)
In-Reply-To: <1310485239.13883.YahooMailNeo@web92401.mail.cnh.yahoo.com>
Qiang Zhu wrote:
> hi=20
>=20
> In the end part of =E2=80=9Cset_extent_bit=E2=80=9D=EF=BC=8CI found w=
hen err occurs =EF=BC=8Cthere is no operate to free "prealloc" which ha=
ve been allocated in "alloc_extent_state_atomic"
> this may lead a menory leak when "set_state_bits" failed.
No, it won't. 'prealloc' has been inserted into rbtree before set_state=
_bits()
is called().
> err =3D set_state_bits(tree, prealloc, &bits);
>=20
> if (err) {
> prealloc =3D NULL;
> goto out; // this direct will do nothing because prealloc=3DNULL.
> }
> wish your reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" =
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-07-13 1:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 15:40 sign a bug in “set_extent_bit” Qiang Zhu
2011-07-13 1:30 ` Li Zefan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1CF551.3060405@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=qiang.zhu@yahoo.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.