sign a bug in “set_extent_bit”

sign a bug in “set_extent_bit”

[Qiang Zhu]

hi=C2=A0

In the end part of =E2=80=9Cset_extent_bit=E2=80=9D=EF=BC=8CI found whe=
n err occurs =EF=BC=8Cthere is no operate to free "prealloc" which have=
 been allocated in "alloc_extent_state_atomic"
this may lead a menory leak when "set_state_bits" failed.
err =3D set_state_bits(tree, prealloc, &bits);

if (err) {
prealloc =3D NULL;
goto out; // this direct will do nothing because prealloc=3DNULL.
}
wish your reply.
thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" =
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: sign a bug in “set_extent_bit”

[Li Zefan]

Qiang Zhu wrote:
> hi=20
>=20
> In the end part of =E2=80=9Cset_extent_bit=E2=80=9D=EF=BC=8CI found w=
hen err occurs =EF=BC=8Cthere is no operate to free "prealloc" which ha=
ve been allocated in "alloc_extent_state_atomic"
> this may lead a menory leak when "set_state_bits" failed.

No, it won't. 'prealloc' has been inserted into rbtree before set_state=
_bits()
is called().

> err =3D set_state_bits(tree, prealloc, &bits);
>=20
> if (err) {
> prealloc =3D NULL;
> goto out; // this direct will do nothing because prealloc=3DNULL.
> }
> wish your reply.

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" =
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html