All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Jin <joe.jin@oracle.com>
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: Daniel Stodden <Daniel.Stodden@citrix.com>,
	Jens Axboe <jaxboe@fusionio.com>,
	"annie.li@oracle.com" <annie.li@oracle.com>,
	Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Kurt C Hackel <KURT.HACKEL@oracle.com>,
	Greg Marsden <greg.marsden@oracle.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@kernel.org" <stable@kernel.org>
Subject: Re: [PATCH resubmit] xen-blkfront: Don't send closing  notification to backend in blkfront_closing()
Date: Fri, 15 Jul 2011 15:58:50 +0800	[thread overview]
Message-ID: <4E1FF33A.8090101@oracle.com> (raw)
In-Reply-To: <1310634779.634.480.camel@zakaz.uk.xensource.com>

On 07/14/11 17:12, Ian Campbell wrote:
> On Thu, 2011-07-14 at 09:55 +0100, Joe Jin wrote:
>> On 07/14/11 16:13, Ian Campbell wrote:
>>> On Wed, 2011-07-13 at 01:47 +0100, Joe Jin wrote:
> 
>>>
>>> I'm wondering if we might not be better off deferring the disconnect on
>>> the backend side until the frontend enters XenbusStateClosed instead of
>>> doing it in closing.
>>
>> Yes this fix from backend side works too, also this looks reasonable than 
>> fix in frontend.
> 
> I guess there is either a missing "more" or "less" in that sentence ;-)
> 
> The nice thing about a backend fix is that you don't need to go round
> propagating the fix into distros etc and updating existing deployed
> guests (not to mention non-Linux frontends).

Indeed ;)

> 
> I actually thought blkback had something like this already in older
> "classic" Xen kernels but it seems like the patch never made it out of
> the XCP patch queue :-(. See
> http://xenbits.xen.org/hg/XCP/linux-2.6.32.pq.hg/file/tip/CA-7672-blkback-shutdown.patch
> (which appears to also incorporate a toolstack directed graceful
> shutdown of some sort as well as deferring the device close).
> 
> Daniel, do you know of any plans to extricate that stuff from the XCP
> patch queue for upstream? Are there any other patches (e.g. incremental
> fixes) in that pq which should go along with it?

Looking forward push this patch to upstream!

Joe 


WARNING: multiple messages have this Message-ID (diff)
From: Joe Jin <joe.jin@oracle.com>
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Jens Axboe <jaxboe@fusionio.com>,
	Greg Marsden <greg.marsden@oracle.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"annie.li@oracle.com" <annie.li@oracle.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Kurt C Hackel <KURT.HACKEL@oracle.com>,
	"stable@kernel.org" <stable@kernel.org>,
	Daniel Stodden <Daniel.Stodden@citrix.com>
Subject: Re: [PATCH resubmit] xen-blkfront: Don't send closing notification to backend in blkfront_closing()
Date: Fri, 15 Jul 2011 15:58:50 +0800	[thread overview]
Message-ID: <4E1FF33A.8090101@oracle.com> (raw)
In-Reply-To: <1310634779.634.480.camel@zakaz.uk.xensource.com>

On 07/14/11 17:12, Ian Campbell wrote:
> On Thu, 2011-07-14 at 09:55 +0100, Joe Jin wrote:
>> On 07/14/11 16:13, Ian Campbell wrote:
>>> On Wed, 2011-07-13 at 01:47 +0100, Joe Jin wrote:
> 
>>>
>>> I'm wondering if we might not be better off deferring the disconnect on
>>> the backend side until the frontend enters XenbusStateClosed instead of
>>> doing it in closing.
>>
>> Yes this fix from backend side works too, also this looks reasonable than 
>> fix in frontend.
> 
> I guess there is either a missing "more" or "less" in that sentence ;-)
> 
> The nice thing about a backend fix is that you don't need to go round
> propagating the fix into distros etc and updating existing deployed
> guests (not to mention non-Linux frontends).

Indeed ;)

> 
> I actually thought blkback had something like this already in older
> "classic" Xen kernels but it seems like the patch never made it out of
> the XCP patch queue :-(. See
> http://xenbits.xen.org/hg/XCP/linux-2.6.32.pq.hg/file/tip/CA-7672-blkback-shutdown.patch
> (which appears to also incorporate a toolstack directed graceful
> shutdown of some sort as well as deferring the device close).
> 
> Daniel, do you know of any plans to extricate that stuff from the XCP
> patch queue for upstream? Are there any other patches (e.g. incremental
> fixes) in that pq which should go along with it?

Looking forward push this patch to upstream!

Joe 

_______________________________________________
stable mailing list
stable@linux.kernel.org
http://linux.kernel.org/mailman/listinfo/stable

  reply	other threads:[~2011-07-15  7:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-13  0:47 [PATCH resubmit] xen-blkfront: Don't send closing notification to backend in blkfront_closing() Joe Jin
2011-07-13  0:47 ` Joe Jin
2011-07-14  8:13 ` Ian Campbell
2011-07-14  8:13   ` Ian Campbell
2011-07-14  8:55   ` Joe Jin
2011-07-14  9:12     ` Ian Campbell
2011-07-14  9:12       ` Ian Campbell
2011-07-15  7:58       ` Joe Jin [this message]
2011-07-15  7:58         ` Joe Jin
2011-07-19 13:21         ` [Xen-devel] " Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1FF33A.8090101@oracle.com \
    --to=joe.jin@oracle.com \
    --cc=Daniel.Stodden@citrix.com \
    --cc=Ian.Campbell@eu.citrix.com \
    --cc=Jeremy.Fitzhardinge@citrix.com \
    --cc=KURT.HACKEL@oracle.com \
    --cc=annie.li@oracle.com \
    --cc=greg.marsden@oracle.com \
    --cc=jaxboe@fusionio.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.