From: David Ahern <dsahern@gmail.com>
To: mingo@elte.hu, fweisbec@gmail.com
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
acme@ghostprotocols.net, peterz@infradead.org, paulus@samba.org
Subject: Re: [PATCH] perf tools, x86: fix 32-bit compile on 64-bit system
Date: Fri, 15 Jul 2011 09:27:20 -0600 [thread overview]
Message-ID: <4E205C58.30607@gmail.com> (raw)
In-Reply-To: <1310420304-21452-1-git-send-email-dsahern@gmail.com>
On 07/11/2011 03:38 PM, David Ahern wrote:
> Builds for 32-bit binaries on a 64-bit host currently fail with the error:
>
> gcc -o /tmp/perf-ppc/bench/mem-memcpy-x86-64-asm.o -c -fno-omit-frame-pointer -ggdb3 -Wall -Wextra -std=gnu99 -Werror -O6 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Wformat-y2k -Wshadow -Winit-self -Wpacked -Wredundant-decls -Wstrict-aliasing=3 -Wswitch-default -Wswitch-enum -Wno-system-headers -Wundef -Wwrite-strings -Wbad-function-cast -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wstrict-prototypes -Wdeclaration-after-statement -m32 -fstack-protector-all -Wstack-protector -Wvolatile-register-var -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Iutil/include -Iarch/x86/include -I/tmp/perf-ppc/ -DLIBELF_NO_MMAP -DDWARF_SUPPORT -DNO_NEWT_SUPPORT -DNO_LIBPERL -DNO_LIBPYTHON -DHAVE_CPLUS_DEMANGLE -DNO_STRLCPY -DARCH_X86_64 bench/mem-memcpy-x86-64-as
m.S
> bench/../../../arch/x86/lib/memcpy_64.S: Assembler messages:
> bench/../../../arch/x86/lib/memcpy_64.S:29: Error: bad register name `%rdi'
> bench/../../../arch/x86/lib/memcpy_64.S:34: Error: invalid instruction suffix for `movs'
> bench/../../../arch/x86/lib/memcpy_64.S:50: Error: bad register name `%rdi'
> bench/../../../arch/x86/lib/memcpy_64.S:61: Error: bad register name `%rdi'
> ...
>
> The problem is the detection of the host arch without considering passed in
> flags. This change fixes 32-bit builds via:
>
> make EXTRA_CFLAGS=-m32
>
> and 64-bit builds still reference the memcpy_64.S.
>
Fairly trivial change to the Makefile. Any objections? I believe Arnaldo
is out for a few more days and realistically another week to get through
a month's backlog.
David
> Signed-off-by: David Ahern <dsahern@gmail.com>
> ---
> tools/perf/Makefile | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index 940257b..c168366 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -52,7 +52,10 @@ ifeq ($(ARCH),i386)
> endif
> ifeq ($(ARCH),x86_64)
> ARCH := x86
> - IS_X86_64 := $(shell echo __x86_64__ | ${CC} -E -xc - | tail -n 1)
> + IS_X86_64 := 0
> + ifeq (, $(findstring m32,$(EXTRA_CFLAGS)))
> + IS_X86_64 := $(shell echo __x86_64__ | ${CC} -E -xc - | tail -n 1)
> + endif
> ifeq (${IS_X86_64}, 1)
> RAW_ARCH := x86_64
> ARCH_CFLAGS := -DARCH_X86_64
WARNING: multiple messages have this Message-ID (diff)
From: David Ahern <dsahern@gmail.com>
To: mingo@elte.hu, fweisbec@gmail.com
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
acme@ghostprotocols.net, peterz@infradead.org, paulus@samba.org
Subject: Re: [PATCH] perf tools, x86: fix 32-bit compile on 64-bit system
Date: Fri, 15 Jul 2011 09:27:20 -0600 [thread overview]
Message-ID: <4E205C58.30607@gmail.com> (raw)
In-Reply-To: <1310420304-21452-1-git-send-email-dsahern@gmail.com>
On 07/11/2011 03:38 PM, David Ahern wrote:
> Builds for 32-bit binaries on a 64-bit host currently fail with the error:
>
> gcc -o /tmp/perf-ppc/bench/mem-memcpy-x86-64-asm.o -c -fno-omit-frame-pointer -ggdb3 -Wall -Wextra -std=gnu99 -Werror -O6 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Wformat-y2k -Wshadow -Winit-self -Wpacked -Wredundant-decls -Wstrict-aliasing=3 -Wswitch-default -Wswitch-enum -Wno-system-headers -Wundef -Wwrite-strings -Wbad-function-cast -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wstrict-prototypes -Wdeclaration-after-statement -m32 -fstack-protector-all -Wstack-protector -Wvolatile-register-var -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Iutil/include -Iarch/x86/include -I/tmp/perf-ppc/ -DLIBELF_NO_MMAP -DDWARF_SUPPORT -DNO_NEWT_SUPPORT -DNO_LIBPERL -DNO_LIBPYTHON -DHAVE_CPLUS_DEMANGLE -DNO_STRLCPY -DARCH_X86_64 bench/mem-memcpy-x86-64-asm.S
> bench/../../../arch/x86/lib/memcpy_64.S: Assembler messages:
> bench/../../../arch/x86/lib/memcpy_64.S:29: Error: bad register name `%rdi'
> bench/../../../arch/x86/lib/memcpy_64.S:34: Error: invalid instruction suffix for `movs'
> bench/../../../arch/x86/lib/memcpy_64.S:50: Error: bad register name `%rdi'
> bench/../../../arch/x86/lib/memcpy_64.S:61: Error: bad register name `%rdi'
> ...
>
> The problem is the detection of the host arch without considering passed in
> flags. This change fixes 32-bit builds via:
>
> make EXTRA_CFLAGS=-m32
>
> and 64-bit builds still reference the memcpy_64.S.
>
Fairly trivial change to the Makefile. Any objections? I believe Arnaldo
is out for a few more days and realistically another week to get through
a month's backlog.
David
> Signed-off-by: David Ahern <dsahern@gmail.com>
> ---
> tools/perf/Makefile | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index 940257b..c168366 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -52,7 +52,10 @@ ifeq ($(ARCH),i386)
> endif
> ifeq ($(ARCH),x86_64)
> ARCH := x86
> - IS_X86_64 := $(shell echo __x86_64__ | ${CC} -E -xc - | tail -n 1)
> + IS_X86_64 := 0
> + ifeq (, $(findstring m32,$(EXTRA_CFLAGS)))
> + IS_X86_64 := $(shell echo __x86_64__ | ${CC} -E -xc - | tail -n 1)
> + endif
> ifeq (${IS_X86_64}, 1)
> RAW_ARCH := x86_64
> ARCH_CFLAGS := -DARCH_X86_64
next prev parent reply other threads:[~2011-07-15 15:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 21:38 [PATCH] perf tools, x86: fix 32-bit compile on 64-bit system David Ahern
2011-07-11 21:38 ` David Ahern
2011-07-15 15:27 ` David Ahern [this message]
2011-07-15 15:27 ` David Ahern
2011-07-15 15:32 ` Frederic Weisbecker
2011-07-15 15:32 ` Frederic Weisbecker
2011-07-15 15:38 ` Peter Zijlstra
2011-07-21 14:30 ` David Ahern
2011-07-21 14:30 ` David Ahern
2011-07-21 15:36 ` [tip:perf/urgent] perf tools, x86: Fix " tip-bot for David Ahern
2011-07-21 16:07 ` H. Peter Anvin
2011-07-21 16:24 ` David Ahern
2011-07-21 18:03 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E205C58.30607@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.