Re: [PATCH 3/4] stk: Handle set up call in handled_notify

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]

Hi Andrew, Jeevaka,

<snip>

> +static void proactive_command_handled_end(struct ofono_stk *stk)
> +{
> +	stk->modem_handled_cmd = FALSE;
> +
> +	if (stk->pending_cmd == NULL)
> +		return;
> +
> +	switch(stk->pending_cmd->type) {
> +	case STK_COMMAND_TYPE_SETUP_CALL:
> +	{
> +		struct ofono_voicecall *vc = NULL;
> +		struct ofono_atom *vc_atom;
> +
> +		vc_atom = __ofono_modem_find_atom(
> +					__ofono_atom_get_modem(stk->atom),
> +					OFONO_ATOM_TYPE_VOICECALL);
> +		if (vc_atom)
> +			vc = __ofono_atom_get_data(vc_atom);
> +
> +		if (vc != NULL)
> +			__ofono_voicecall_clear_alpha_and_icon_id(vc);
> +
> +		break;
> +	}
> +
> +	default:
> +		break;
> +	}
> +}
> +

So I'm still not sure this part is actually needed.  Once the user has
acknowledged the call, there is no way for us to cancel it until the
call is notified to the voicecall driver.  So unless the modem is drunk,
I don't really see the need to cover this case.

Once the call is notified to voicecall driver, then the need for
clearing alpha/icon id disappears.  The voicecall driver will do this
automatically based on the ofono_voicecall_disconnected notification.

What do you guys think?

Regards,
-Denis