All of lore.kernel.org
 help / color / mirror / Atom feed
From: jeevaka.badrappan@linux.intel.com
To: ofono@ofono.org
Subject: Re: [PATCH 2/4] voicecall: api for set/clear alpha and icon id
Date: Fri, 15 Jul 2011 10:24:55 -0700	[thread overview]
Message-ID: <62556.10.254.189.70.1310750695.squirrel@linux.intel.com> (raw)
In-Reply-To: <4E2065EE.7010902@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 625 bytes --]

Hi Denis,

>> +
>> +	number = phone_number_to_string(&req->ph);
>> +
>> +	if (!strcmp(number, "112")) {
>> +		struct ofono_modem *modem = __ofono_atom_get_modem(vc->atom);
>> +
>> +		__ofono_modem_inc_emergency_mode(modem);
>> +	}
>
> I think we should do this step in the block of code in
> ofono_voicecall_notify dealing with modem callsetup.  See below for more:

Emergency mode for all other dial(user initiated, ofono handled setup
call) has been activated before we issue dial request to modem. Also I
believe its better to activate it here rather than in
ofono_voicecall_notify.

Regards,
Jeevaka

  parent reply	other threads:[~2011-07-15 17:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-15 12:42 [PATCH 0/4] Add support for modem handled setup call proactive command Jeevaka Badrappan
2011-07-15 12:42 ` [PATCH 1/4] include: Add driver api for user confirmation Jeevaka Badrappan
2011-07-15 16:10   ` Denis Kenzior
2011-07-15 12:42 ` [PATCH 2/4] voicecall: api for set/clear alpha and icon id Jeevaka Badrappan
2011-07-15 16:08   ` Denis Kenzior
2011-07-15 16:41     ` jeevaka.badrappan
2011-07-15 17:24     ` jeevaka.badrappan [this message]
2011-07-15 17:36       ` Denis Kenzior
2011-07-15 12:42 ` [PATCH 3/4] stk: Handle set up call in handled_notify Jeevaka Badrappan
2011-07-15 12:46   ` jeevaka.badrappan
2011-07-15 16:11     ` Denis Kenzior
2011-07-15 16:34   ` Denis Kenzior
2011-07-15 16:45     ` jeevaka.badrappan
2011-07-15 16:59       ` Denis Kenzior
2011-07-15 12:42 ` [PATCH 4/4] ifxmodem: add support for user_confirmation in stk Jeevaka Badrappan
2011-07-15 16:10   ` Denis Kenzior
  -- strict thread matches above, loose matches on Subject: below --
2011-07-06 10:06 [PATCH 0/4] Add support for modem handled setup call proactive command Jeevaka Badrappan
2011-07-06 10:06 ` [PATCH 2/4] voicecall: api for set/clear alpha and icon id Jeevaka Badrappan
2011-07-06  6:38   ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62556.10.254.189.70.1310750695.squirrel@linux.intel.com \
    --to=jeevaka.badrappan@linux.intel.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.