All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <amwang@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Mel Gorman <mgorman@suse.de>,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	Andi Kleen <andi@firstfloor.org>,
	linux-mm@kvack.org
Subject: Re: [Patch] mm: make CONFIG_NUMA depend on CONFIG_SYSFS
Date: Tue, 19 Jul 2011 15:05:05 +0800	[thread overview]
Message-ID: <4E252CA1.803@redhat.com> (raw)
In-Reply-To: <1311058498.16961.15.camel@edumazet-laptop>

于 2011年07月19日 14:54, Eric Dumazet 写道:
> Le mardi 19 juillet 2011 à 14:20 +0800, Cong Wang a écrit :
>
>> Hmm, since we don't have to enable SYSFS for NUMA, how about
>> make a new Kconfig for drivers/base/node.c? I.e., CONFIG_NUMA_SYSFS,
>> like patch below.
>>
>
> I dont quite understand this patch, nor the idea behind it.
>
> You can have a NUMA kernel (for appropriate percpu locality or whatever
> kernel data), and yet user land processes unable to use numactl if SYSFS
> is not enabled. I dont see a problem.
>

Both Pekka and Mel pointed out that it makes sense to have NUMA kernel
without SYSFS, this means sysfs interface is not a must for NUMA kernel.
Thus, I think it makes sense to separate the numa sysfs code out.

WARNING: multiple messages have this Message-ID (diff)
From: Cong Wang <amwang@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Mel Gorman <mgorman@suse.de>,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	Andi Kleen <andi@firstfloor.org>,
	linux-mm@kvack.org
Subject: Re: [Patch] mm: make CONFIG_NUMA depend on CONFIG_SYSFS
Date: Tue, 19 Jul 2011 15:05:05 +0800	[thread overview]
Message-ID: <4E252CA1.803@redhat.com> (raw)
In-Reply-To: <1311058498.16961.15.camel@edumazet-laptop>

ao? 2011a1'07ae??19ae?JPY 14:54, Eric Dumazet a??e??:
> Le mardi 19 juillet 2011 A  14:20 +0800, Cong Wang a A(C)crit :
>
>> Hmm, since we don't have to enable SYSFS for NUMA, how about
>> make a new Kconfig for drivers/base/node.c? I.e., CONFIG_NUMA_SYSFS,
>> like patch below.
>>
>
> I dont quite understand this patch, nor the idea behind it.
>
> You can have a NUMA kernel (for appropriate percpu locality or whatever
> kernel data), and yet user land processes unable to use numactl if SYSFS
> is not enabled. I dont see a problem.
>

Both Pekka and Mel pointed out that it makes sense to have NUMA kernel
without SYSFS, this means sysfs interface is not a must for NUMA kernel.
Thus, I think it makes sense to separate the numa sysfs code out.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-07-19  7:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-18 11:18 [Patch] mm: make CONFIG_NUMA depend on CONFIG_SYSFS Amerigo Wang
2011-07-18 11:18 ` Amerigo Wang
2011-07-18 12:14 ` Pekka Enberg
2011-07-18 12:14   ` Pekka Enberg
2011-07-18 17:09   ` Andi Kleen
2011-07-18 17:09     ` Andi Kleen
2011-07-18 17:14     ` Randy Dunlap
2011-07-18 17:14       ` Randy Dunlap
2011-07-19  6:07       ` Cong Wang
2011-07-19  6:07         ` Cong Wang
2011-07-18 13:52 ` Mel Gorman
2011-07-18 13:52   ` Mel Gorman
2011-07-19  6:20   ` Cong Wang
2011-07-19  6:20     ` Cong Wang
2011-07-19  6:54     ` Eric Dumazet
2011-07-19  6:54       ` Eric Dumazet
2011-07-19  7:05       ` Cong Wang [this message]
2011-07-19  7:05         ` Cong Wang
2011-07-19  8:49         ` Eric Dumazet
2011-07-19  8:49           ` Eric Dumazet
2011-07-19  9:11           ` Cong Wang
2011-07-19  9:11             ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E252CA1.803@redhat.com \
    --to=amwang@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.