From: Pavel Roskin <proski@gnu.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: Re: [PATCH 1/2] bcma: inform drivers about translation bits needed for the board
Date: Tue, 19 Jul 2011 10:38:51 -0400 [thread overview]
Message-ID: <4E2596FB.5030105@gnu.org> (raw)
In-Reply-To: <1311062701-3455-1-git-send-email-zajec5@gmail.com>
On 07/19/2011 04:05 AM, Rafał Miłecki wrote:
> When using DMA, drivers need to pass special translation info to the
> hardware.
>
> Signed-off-by: Rafał Miłecki<zajec5@gmail.com>
I'm not sure why you are copying it to me.
> + switch (bus->hosttype) {
> + case BCMA_HOSTTYPE_PCI:
> + return 0x40000000;
This is already implemented in ssb_dma_translation(), and the constant
is called SSB_PCI_DMA. I think we need a named constant here as well,
either SSB_PCI_DMA or a new constant BCMA_PCI_DMA.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2011-07-19 14:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 8:05 [PATCH 1/2] bcma: inform drivers about translation bits needed for the board Rafał Miłecki
2011-07-19 8:05 ` Rafał Miłecki
2011-07-19 8:05 ` [PATCH 2/2] b43: bcma: get DMA translation bits Rafał Miłecki
2011-07-19 8:05 ` Rafał Miłecki
2011-07-19 14:52 ` Pavel Roskin
2011-07-19 18:46 ` Rafał Miłecki
2011-07-19 18:46 ` Rafał Miłecki
2011-07-19 14:38 ` Pavel Roskin [this message]
2011-07-19 17:14 ` [PATCH 1/2] bcma: inform drivers about translation bits needed for the board Rafał Miłecki
2011-07-19 17:14 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2596FB.5030105@gnu.org \
--to=proski@gnu.org \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.