From: Pavel Roskin <proski@gnu.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: Re: [PATCH 2/2] b43: bcma: get DMA translation bits
Date: Tue, 19 Jul 2011 10:52:11 -0400 [thread overview]
Message-ID: <4E259A1B.3040306@gnu.org> (raw)
In-Reply-To: <1311062701-3455-2-git-send-email-zajec5@gmail.com>
On 07/19/2011 04:05 AM, Rafał Miłecki wrote:
> +#ifdef CONFIG_B43_BCMA
> + case B43_BUS_BCMA:
> + dma->translation = bcma_dma_translation(dev->dev->bdev->bus);
> + break;
> +#endif
How about we set dma->translation to 0x40000000 for 32-bit DMA and to
0x80000000 for 64-bit DMA and remove shifting translation by 1 in the
64-bit DMA code? There should be a warning for non-PCI devices here.
No ifdefs, no separate treatment of different buses.
I think we are adding too much complexity here.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2011-07-19 14:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 8:05 [PATCH 1/2] bcma: inform drivers about translation bits needed for the board Rafał Miłecki
2011-07-19 8:05 ` Rafał Miłecki
2011-07-19 8:05 ` [PATCH 2/2] b43: bcma: get DMA translation bits Rafał Miłecki
2011-07-19 8:05 ` Rafał Miłecki
2011-07-19 14:52 ` Pavel Roskin [this message]
2011-07-19 18:46 ` Rafał Miłecki
2011-07-19 18:46 ` Rafał Miłecki
2011-07-19 14:38 ` [PATCH 1/2] bcma: inform drivers about translation bits needed for the board Pavel Roskin
2011-07-19 17:14 ` Rafał Miłecki
2011-07-19 17:14 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E259A1B.3040306@gnu.org \
--to=proski@gnu.org \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.