Re: [Qemu-devel] [PATCH] Remove debugging messages.

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 2607 bytes --]

On 2011-07-19 21:23, Richard W.M. Jones wrote:
> From: "Richard W.M. Jones" <rjones@redhat.com>
> 
> When using qemu -machine accel=kvm:tcg, if KVM is not available you
> get a load of debugging output:
> 
>   Could not access KVM kernel module: No such file or directory
>   failed to initialize KVM: No such file or directory
>   Back to tcg accelerator.
> 
> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
> ---
>  kvm-all.c |    1 -
>  vl.c      |   14 --------------
>  2 files changed, 0 insertions(+), 15 deletions(-)
> 
> diff --git a/kvm-all.c b/kvm-all.c
> index cbc2532..35d698b 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -713,7 +713,6 @@ int kvm_init(void)
>      s->vmfd = -1;
>      s->fd = qemu_open("/dev/kvm", O_RDWR);
>      if (s->fd == -1) {
> -        fprintf(stderr, "Could not access KVM kernel module: %m\n");
>          ret = -errno;
>          goto err;
>      }
> diff --git a/vl.c b/vl.c
> index fcd7395..83a08b6 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1922,7 +1922,6 @@ static int configure_accelerator(void)
>      char buf[10];
>      int i, ret;
>      bool accel_initalised = 0;
> -    bool init_failed = 0;
>  
>      QemuOptsList *list = qemu_find_opts("machine");
>      if (!QTAILQ_EMPTY(&list->head)) {
> @@ -1944,15 +1943,6 @@ static int configure_accelerator(void)
>                  *(accel_list[i].allowed) = 1;
>                  ret = accel_list[i].init();
>                  if (ret < 0) {
> -                    init_failed = 1;
> -                    if (!accel_list[i].available()) {
> -                        printf("%s not supported for this target\n",
> -                               accel_list[i].name);
> -                    } else {
> -                        fprintf(stderr, "failed to initialize %s: %s\n",
> -                                accel_list[i].name,
> -                                strerror(-ret));
> -                    }
>                      *(accel_list[i].allowed) = 0;
>                  } else {
>                      accel_initalised = 1;
> @@ -1970,10 +1960,6 @@ static int configure_accelerator(void)
>          exit(1);
>      }
>  
> -    if (init_failed) {
> -        fprintf(stderr, "Back to %s accelerator.\n", accel_list[i].name);
> -    }
> -
>      return !accel_initalised;
>  }
>  

I agree the current situation is unfortunate.

However, I think dumping some error information is useful when either no
alternatives were specified or some verbose mode was selected. Maybe add
an option "verbose=on|off" to -machine?

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]