From: Anthony Liguori <aliguori@us.ibm.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Remove debugging messages.
Date: Wed, 20 Jul 2011 07:51:29 -0500 [thread overview]
Message-ID: <4E26CF51.1080504@us.ibm.com> (raw)
In-Reply-To: <20110720085022.GF2532@amd.home.annexia.org>
On 07/20/2011 03:50 AM, Richard W.M. Jones wrote:
> On Tue, Jul 19, 2011 at 04:56:24PM -0500, Anthony Liguori wrote:
>> Can't libguestfs just ignore the messages?
>
> It does, but they get printed to stderr which confuses users and has
> caused several bug reports in the past. We'll probably have to
> redirect them somewhere.
Given the large number of reports we've gotten in the past where poor
performance was caused by the expectation that a user had KVM enabled
and really didn't, I think it's more important to overcommunicate to the
user here.
If in the case of libguestfs, you think this isn't something a user
should worry about, you can just filter out the message before it hits
stderr.
Regards,
Anthony Liguori
>
>>> $ qemu -nographic -device \?
>>> KVM not supported for this target
>>> No accelerator found!
>>
>> Hrm, what's your HEAD because mine doesn't exhibit this behavior.
>
> Right. This seems to be a problem specific to Fedora's package. I
> also can't reproduce it with upstream.
>
> Rich.
>
next prev parent reply other threads:[~2011-07-20 12:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 19:23 [Qemu-devel] [PATCH 1/1] Remove debugging messages Richard W.M. Jones
2011-07-19 19:23 ` [Qemu-devel] [PATCH] " Richard W.M. Jones
2011-07-19 19:47 ` Jan Kiszka
2011-07-19 19:49 ` Michael Tokarev
2011-07-19 20:50 ` Richard W.M. Jones
2011-07-19 20:04 ` Anthony Liguori
2011-07-19 20:59 ` Richard W.M. Jones
2011-07-19 21:56 ` Anthony Liguori
2011-07-20 8:50 ` Richard W.M. Jones
2011-07-20 12:51 ` Anthony Liguori [this message]
2011-07-20 17:38 ` Richard W.M. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E26CF51.1080504@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.